From da66e17292c58bd907275bf790ef0e9fefd44c59 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Tue, 10 Mar 2020 11:31:57 +0100 Subject: [PATCH 01/13] no default build phase for dep-check --- pom.xml | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/pom.xml b/pom.xml index 3006dd7b61bc..70ebced6d95a 100644 --- a/pom.xml +++ b/pom.xml @@ -67,6 +67,7 @@ 3.2.0 3.12.0 3.0.0 + 5.3.0 2.5.3 3.1.0 3.8.2 @@ -999,6 +1000,22 @@ + + org.owasp + dependency-check-maven + ${cs.owasp.dependency-checker-plugin.version} + + true + true + + + + + check + + + + org.apache.maven.plugins maven-compiler-plugin @@ -1136,6 +1153,18 @@ + + org.owasp + dependency-check-maven + ${cs.owasp.dependency-checker-plugin.version} + + + + aggregate + + + + org.codehaus.mojo findbugs-maven-plugin From 37654d0b5ecb7ea50d619d8bd35c26f1de01e8bb Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Fri, 14 Feb 2020 13:44:41 +0100 Subject: [PATCH 02/13] replace findbugs with spotbugs --- pom.xml | 40 ++++++++++++++++------------------------ 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/pom.xml b/pom.xml index 70ebced6d95a..8165fa449bb1 100644 --- a/pom.xml +++ b/pom.xml @@ -63,7 +63,8 @@ 3.8.1 3.1.1 2.22.2 - 3.0.5 + 3.1.12 + 3.1.12.2 3.2.0 3.12.0 3.0.0 @@ -720,11 +721,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin + ${cs.spotbugs-maven-plugin.version} - cloudstack-findbugs + cloudstack-spotbugs none check @@ -1070,19 +1072,9 @@ ${cs.dependency-plugin.version} - org.codehaus.mojo - cobertura-maven-plugin - - - html - xml - - - - - org.codehaus.mojo - findbugs-maven-plugin - ${cs.findbugs-plugin.version} + com.github.spotbugs + spotbugs-maven-plugin + ${cs.spotbugs-maven-plugin.version} org.apache.cloudstack @@ -1100,7 +1092,7 @@ - cloudstack-findbugs + cloudstack-spotbugs check @@ -1166,9 +1158,9 @@ - org.codehaus.mojo - findbugs-maven-plugin - ${cs.findbugs-plugin.version} + com.github.spotbugs + spotbugs-maven-plugin + ${cs.spotbugs-maven-plugin.version} Low Default @@ -1282,11 +1274,11 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - cloudstack-findbugs + cloudstack-spotbugs process-classes true From cdb7555b79b31a0bafee0f27b0642c70decfd255 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Sun, 16 Feb 2020 14:36:18 +0100 Subject: [PATCH 03/13] for target site checkstyle needs explicit version --- tools/checkstyle/pom.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tools/checkstyle/pom.xml b/tools/checkstyle/pom.xml index c07c01667ef9..0e99a8fb268e 100644 --- a/tools/checkstyle/pom.xml +++ b/tools/checkstyle/pom.xml @@ -28,4 +28,14 @@ UTF-8 UTF-8 + + + + + org.apache.maven.plugins + maven-site-plugin + 3.8.2 + + + From 60b3dba6f3b2783748521e467c6c3bfe3f1003e8 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Sun, 16 Feb 2020 14:40:28 +0100 Subject: [PATCH 04/13] cleanup --- pom.xml | 40 +++++++++++++++++++++++++++------------- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/pom.xml b/pom.xml index 8165fa449bb1..36463a68173c 100644 --- a/pom.xml +++ b/pom.xml @@ -136,7 +136,7 @@ 1.9.3 0.17 3.26.0-GA - 3.1.1 + 3.1.1 1.3.2 2.3.0 2.3.2 @@ -174,7 +174,6 @@ apache.cloudstack.site - ${site.deploy.url} @@ -1140,6 +1139,31 @@ maven-failsafe-plugin ${cs.failsafe-plugin.version} + + org.jacoco + jacoco-maven-plugin + ${cs.jacoco-plugin.version} + + + prepare-coverage-agent + + prepare-agent + + + + produce-coverage-reports + test + + report + + + + + + org.apache.maven.plugins + maven-site-plugin + ${cs.site-plugin.version} + @@ -1170,22 +1194,12 @@ org.apache.maven.plugins maven-javadoc-plugin - ${cs.javadoc.version} + ${cs.maven-javadoc-plugin.version} 128m 1g - - org.apache.maven.plugins - maven-project-info-reports-plugin - ${cs.project-info-plugin.version} - - - org.codehaus.mojo - cobertura-maven-plugin - ${cs.cobertura-plugin.version} - org.apache.maven.plugins maven-site-plugin From 2c8143f7260eeed5f9746267f93897e0e75f39cc Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Sun, 16 Feb 2020 17:21:31 +0100 Subject: [PATCH 05/13] new clover --- pom.xml | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/pom.xml b/pom.xml index 36463a68173c..5a0315ff5b02 100644 --- a/pom.xml +++ b/pom.xml @@ -73,6 +73,7 @@ 3.1.0 3.8.2 2.22.2 + 4.4.1 1.2.17 @@ -733,6 +734,42 @@ + + org.openclover + clover-maven-plugin + ${cs.clover-maven-plugin.version} + + threaded + 100 + 0% + true + true + true + + + + main + verify + + instrument + aggregate + check + log + + + + site + pre-site + + instrument + aggregate + + save-history + + + + + @@ -1198,6 +1235,7 @@ 128m 1g + public @@ -1298,6 +1336,15 @@ + + org.openclover + clover-maven-plugin + ${cs.clover-maven-plugin.version} + + true + true + + From 7a8b79b1c14d2fb68bc6e590d9d6a8cc9c29b9c4 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Wed, 11 Mar 2020 00:52:58 +0100 Subject: [PATCH 06/13] remove reports in error --- pom.xml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/pom.xml b/pom.xml index 5a0315ff5b02..67e72fd0fff7 100644 --- a/pom.xml +++ b/pom.xml @@ -1124,7 +1124,6 @@ true false 2048 - findbugsExcludeFilter.xml @@ -1225,17 +1224,6 @@ Low Default - ${basedir}/findbugsExcludeFilter.xml - - - - org.apache.maven.plugins - maven-javadoc-plugin - ${cs.maven-javadoc-plugin.version} - - 128m - 1g - public From cea782900145642dc3d784a87c5a699020a2feed Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Wed, 11 Mar 2020 12:57:34 +0100 Subject: [PATCH 07/13] jacoco and clover --- pom.xml | 27 ++++++++++++++++++++------- tools/checkstyle/pom.xml | 5 +++++ 2 files changed, 25 insertions(+), 7 deletions(-) diff --git a/pom.xml b/pom.xml index 67e72fd0fff7..6049bb3c213e 100644 --- a/pom.xml +++ b/pom.xml @@ -59,7 +59,7 @@ 1.8 3.0.0 3.1.0 - 2.7 + 0.8.3 3.8.1 3.1.1 2.22.2 @@ -734,6 +734,11 @@ + + org.jacoco + jacoco-maven-plugin + ${cs.jacoco-plugin.version} + org.openclover clover-maven-plugin @@ -765,7 +770,6 @@ aggregate save-history - @@ -1167,7 +1171,7 @@ ${cs.surefire-plugin.version} false - -Djava.security.egd=file:/dev/./urandom -noverify + @{argLine} -Djava.security.egd=file:/dev/./urandom -noverify @@ -1236,6 +1240,19 @@ maven-resources-plugin ${cs.resources-plugin.version} + + org.jacoco + jacoco-maven-plugin + ${cs.jacoco-plugin.version} + + + + + report + + + + @@ -1309,10 +1326,6 @@ enablefindbugs - - - - com.github.spotbugs spotbugs-maven-plugin diff --git a/tools/checkstyle/pom.xml b/tools/checkstyle/pom.xml index 0e99a8fb268e..a63f62c9aa1b 100644 --- a/tools/checkstyle/pom.xml +++ b/tools/checkstyle/pom.xml @@ -36,6 +36,11 @@ maven-site-plugin 3.8.2 + + org.openclover + clover-maven-plugin + 4.4.1 + From 94da2900ae1c276815a667b47c52820e197306f9 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Wed, 11 Mar 2020 15:59:02 +0100 Subject: [PATCH 08/13] but it worked on my laptop?? --- pom.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pom.xml b/pom.xml index 6049bb3c213e..4e47e3e1aeab 100644 --- a/pom.xml +++ b/pom.xml @@ -634,6 +634,11 @@ wsdl4j 1.6.3 + + org.apache.maven.doxia + doxia-site-renderer + 1.8.1 + From 68d6f7dcbb0d5d8e80dd05e279d42bde636f24b6 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Thu, 12 Mar 2020 09:48:41 +0100 Subject: [PATCH 09/13] version upgrades --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 4e47e3e1aeab..4c54a59d3a8d 100644 --- a/pom.xml +++ b/pom.xml @@ -94,7 +94,7 @@ 1.10 1.2.2 2.7.0 - 0.5 + 1.0-dev 2.6 2.7.0 @@ -140,7 +140,7 @@ 3.1.1 1.3.2 2.3.0 - 2.3.2 + 2.6 1.19.4 9.4.26.v20200117 9.4.26.v20200117 @@ -637,7 +637,7 @@ org.apache.maven.doxia doxia-site-renderer - 1.8.1 + 1.9.1 From 880beec467681226a5a139d4fa91010f176152cf Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Thu, 12 Mar 2020 11:10:28 +0100 Subject: [PATCH 10/13] more dependencies managed --- pom.xml | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index 4c54a59d3a8d..dbf819d2539e 100644 --- a/pom.xml +++ b/pom.xml @@ -89,6 +89,7 @@ 3.1 2.6 3.9 + 1.2 3.6 1.6 1.10 @@ -145,7 +146,7 @@ 9.4.26.v20200117 9.4.26.v20200117 4.0.0 - 2.8.1 + 2.10.5 2.2.1 0.1.55 20090211 @@ -371,6 +372,11 @@ commons-lang ${cs.lang.version} + + commons-logging + commons-logging + ${cs.commons-logging.version} + commons-net commons-net @@ -386,6 +392,11 @@ commons-validator ${cs.commons-validator.version} + + javax.annotation + javax.annotation-api + ${cs.javax.annotation.version} + javax.mail mail @@ -396,6 +407,11 @@ javax.servlet-api ${cs.servlet.version} + + joda-time + joda-time + ${cs.joda-time.version} + jstl jstl @@ -473,6 +489,11 @@ kafka-clients ${cs.kafka-clients.version} + + org.apache.maven.doxia + doxia-site-renderer + 1.9.1 + org.apache.servicemix.bundles org.apache.servicemix.bundles.snmp4j @@ -635,9 +656,14 @@ 1.6.3 - org.apache.maven.doxia - doxia-site-renderer - 1.9.1 + xerces + xercesimpl + 2.12.0 + + + xml-apis + xml-apis + 2.0.2 From 2ce46c771fa408102028dfa09506ffe2609ad2f6 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Fri, 13 Mar 2020 10:12:27 +0100 Subject: [PATCH 11/13] google http client and jackson --- pom.xml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index dbf819d2539e..814f76130b65 100644 --- a/pom.xml +++ b/pom.xml @@ -128,13 +128,14 @@ 3.2.6 2.6.11 0.0.27 + 1.34.2 2.4.17 1.7.2 28.2-jre 4.5.11 4.4.13 2.17 - 2.9.10 + 2.10.3 1.9.3 0.17 3.26.0-GA @@ -281,6 +282,12 @@ aws-java-sdk-s3 ${cs.aws.sdk.version} + + com.fasterxml.jackson.core + jackson-core + ${cs.jackson.version} + bundle + com.globo.globodns globodns-client @@ -296,6 +303,11 @@ guava ${cs.guava.version} + + com.google.http-client + google-http-client + ${cs.google-http-client} + com.googlecode.java-ipv6 java-ipv6 From 91144c03ccd145a1513340b5f4a1231da5dc69f3 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Mon, 16 Mar 2020 16:18:45 +0100 Subject: [PATCH 12/13] downgrade discovery back to the official release --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 814f76130b65..5e6c31c9993d 100644 --- a/pom.xml +++ b/pom.xml @@ -95,7 +95,7 @@ 1.10 1.2.2 2.7.0 - 1.0-dev + 0.5 2.6 2.7.0 From f8574775f4fe686b77b3d90e4a7b4202fefc5404 Mon Sep 17 00:00:00 2001 From: Daan Hoogland Date: Mon, 23 Mar 2020 16:47:08 +0100 Subject: [PATCH 13/13] jaxws version --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 5e6c31c9993d..b3cab5a6ced9 100644 --- a/pom.xml +++ b/pom.xml @@ -142,7 +142,7 @@ 3.1.1 1.3.2 2.3.0 - 2.6 + 2.3.2-1 1.19.4 9.4.26.v20200117 9.4.26.v20200117