From 4a642c13ba7e745d5228b75a18c0c05bffbb00e4 Mon Sep 17 00:00:00 2001 From: sparkhi <4743002+sparkhi@users.noreply.github.com> Date: Tue, 14 Apr 2026 13:31:13 +0100 Subject: [PATCH 1/3] Failing test for IO-890 --- .../java/org/apache/commons/io/FilenameUtilsTest.java | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/test/java/org/apache/commons/io/FilenameUtilsTest.java b/src/test/java/org/apache/commons/io/FilenameUtilsTest.java index 9250e810bc6..7990668a02e 100644 --- a/src/test/java/org/apache/commons/io/FilenameUtilsTest.java +++ b/src/test/java/org/apache/commons/io/FilenameUtilsTest.java @@ -1208,4 +1208,14 @@ void testSeparatorsToWindows() { assertEquals("\\a\\b\\c", FilenameUtils.separatorsToWindows("/a/b/c")); assertEquals("D:\\a\\b\\c", FilenameUtils.separatorsToWindows("D:/a/b/c")); } + + @Test + void testFilenameWithSeparatorCharOnNonWindows() throws IOException { + if (!WINDOWS) { + Path testFileWithBackSlash = Files.createTempFile(temporaryFolder, "file\\with\\backslash", "txt"); + String actualFileName = FilenameUtils.getName(testFileWithBackSlash.toString()); + String expectedFileName = testFileWithBackSlash.getFileName().toString(); + assertEquals(expectedFileName, actualFileName); + } + } } From f9a21ef4982009a696f11f627910a4059387be45 Mon Sep 17 00:00:00 2001 From: sparkhi <4743002+sparkhi@users.noreply.github.com> Date: Tue, 14 Apr 2026 13:49:09 +0100 Subject: [PATCH 2/3] Failing test for IO-890 --- src/test/java/org/apache/commons/io/FilenameUtilsTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/org/apache/commons/io/FilenameUtilsTest.java b/src/test/java/org/apache/commons/io/FilenameUtilsTest.java index 7990668a02e..d18488d926c 100644 --- a/src/test/java/org/apache/commons/io/FilenameUtilsTest.java +++ b/src/test/java/org/apache/commons/io/FilenameUtilsTest.java @@ -1212,9 +1212,9 @@ void testSeparatorsToWindows() { @Test void testFilenameWithSeparatorCharOnNonWindows() throws IOException { if (!WINDOWS) { - Path testFileWithBackSlash = Files.createTempFile(temporaryFolder, "file\\with\\backslash", "txt"); + Path testFileWithBackSlash = Files.createTempFile(temporaryFolder, "file\\with\\backslash", ".txt"); String actualFileName = FilenameUtils.getName(testFileWithBackSlash.toString()); - String expectedFileName = testFileWithBackSlash.getFileName().toString(); + String expectedFileName = new File(testFileWithBackSlash.toString()).getName(); assertEquals(expectedFileName, actualFileName); } } From 937bbd5f47d6e36f5fae5a00af518e33e2fc39d2 Mon Sep 17 00:00:00 2001 From: sparkhi <4743002+sparkhi@users.noreply.github.com> Date: Tue, 14 Apr 2026 15:49:34 +0100 Subject: [PATCH 3/3] checkstyle suggestions taken --- .../java/org/apache/commons/io/FilenameUtilsTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/apache/commons/io/FilenameUtilsTest.java b/src/test/java/org/apache/commons/io/FilenameUtilsTest.java index d18488d926c..8db33ba3108 100644 --- a/src/test/java/org/apache/commons/io/FilenameUtilsTest.java +++ b/src/test/java/org/apache/commons/io/FilenameUtilsTest.java @@ -1208,13 +1208,13 @@ void testSeparatorsToWindows() { assertEquals("\\a\\b\\c", FilenameUtils.separatorsToWindows("/a/b/c")); assertEquals("D:\\a\\b\\c", FilenameUtils.separatorsToWindows("D:/a/b/c")); } - + @Test void testFilenameWithSeparatorCharOnNonWindows() throws IOException { if (!WINDOWS) { - Path testFileWithBackSlash = Files.createTempFile(temporaryFolder, "file\\with\\backslash", ".txt"); - String actualFileName = FilenameUtils.getName(testFileWithBackSlash.toString()); - String expectedFileName = new File(testFileWithBackSlash.toString()).getName(); + final Path testFileWithBackSlash = Files.createTempFile(temporaryFolder, "file\\with\\backslash", ".txt"); + final String actualFileName = FilenameUtils.getName(testFileWithBackSlash.toString()); + final String expectedFileName = new File(testFileWithBackSlash.toString()).getName(); assertEquals(expectedFileName, actualFileName); } }