From dfeb41737dd7a9b60e5ab1aec326ef1a45bb2aac Mon Sep 17 00:00:00 2001 From: Andy Grove Date: Wed, 11 Jun 2025 11:14:02 -0600 Subject: [PATCH 1/2] disable some rounding tests when miri is enabled --- native/spark-expr/src/math_funcs/round.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/native/spark-expr/src/math_funcs/round.rs b/native/spark-expr/src/math_funcs/round.rs index 1979098595..dcf558a54d 100644 --- a/native/spark-expr/src/math_funcs/round.rs +++ b/native/spark-expr/src/math_funcs/round.rs @@ -150,6 +150,7 @@ mod test { use datafusion::physical_plan::ColumnarValue; #[test] + #[cfg_attr(miri, ignore)] // roudning does not work when miri enabled fn test_round_f32_array() -> Result<()> { let args = vec![ ColumnarValue::Array(Arc::new(Float32Array::from(vec![ @@ -167,6 +168,7 @@ mod test { } #[test] + #[cfg_attr(miri, ignore)] // roudning does not work when miri enabled fn test_round_f64_array() -> Result<()> { let args = vec![ ColumnarValue::Array(Arc::new(Float64Array::from(vec![ @@ -184,6 +186,7 @@ mod test { } #[test] + #[cfg_attr(miri, ignore)] // roudning does not work when miri enabled fn test_round_f32_scalar() -> Result<()> { let args = vec![ ColumnarValue::Scalar(ScalarValue::Float32(Some(125.2345))), @@ -199,6 +202,7 @@ mod test { } #[test] + #[cfg_attr(miri, ignore)] // roudning does not work when miri enabled fn test_round_f64_scalar() -> Result<()> { let args = vec![ ColumnarValue::Scalar(ScalarValue::Float64(Some(125.2345))), From c9c4e59055c48193aac82f6a1733784c5c96b068 Mon Sep 17 00:00:00 2001 From: Andy Grove Date: Wed, 11 Jun 2025 11:15:44 -0600 Subject: [PATCH 2/2] typo --- native/spark-expr/src/math_funcs/round.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/native/spark-expr/src/math_funcs/round.rs b/native/spark-expr/src/math_funcs/round.rs index dcf558a54d..9191a88cac 100644 --- a/native/spark-expr/src/math_funcs/round.rs +++ b/native/spark-expr/src/math_funcs/round.rs @@ -150,7 +150,7 @@ mod test { use datafusion::physical_plan::ColumnarValue; #[test] - #[cfg_attr(miri, ignore)] // roudning does not work when miri enabled + #[cfg_attr(miri, ignore)] // rounding does not work when miri enabled fn test_round_f32_array() -> Result<()> { let args = vec![ ColumnarValue::Array(Arc::new(Float32Array::from(vec![ @@ -168,7 +168,7 @@ mod test { } #[test] - #[cfg_attr(miri, ignore)] // roudning does not work when miri enabled + #[cfg_attr(miri, ignore)] // rounding does not work when miri enabled fn test_round_f64_array() -> Result<()> { let args = vec![ ColumnarValue::Array(Arc::new(Float64Array::from(vec![ @@ -186,7 +186,7 @@ mod test { } #[test] - #[cfg_attr(miri, ignore)] // roudning does not work when miri enabled + #[cfg_attr(miri, ignore)] // rounding does not work when miri enabled fn test_round_f32_scalar() -> Result<()> { let args = vec![ ColumnarValue::Scalar(ScalarValue::Float32(Some(125.2345))), @@ -202,7 +202,7 @@ mod test { } #[test] - #[cfg_attr(miri, ignore)] // roudning does not work when miri enabled + #[cfg_attr(miri, ignore)] // rounding does not work when miri enabled fn test_round_f64_scalar() -> Result<()> { let args = vec![ ColumnarValue::Scalar(ScalarValue::Float64(Some(125.2345))),