From ed9bba8b51bec463fe257f62bf641b462bd48ee2 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Tue, 1 Aug 2023 11:16:47 -0400 Subject: [PATCH 1/2] Minor: show output ordering in MemoryExec --- datafusion/core/src/physical_plan/memory.rs | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/datafusion/core/src/physical_plan/memory.rs b/datafusion/core/src/physical_plan/memory.rs index fbf7f46dd50d4..92b6a7c11d856 100644 --- a/datafusion/core/src/physical_plan/memory.rs +++ b/datafusion/core/src/physical_plan/memory.rs @@ -68,13 +68,23 @@ impl DisplayAs for MemoryExec { ) -> std::fmt::Result { match t { DisplayFormatType::Default | DisplayFormatType::Verbose => { - let partitions: Vec<_> = + let partition_sizes: Vec<_> = self.partitions.iter().map(|b| b.len()).collect(); + + let output_ordering = self + .sort_information + .as_ref() + .map(|output_ordering| { + let order_strings: Vec<_> = + output_ordering.iter().map(|e| e.to_string()).collect(); + format!(", output_ordering: {}", order_strings.join(",")) + }) + .unwrap_or_else(|| "".to_string()); + write!( f, - "MemoryExec: partitions={}, partition_sizes={:?}", - partitions.len(), - partitions + "MemoryExec: partitions={}, partition_sizes={partition_sizes:?}{output_ordering}", + partition_sizes.len(), ) } } From 369cb463ba4d001430e4054e090223a713b4f158 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Tue, 1 Aug 2023 13:39:57 -0400 Subject: [PATCH 2/2] Update datafusion/core/src/physical_plan/memory.rs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Daniël Heres --- datafusion/core/src/physical_plan/memory.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/core/src/physical_plan/memory.rs b/datafusion/core/src/physical_plan/memory.rs index 92b6a7c11d856..5e7917b978e0f 100644 --- a/datafusion/core/src/physical_plan/memory.rs +++ b/datafusion/core/src/physical_plan/memory.rs @@ -77,7 +77,7 @@ impl DisplayAs for MemoryExec { .map(|output_ordering| { let order_strings: Vec<_> = output_ordering.iter().map(|e| e.to_string()).collect(); - format!(", output_ordering: {}", order_strings.join(",")) + format!(", output_ordering={}", order_strings.join(",")) }) .unwrap_or_else(|| "".to_string());