From 5fe07fcd3d4409cdadfc105f996b026158692c01 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 15 Sep 2023 16:08:38 -0400 Subject: [PATCH 1/4] Update release instructions for datafusion-physical-plan crate --- dev/release/README.md | 4 +- dev/release/crate-deps.dot | 5 ++ dev/release/crate-deps.svg | 176 ++++++++++++++++++++++--------------- 3 files changed, 111 insertions(+), 74 deletions(-) diff --git a/dev/release/README.md b/dev/release/README.md index 1fd062e3d5c00..5fadfdedae093 100644 --- a/dev/release/README.md +++ b/dev/release/README.md @@ -285,6 +285,7 @@ of the following crates: - [datafusion-physical-expr](https://crates.io/crates/datafusion-physical-expr) - [datafusion-proto](https://crates.io/crates/datafusion-proto) - [datafusion-execution](https://crates.io/crates/datafusion-execution) +- [datafusion-physical-plan](https://crates.io/crates/datafusion-physical-plan) - [datafusion-sql](https://crates.io/crates/datafusion-sql) - [datafusion-optimizer](https://crates.io/crates/datafusion-optimizer) - [datafusion-substrait](https://crates.io/crates/datafusion-substrait) @@ -314,12 +315,13 @@ dot -Tsvg dev/release/crate-deps.dot > dev/release/crate-deps.svg (cd datafusion/physical-expr && cargo publish) (cd datafusion/optimizer && cargo publish) (cd datafusion/execution && cargo publish) +(cd datafusion/physical-plan && cargo publish) (cd datafusion/core && cargo publish) (cd datafusion/proto && cargo publish) (cd datafusion/substrait && cargo publish) ``` -The CLI needs a `--no-verify` argument because `build.rs` generates source into the `src` directory. +The CLI needs a `--no-verify` argument because `build.rs` generates source into the `src` directory. ```shell (cd datafusion-cli && cargo publish --no-verify) diff --git a/dev/release/crate-deps.dot b/dev/release/crate-deps.dot index 6d1aa6e5807db..4968f9b5869ed 100644 --- a/dev/release/crate-deps.dot +++ b/dev/release/crate-deps.dot @@ -33,6 +33,11 @@ digraph G { datafusion_execution -> datafusion_common datafusion_execution -> datafusion_expr + datafusion_physical_plan -> datafusion_common + datafusion_physical_plan -> datafusion_execution + datafusion_physical_plan -> datafusion_expr + datafusion_physical_plan -> datafusion_physical_expr + datafusion -> datafusion_common datafusion -> datafusion_execution datafusion -> datafusion_expr diff --git a/dev/release/crate-deps.svg b/dev/release/crate-deps.svg index 63f61bde18714..0aae7ff7e2de3 100644 --- a/dev/release/crate-deps.svg +++ b/dev/release/crate-deps.svg @@ -1,181 +1,211 @@ - - + G - + datafusion_common - -datafusion_common + +datafusion_common datafusion_expr - -datafusion_expr + +datafusion_expr datafusion_expr->datafusion_common - - + + datafusion_sql - -datafusion_sql + +datafusion_sql datafusion_sql->datafusion_common - - + + datafusion_sql->datafusion_expr - - + + datafusion_optimizer - -datafusion_optimizer + +datafusion_optimizer datafusion_optimizer->datafusion_common - - + + datafusion_optimizer->datafusion_expr - - + + datafusion_physical_expr - -datafusion_physical_expr + +datafusion_physical_expr datafusion_physical_expr->datafusion_common - - + + datafusion_physical_expr->datafusion_expr - - + + datafusion_execution - -datafusion_execution + +datafusion_execution datafusion_execution->datafusion_common - - + + datafusion_execution->datafusion_expr - - + + - + +datafusion_physical_plan + +datafusion_physical_plan + + + +datafusion_physical_plan->datafusion_common + + + + + +datafusion_physical_plan->datafusion_expr + + + + + +datafusion_physical_plan->datafusion_physical_expr + + + + + +datafusion_physical_plan->datafusion_execution + + + + + datafusion - -datafusion + +datafusion - + datafusion->datafusion_common - - + + - + datafusion->datafusion_expr - - + + - + datafusion->datafusion_sql - - + + - + datafusion->datafusion_optimizer - - + + - + datafusion->datafusion_physical_expr - - + + - + datafusion->datafusion_execution - - + + - + datafusion_proto - -datafusion_proto + +datafusion_proto - + datafusion_proto->datafusion - - + + - + datafusion_substrait - -datafusion_substrait + +datafusion_substrait - + datafusion_substrait->datafusion - - + + - + datafusion_cli - -datafusion_cli + +datafusion_cli - + datafusion_cli->datafusion - - + + From c37ea6b70b1d334ddad499f90feca7af39b2b591 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 15 Sep 2023 16:11:25 -0400 Subject: [PATCH 2/4] fix --- dev/release/crate-deps.dot | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dev/release/crate-deps.dot b/dev/release/crate-deps.dot index 4968f9b5869ed..4f39bc8a956b3 100644 --- a/dev/release/crate-deps.dot +++ b/dev/release/crate-deps.dot @@ -33,10 +33,10 @@ digraph G { datafusion_execution -> datafusion_common datafusion_execution -> datafusion_expr - datafusion_physical_plan -> datafusion_common - datafusion_physical_plan -> datafusion_execution - datafusion_physical_plan -> datafusion_expr - datafusion_physical_plan -> datafusion_physical_expr + datafusion_physical_plan -> datafusion_common + datafusion_physical_plan -> datafusion_execution + datafusion_physical_plan -> datafusion_expr + datafusion_physical_plan -> datafusion_physical_expr datafusion -> datafusion_common datafusion -> datafusion_execution From a8ab7c238a4ecd6c33066509651bb39a3f250ae6 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 15 Sep 2023 16:12:12 -0400 Subject: [PATCH 3/4] fix --- dev/release/crate-deps.dot | 3 +- dev/release/crate-deps.svg | 154 +++++++++++++++++++------------------ 2 files changed, 82 insertions(+), 75 deletions(-) diff --git a/dev/release/crate-deps.dot b/dev/release/crate-deps.dot index 4f39bc8a956b3..618eb56afb75b 100644 --- a/dev/release/crate-deps.dot +++ b/dev/release/crate-deps.dot @@ -39,10 +39,11 @@ digraph G { datafusion_physical_plan -> datafusion_physical_expr datafusion -> datafusion_common - datafusion -> datafusion_execution + datafusion -> datafusion_execution datafusion -> datafusion_expr datafusion -> datafusion_optimizer datafusion -> datafusion_physical_expr + datafusion -> datafusion_physical_plan datafusion -> datafusion_sql datafusion_proto -> datafusion diff --git a/dev/release/crate-deps.svg b/dev/release/crate-deps.svg index 0aae7ff7e2de3..a7c7b7fe4acd0 100644 --- a/dev/release/crate-deps.svg +++ b/dev/release/crate-deps.svg @@ -4,208 +4,214 @@ - - + + G - + datafusion_common - -datafusion_common + +datafusion_common datafusion_expr - -datafusion_expr + +datafusion_expr datafusion_expr->datafusion_common - - + + datafusion_sql - -datafusion_sql + +datafusion_sql datafusion_sql->datafusion_common - - + + datafusion_sql->datafusion_expr - - + + datafusion_optimizer - -datafusion_optimizer + +datafusion_optimizer datafusion_optimizer->datafusion_common - - + + datafusion_optimizer->datafusion_expr - - + + datafusion_physical_expr - -datafusion_physical_expr + +datafusion_physical_expr datafusion_physical_expr->datafusion_common - - + + datafusion_physical_expr->datafusion_expr - - + + datafusion_execution - -datafusion_execution + +datafusion_execution datafusion_execution->datafusion_common - - + + datafusion_execution->datafusion_expr - - + + datafusion_physical_plan - -datafusion_physical_plan + +datafusion_physical_plan datafusion_physical_plan->datafusion_common - - + + datafusion_physical_plan->datafusion_expr - - + + datafusion_physical_plan->datafusion_physical_expr - - + + datafusion_physical_plan->datafusion_execution - - + + datafusion - -datafusion + +datafusion datafusion->datafusion_common - - + + datafusion->datafusion_expr - - + + - + datafusion->datafusion_sql - - + + datafusion->datafusion_optimizer - - + + datafusion->datafusion_physical_expr - - + + datafusion->datafusion_execution - - + + + + + +datafusion->datafusion_physical_plan + + datafusion_proto - -datafusion_proto + +datafusion_proto - + datafusion_proto->datafusion - - + + datafusion_substrait - -datafusion_substrait + +datafusion_substrait - + datafusion_substrait->datafusion - - + + datafusion_cli - -datafusion_cli + +datafusion_cli - + datafusion_cli->datafusion - - + + From 591341aa0287abbe03ebf1b58555363e200cdccc Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 15 Sep 2023 17:16:38 -0400 Subject: [PATCH 4/4] prettier --- dev/release/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/release/README.md b/dev/release/README.md index 5fadfdedae093..b44259ad560b2 100644 --- a/dev/release/README.md +++ b/dev/release/README.md @@ -321,7 +321,7 @@ dot -Tsvg dev/release/crate-deps.dot > dev/release/crate-deps.svg (cd datafusion/substrait && cargo publish) ``` -The CLI needs a `--no-verify` argument because `build.rs` generates source into the `src` directory. +The CLI needs a `--no-verify` argument because `build.rs` generates source into the `src` directory. ```shell (cd datafusion-cli && cargo publish --no-verify)