From 48fa18f69fbde661e0071f706a4a9013758e597d Mon Sep 17 00:00:00 2001
From: morningman <morningman@163.com>
Date: Fri, 9 Sep 2022 00:20:17 +0800
Subject: [PATCH 1/4] [improvment](planner) unset common fields to reduce plan
 thrift size

---
 .../java/org/apache/doris/qe/Coordinator.java | 22 +++++--------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
index 21af37ccd283b2..b91055d884caf2 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
@@ -154,9 +154,7 @@ public class Coordinator {
 
     // copied from TQueryExecRequest; constant across all fragments
     private final TDescriptorTable descTable;
-
-    private final Set<Long> alreadySentBackendIds = Sets.newHashSet();
-
+    
     // Why do we use query global?
     // When `NOW()` function is in sql, we need only one now(),
     // but, we execute `NOW()` distributed.
@@ -396,7 +394,6 @@ public void clearExportStatus() {
             }
             this.exportFiles.clear();
             this.needCheckBackendExecStates.clear();
-            this.alreadySentBackendIds.clear();
         } finally {
             lock.unlock();
         }
@@ -748,9 +745,6 @@ private void waitRpc(List<Pair<BackendExecStates, Future<PExecPlanFragmentResult
             } finally {
                 pair.first.scopedSpan.endSpan();
             }
-
-            // succeed to send the plan fragment, update the "alreadySentBackendIds"
-            alreadySentBackendIds.add(pair.first.beId);
         }
     }
 
@@ -2081,15 +2075,11 @@ public BackendExecState(PlanFragmentId fragmentId, int instanceId, int profileFr
          * This information can be obtained from the cache of BE.
          */
         public void unsetFields() {
-            if (alreadySentBackendIds.contains(backend.getId())) {
-                this.rpcParams.unsetDescTbl();
-                this.rpcParams.unsetCoord();
-                this.rpcParams.unsetQueryGlobals();
-                this.rpcParams.unsetResourceInfo();
-                this.rpcParams.setIsSimplifiedParam(true);
-            } else {
-                this.rpcParams.setIsSimplifiedParam(false);
-            }
+            this.rpcParams.unsetDescTbl();
+            this.rpcParams.unsetCoord();
+            this.rpcParams.unsetQueryGlobals();
+            this.rpcParams.unsetResourceInfo();
+            this.rpcParams.setIsSimplifiedParam(true);
         }
 
         // update profile.

From f2f6bd9a2eecf713c37c5fb266b5cc73435d7572 Mon Sep 17 00:00:00 2001
From: morningman <morningman@163.com>
Date: Fri, 9 Sep 2022 00:27:04 +0800
Subject: [PATCH 2/4] [improvment](planner) unset common fields to reduce plan
 thrift size

---
 fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
index b91055d884caf2..3524256bd44cb8 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
@@ -154,7 +154,7 @@ public class Coordinator {
 
     // copied from TQueryExecRequest; constant across all fragments
     private final TDescriptorTable descTable;
-    
+
     // Why do we use query global?
     // When `NOW()` function is in sql, we need only one now(),
     // but, we execute `NOW()` distributed.

From 7b640d397df4162fcd14270b52b64153b439f7b0 Mon Sep 17 00:00:00 2001
From: morningman <morningman@163.com>
Date: Fri, 9 Sep 2022 00:42:11 +0800
Subject: [PATCH 3/4] remove verify

---
 .../doris/analysis/ExprSubstitutionMap.java    | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java
index fff47d02c2f619..df652bdcfc7ef2 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java
@@ -294,17 +294,19 @@ public String debugString() {
      * and that all rhs exprs are analyzed.
      */
     private void verify() {
-        for (int i = 0; i < lhs.size(); ++i) {
-            for (int j = i + 1; j < lhs.size(); ++j) {
-                if (lhs.get(i).equals(lhs.get(j))) {
-                    if (LOG.isTraceEnabled()) {
-                        LOG.trace("verify: smap=" + this.debugString());
+        if (LOG.isDebugEnabled()) {
+            for (int i = 0; i < lhs.size(); ++i) {
+                for (int j = i + 1; j < lhs.size(); ++j) {
+                    if (lhs.get(i).equals(lhs.get(j))) {
+                        if (LOG.isTraceEnabled()) {
+                            LOG.trace("verify: smap=" + this.debugString());
+                        }
+                        // TODO(zc): partition by k1, order by k1, there is failed.
+                        // Preconditions.checkState(false);
                     }
-                    // TODO(zc): partition by k1, order by k1, there is failed.
-                    // Preconditions.checkState(false);
                 }
+                Preconditions.checkState(!checkAnalyzed || rhs.get(i).isAnalyzed());
             }
-            Preconditions.checkState(!checkAnalyzed || rhs.get(i).isAnalyzed());
         }
     }
 

From 6f3b4e0233e76dc097fac502ebe9dc04d1953386 Mon Sep 17 00:00:00 2001
From: morningman <morningman@163.com>
Date: Fri, 9 Sep 2022 00:45:11 +0800
Subject: [PATCH 4/4] remove verify

---
 .../java/org/apache/doris/analysis/ExprSubstitutionMap.java     | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java
index df652bdcfc7ef2..b1806f3dbfd19c 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java
@@ -294,6 +294,8 @@ public String debugString() {
      * and that all rhs exprs are analyzed.
      */
     private void verify() {
+        // This method is very very time consuming, especially when planning large complex query.
+        // So disable it by default.
         if (LOG.isDebugEnabled()) {
             for (int i = 0; i < lhs.size(); ++i) {
                 for (int j = i + 1; j < lhs.size(); ++j) {