From 9fd966e19fcf796910bc048c59399400100295a7 Mon Sep 17 00:00:00 2001
From: huangkangping <huangkangping@baidu.com>
Date: Fri, 21 Jun 2019 14:34:37 +0800
Subject: [PATCH] remove file created in segment group

---
 be/src/olap/rowset/segment_group.cpp | 8 +++-----
 be/src/olap/rowset/segment_group.h   | 1 -
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/be/src/olap/rowset/segment_group.cpp b/be/src/olap/rowset/segment_group.cpp
index 38e3724a388344..d9fa5acb42d90b 100644
--- a/be/src/olap/rowset/segment_group.cpp
+++ b/be/src/olap/rowset/segment_group.cpp
@@ -84,7 +84,6 @@ SegmentGroup::SegmentGroup(int64_t tablet_id, int64_t rowset_id, const TabletSch
     _short_key_length = 0;
     _new_short_key_length = 0;
     _short_key_buf = nullptr;
-    _file_created = false;
     _new_segment_created = false;
     _empty = false;
 
@@ -121,7 +120,6 @@ SegmentGroup::SegmentGroup(int64_t tablet_id, int64_t rowset_id, const TabletSch
     _short_key_length = 0;
     _new_short_key_length = 0;
     _short_key_buf = NULL;
-    _file_created = false;
     _new_segment_created = false;
     _empty = false;
 
@@ -208,7 +206,9 @@ bool SegmentGroup::is_in_use() {
 // you can not use SegmentGroup after delete_all_files(), or else unknown behavior occurs.
 bool SegmentGroup::delete_all_files() {
     bool success = true;
-    if (!_file_created) { return success; }
+    if (_empty) {
+        return success;
+    }
     for (uint32_t seg_id = 0; seg_id < _num_segments; ++seg_id) {
         // get full path for one segment
         string index_path = construct_index_file_path(seg_id);
@@ -341,7 +341,6 @@ OLAPStatus SegmentGroup::load() {
 
     _delete_flag = _index.delete_flag();
     _index_loaded = true;
-    _file_created = true;
 
     return OLAP_SUCCESS;
 }
@@ -578,7 +577,6 @@ OLAPStatus SegmentGroup::add_short_key(const RowCursor& short_key, const uint32_
                 << "' err='" << strerror_r(errno, errmsg, 64) << "']";
             return res;
         }
-        _file_created = true;
         _new_segment_created = true;
 
         // 准备FileHeader
diff --git a/be/src/olap/rowset/segment_group.h b/be/src/olap/rowset/segment_group.h
index 5b68e9cc4475b5..296eae2aece8f0 100644
--- a/be/src/olap/rowset/segment_group.h
+++ b/be/src/olap/rowset/segment_group.h
@@ -314,7 +314,6 @@ class SegmentGroup {
     // 以下是写入流程时需要的一些中间状态
     // 当前写入文件的FileHandler
     FileHandler _current_file_handler;
-    bool _file_created;
     bool _new_segment_created;
     // 当前写入的FileHeader
     FileHeader<OLAPIndexHeaderMessage, OLAPIndexFixedHeader> _file_header;