From 9c2e85fe534aa747db8e1c12cb9a5c4b22df2867 Mon Sep 17 00:00:00 2001 From: zhaochun Date: Mon, 15 Jul 2019 21:56:19 +0800 Subject: [PATCH] Remove unused code --- be/src/olap/rowset/alpha_rowset_writer.cpp | 17 ----------------- be/src/olap/rowset/alpha_rowset_writer.h | 2 -- be/src/olap/rowset/rowset_writer.h | 2 -- 3 files changed, 21 deletions(-) diff --git a/be/src/olap/rowset/alpha_rowset_writer.cpp b/be/src/olap/rowset/alpha_rowset_writer.cpp index fc42f362a2a7ef..b0d42990a578e4 100644 --- a/be/src/olap/rowset/alpha_rowset_writer.cpp +++ b/be/src/olap/rowset/alpha_rowset_writer.cpp @@ -100,23 +100,6 @@ OLAPStatus AlphaRowsetWriter::add_row(const char* row, Schema* schema) { return OLAP_SUCCESS; } -OLAPStatus AlphaRowsetWriter::add_row_block(RowBlock* row_block) { - if (_writer_state != WRITER_INITED) { - RETURN_NOT_OK(_init()); - } - size_t pos = 0; - row_block->set_pos(pos); - RowCursor row_cursor; - row_cursor.init(*(_rowset_writer_context.tablet_schema)); - while (pos < row_block->limit()) { - row_block->get_row(pos, &row_cursor); - add_row(&row_cursor); - row_block->pos_inc(); - pos = row_block->pos(); - } - return OLAP_SUCCESS; -} - OLAPStatus AlphaRowsetWriter::add_rowset(RowsetSharedPtr rowset) { _need_column_data_writer = false; // this api is for LinkedSchemaChange diff --git a/be/src/olap/rowset/alpha_rowset_writer.h b/be/src/olap/rowset/alpha_rowset_writer.h index c66a646647cbaf..6490aba26b7179 100644 --- a/be/src/olap/rowset/alpha_rowset_writer.h +++ b/be/src/olap/rowset/alpha_rowset_writer.h @@ -44,8 +44,6 @@ class AlphaRowsetWriter : public RowsetWriter { OLAPStatus add_row(const char* row, Schema* schema) override; - OLAPStatus add_row_block(RowBlock* row_block) override; - // add rowset by create hard link OLAPStatus add_rowset(RowsetSharedPtr rowset) override; OLAPStatus add_rowset_for_linked_schema_change( diff --git a/be/src/olap/rowset/rowset_writer.h b/be/src/olap/rowset/rowset_writer.h index 4a9351c61fad44..8bf7b4681f89f1 100644 --- a/be/src/olap/rowset/rowset_writer.h +++ b/be/src/olap/rowset/rowset_writer.h @@ -41,8 +41,6 @@ class RowsetWriter { virtual OLAPStatus add_row(const char* row, Schema* schema) = 0; - virtual OLAPStatus add_row_block(RowBlock* row_block) = 0; - virtual OLAPStatus add_rowset(RowsetSharedPtr rowset) = 0; virtual OLAPStatus add_rowset_for_linked_schema_change( RowsetSharedPtr rowset, const SchemaMapping& schema_mapping) = 0;