From 78880eb49762f7fc6d73aab07c8843ae025ed031 Mon Sep 17 00:00:00 2001 From: gaodayue Date: Mon, 29 Jul 2019 19:12:54 +0800 Subject: [PATCH] EnginePublishVersionTask: remove unreachable code --- .../olap/task/engine_publish_version_task.cpp | 20 +++++-------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/be/src/olap/task/engine_publish_version_task.cpp b/be/src/olap/task/engine_publish_version_task.cpp index b98aca3f4c1f1f..0e7db669d9c9ff 100644 --- a/be/src/olap/task/engine_publish_version_task.cpp +++ b/be/src/olap/task/engine_publish_version_task.cpp @@ -104,21 +104,11 @@ OLAPStatus EnginePublishVersionTask::finish() { res = publish_status; continue; } - if (publish_status == OLAP_SUCCESS || publish_status == OLAP_ERR_PUSH_VERSION_ALREADY_EXIST) { - LOG(INFO) << "publish version successfully on tablet. tablet=" << tablet->full_name() - << ", transaction_id=" << transaction_id << ", version=" << version.first - << ", res=" << publish_status; - // delete rowset from meta env, because add inc rowset alreay saved the rowset meta to tablet meta - RowsetMetaManager::remove(tablet->data_dir()->get_meta(), tablet->tablet_uid(), rowset->rowset_id()); - // delete txn info - } else { - LOG(WARNING) << "fail to publish version on tablet. tablet=" << tablet->full_name().c_str() - << "transaction_id=" << transaction_id - << "version=" << version.first - << " res=" << publish_status; - _error_tablet_ids->push_back(tablet->tablet_id()); - res = publish_status; - } + LOG(INFO) << "publish version successfully on tablet. tablet=" << tablet->full_name() + << ", transaction_id=" << transaction_id << ", version=" << version.first + << ", res=" << publish_status; + // delete rowset from meta env, because add inc rowset alreay saved the rowset meta to tablet meta + RowsetMetaManager::remove(tablet->data_dir()->get_meta(), tablet->tablet_uid(), rowset->rowset_id()); } }