From adee1927faa7142152ece69c4987bac08079ce76 Mon Sep 17 00:00:00 2001 From: zhiqiang Date: Tue, 31 Oct 2023 01:31:24 -0500 Subject: [PATCH] [Fix](from_unixtime) Keep consistent with MySQL & bug fix (#25966) Bug fix: implicit convert from int32 -> int64 makes negative time stamp valid, so change signature to int64 Consistent: keep consistent with mysql. --- .../functions/executable/DateTimeExtractAndTransform.java | 2 -- regression-test/data/datatype_p0/date/test_from_unixtime.out | 1 - 2 files changed, 3 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java index 8b51ceeb177626..e49ccc254aedd6 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java @@ -27,8 +27,6 @@ import org.apache.doris.nereids.trees.expressions.literal.DateV2Literal; import org.apache.doris.nereids.trees.expressions.literal.IntegerLiteral; import org.apache.doris.nereids.trees.expressions.literal.NullLiteral; -import org.apache.doris.nereids.trees.expressions.literal.SmallIntLiteral; -import org.apache.doris.nereids.trees.expressions.literal.TinyIntLiteral; import org.apache.doris.nereids.trees.expressions.literal.VarcharLiteral; import org.apache.doris.nereids.types.VarcharType; import org.apache.doris.nereids.util.DateUtils; diff --git a/regression-test/data/datatype_p0/date/test_from_unixtime.out b/regression-test/data/datatype_p0/date/test_from_unixtime.out index bc6f5317c96547..19143cae72e06c 100644 --- a/regression-test/data/datatype_p0/date/test_from_unixtime.out +++ b/regression-test/data/datatype_p0/date/test_from_unixtime.out @@ -28,4 +28,3 @@ -- !sql10 -- \N -