diff --git a/be/src/olap/rowset/rowset_meta_manager.cpp b/be/src/olap/rowset/rowset_meta_manager.cpp index 01384a560575d5..be49e66ee1114d 100644 --- a/be/src/olap/rowset/rowset_meta_manager.cpp +++ b/be/src/olap/rowset/rowset_meta_manager.cpp @@ -91,8 +91,9 @@ Status RowsetMetaManager::save(OlapMeta* meta, TabletUid tablet_uid, const Rowse if (rowset_meta_pb.partition_id() <= 0) { LOG(WARNING) << "invalid partition id " << rowset_meta_pb.partition_id() << " tablet " << rowset_meta_pb.tablet_id(); - return Status::InternalError("invalid partition id {}, tablet {}", - rowset_meta_pb.partition_id(), rowset_meta_pb.tablet_id()); + // TODO(dx): after fix partition id eq 0 bug, fix it + // return Status::InternalError("invaid partition id {} tablet {}", + // rowset_meta_pb.partition_id(), rowset_meta_pb.tablet_id()); } if (enable_binlog) { return _save_with_binlog(meta, tablet_uid, rowset_id, rowset_meta_pb); diff --git a/be/src/olap/tablet_manager.cpp b/be/src/olap/tablet_manager.cpp index ee060d0fed76ea..f1961d8ee9d13b 100644 --- a/be/src/olap/tablet_manager.cpp +++ b/be/src/olap/tablet_manager.cpp @@ -501,6 +501,10 @@ TabletSharedPtr TabletManager::_create_tablet_meta_and_dir_unlocked( } } + if (tablet_meta->partition_id() <= 0) { + LOG(WARNING) << "invalid partition id " << tablet_meta->partition_id() << ", tablet " + << tablet_meta->tablet_id(); + } TabletSharedPtr new_tablet = std::make_shared(std::move(tablet_meta), data_dir); COUNTER_UPDATE(ADD_CHILD_TIMER(profile, "CreateTabletFromMeta", parent_timer_name), static_cast(watch.reset())); @@ -826,6 +830,10 @@ Status TabletManager::load_tablet_from_meta(DataDir* data_dir, TTabletId tablet_ tablet_meta->set_tablet_state(TABLET_RUNNING); } + if (tablet_meta->partition_id() <= 0) { + LOG(WARNING) << "invalid partition id " << tablet_meta->partition_id() << ", tablet " + << tablet_meta->tablet_id(); + } TabletSharedPtr tablet = std::make_shared(std::move(tablet_meta), data_dir); // NOTE: method load_tablet_from_meta could be called by two cases as below diff --git a/be/src/olap/tablet_meta_manager.cpp b/be/src/olap/tablet_meta_manager.cpp index 17d5d2e9f74b09..288da455e6a888 100644 --- a/be/src/olap/tablet_meta_manager.cpp +++ b/be/src/olap/tablet_meta_manager.cpp @@ -96,8 +96,9 @@ Status TabletMetaManager::save(DataDir* store, TTabletId tablet_id, TSchemaHash if (tablet_meta->partition_id() <= 0) { LOG(WARNING) << "invalid partition id " << tablet_meta->partition_id() << " tablet " << tablet_meta->tablet_id(); - return Status::InternalError("invaid partition id {} tablet {}", - tablet_meta->partition_id(), tablet_meta->tablet_id()); + // TODO(dx): after fix partition id eq 0 bug, fix it + // return Status::InternalError("invaid partition id {} tablet {}", + // tablet_meta->partition_id(), tablet_meta->tablet_id()); } OlapMeta* meta = store->get_meta(); VLOG_NOTICE << "save tablet meta"