From 03a7b511deda33fc1383660f1c8c40b13b4d7a34 Mon Sep 17 00:00:00 2001 From: StarryVerse <113903752+StarryVerse@users.noreply.github.com> Date: Thu, 25 Apr 2024 20:04:55 +0800 Subject: [PATCH 1/2] Update doris_main.cpp Log(FATAL) introduces a core dump, which is confusing for users. We should print error msg and exit without a core dump. --- be/src/service/doris_main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/be/src/service/doris_main.cpp b/be/src/service/doris_main.cpp index 731e09c6be9fc2..8f0f02309ee1e8 100644 --- a/be/src/service/doris_main.cpp +++ b/be/src/service/doris_main.cpp @@ -169,7 +169,7 @@ auto instruction_fail_to_string(InstructionFail fail) { case InstructionFail::ARM_NEON: ret("ARM_NEON"); } - LOG(FATAL) << "__builtin_unreachable"; + LOG(ERROR) << "__builtin_unreachable"; __builtin_unreachable(); } From 3f33f54504ac90ffad231d5c494bbbdc427bcfdf Mon Sep 17 00:00:00 2001 From: StarryVerse <113903752+StarryVerse@users.noreply.github.com> Date: Thu, 25 Apr 2024 21:58:55 +0800 Subject: [PATCH 2/2] Update doris_main.cpp --- be/src/service/doris_main.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/be/src/service/doris_main.cpp b/be/src/service/doris_main.cpp index 8f0f02309ee1e8..009813de19ee67 100644 --- a/be/src/service/doris_main.cpp +++ b/be/src/service/doris_main.cpp @@ -169,8 +169,9 @@ auto instruction_fail_to_string(InstructionFail fail) { case InstructionFail::ARM_NEON: ret("ARM_NEON"); } - LOG(ERROR) << "__builtin_unreachable"; - __builtin_unreachable(); + + LOG(ERROR) << "Unrecognized instruction fail value." << std::endl; + exit(-1); } sigjmp_buf jmpbuf;