diff --git a/be/src/vec/runtime/vorc_writer.cpp b/be/src/vec/runtime/vorc_writer.cpp index c719268c9b8151..dff2d3da75b0f8 100644 --- a/be/src/vec/runtime/vorc_writer.cpp +++ b/be/src/vec/runtime/vorc_writer.cpp @@ -69,8 +69,8 @@ VOrcOutputStream::~VOrcOutputStream() { void VOrcOutputStream::close() { if (!_is_closed) { + Defer defer {[this] { _is_closed = true; }}; Status st = _file_writer->close(); - _is_closed = true; if (!st.ok()) { LOG(WARNING) << "close orc output stream failed: " << st; throw std::runtime_error(st.to_string()); diff --git a/be/src/vec/runtime/vparquet_writer.cpp b/be/src/vec/runtime/vparquet_writer.cpp index 8d986dac326f74..b5f73e2ca18ef6 100644 --- a/be/src/vec/runtime/vparquet_writer.cpp +++ b/be/src/vec/runtime/vparquet_writer.cpp @@ -98,15 +98,14 @@ arrow::Result ParquetOutputStream::Tell() const { } arrow::Status ParquetOutputStream::Close() { - if (_is_closed) { - return arrow::Status::OK(); - } - Status st = _file_writer->close(); - if (!st.ok()) { - LOG(WARNING) << "close parquet output stream failed: " << st; - return arrow::Status::IOError(st.to_string()); + if (!_is_closed) { + Defer defer {[this] { _is_closed = true; }}; + Status st = _file_writer->close(); + if (!st.ok()) { + LOG(WARNING) << "close parquet output stream failed: " << st; + return arrow::Status::IOError(st.to_string()); + } } - _is_closed = true; return arrow::Status::OK(); } @@ -942,6 +941,7 @@ int64_t VParquetWriterWrapper::written_len() { Status VParquetWriterWrapper::close() { try { if (_rg_writer != nullptr) { + LOG(INFO) << "--ftw: _rg_writer->Close()"; _rg_writer->Close(); _rg_writer = nullptr; }