From 49cc89aa80a6f27490bff591619e238b262cfed5 Mon Sep 17 00:00:00 2001 From: caokaihua1 <978176728@qq.com> Date: Mon, 15 Jul 2024 12:08:12 +0800 Subject: [PATCH 1/4] [enhancement](log) change the default setting of sys_log_mode in fe.conf from NORMAL to ASYNC for better performance. --- conf/fe.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf/fe.conf b/conf/fe.conf index f50d20c8110d6f..815f96f9d3445a 100644 --- a/conf/fe.conf +++ b/conf/fe.conf @@ -64,7 +64,7 @@ arrow_flight_sql_port = -1 # INFO, WARN, ERROR, FATAL sys_log_level = INFO # NORMAL, BRIEF, ASYNC -sys_log_mode = NORMAL +sys_log_mode = ASYNC # sys_log_roll_num = 10 # sys_log_verbose_modules = org.apache.doris # audit_log_dir = $LOG_DIR From caff078693660875175d91483a628603de8ec718 Mon Sep 17 00:00:00 2001 From: caokaihua1 <978176728@qq.com> Date: Mon, 15 Jul 2024 16:06:27 +0800 Subject: [PATCH 2/4] [enhancement](log) change the default setting of sys_log_mode in Config.java from NORMAL to ASYNC for better performance. --- fe/fe-common/src/main/java/org/apache/doris/common/Config.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java index 5756d8fbfc2ee5..e9e400e32f6d22 100644 --- a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java +++ b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java @@ -77,7 +77,7 @@ public class Config extends ConfigBase { + " location information. ASYNC mode is asynchronous and does not contain location information." + " The performance of the three log output modes increases in sequence"}, options = {"NORMAL", "BRIEF", "ASYNC"}) - public static String sys_log_mode = "NORMAL"; + public static String sys_log_mode = "ASYNC"; @ConfField(description = {"FE 日志文件的最大数量。超过这个数量后，最老的日志文件会被删除", "The maximum number of FE log files. After exceeding this number, the oldest log file will be deleted"}) From 415bbc73f6d146cf010746d03fcc41b7820c5d33 Mon Sep 17 00:00:00 2001 From: caokaihua1 <978176728@qq.com> Date: Mon, 15 Jul 2024 20:25:21 +0800 Subject: [PATCH 3/4] [enhancement](log) modifying the description of sys_log_mod --- .../main/java/org/apache/doris/common/Config.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java index e9e400e32f6d22..2f1317680fba4d 100644 --- a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java +++ b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java @@ -70,12 +70,12 @@ public class Config extends ConfigBase { @ConfField(description = {"FE 日志的级别", "The level of FE log"}, options = {"INFO", "WARN", "ERROR", "FATAL"}) public static String sys_log_level = "INFO"; - @ConfField(description = {"FE 日志的输出模式，其中 NORMAL 为默认的输出模式，日志同步输出且包含位置信息，" - + "BRIEF 模式是日志同步输出但不包含位置信息，ASYNC 模式是日志异步输出且不包含位置信息，三种日志输出模式的性能依次递增", - "The output mode of FE log, and NORMAL mode is the default output mode, which means the logs are " - + "synchronized and contain location information. BRIEF mode is synchronized and does not contain" - + " location information. ASYNC mode is asynchronous and does not contain location information." - + " The performance of the three log output modes increases in sequence"}, + @ConfField(description = {"FE 日志的输出模式，其中 NORMAL 模式是日志同步输出且包含位置信息，BRIEF 模式是日志同步输出" + + "但不包含位置信息，ASYNC 模式为默认的输出模式，是日志异步输出且不包含位置信息，三种日志输出模式的性能依次递增", + "The output mode of FE log, and NORMAL mode means the logs are synchronized and contain location " + + "information. BRIEF mode is synchronized and does not contain location information. ASYNC mode is " + + "the default output mode, which is asynchronous and does not contain location information. " + + "The performance of the three log output modes increases in sequence"}, options = {"NORMAL", "BRIEF", "ASYNC"}) public static String sys_log_mode = "ASYNC"; From 131b2937f6e7e3b85103e3757ed2bb80ac6758ea Mon Sep 17 00:00:00 2001 From: caokaihua1 <978176728@qq.com> Date: Mon, 15 Jul 2024 22:29:06 +0800 Subject: [PATCH 4/4] [enhancement](log) modifying the style of description --- .../main/java/org/apache/doris/common/Config.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java index 2f1317680fba4d..445607acd668d3 100644 --- a/fe/fe-common/src/main/java/org/apache/doris/common/Config.java +++ b/fe/fe-common/src/main/java/org/apache/doris/common/Config.java @@ -70,12 +70,12 @@ public class Config extends ConfigBase { @ConfField(description = {"FE 日志的级别", "The level of FE log"}, options = {"INFO", "WARN", "ERROR", "FATAL"}) public static String sys_log_level = "INFO"; - @ConfField(description = {"FE 日志的输出模式，其中 NORMAL 模式是日志同步输出且包含位置信息，BRIEF 模式是日志同步输出" + - "但不包含位置信息，ASYNC 模式为默认的输出模式，是日志异步输出且不包含位置信息，三种日志输出模式的性能依次递增", - "The output mode of FE log, and NORMAL mode means the logs are synchronized and contain location " + - "information. BRIEF mode is synchronized and does not contain location information. ASYNC mode is " + - "the default output mode, which is asynchronous and does not contain location information. " + - "The performance of the three log output modes increases in sequence"}, + @ConfField(description = {"FE 日志的输出模式，其中 NORMAL 模式是日志同步输出且包含位置信息，BRIEF 模式是日志同步输出" + + "但不包含位置信息，ASYNC 模式为默认的输出模式，是日志异步输出且不包含位置信息，三种日志输出模式的性能依次递增", + "The output mode of FE log, and NORMAL mode means the logs are synchronized and contain location " + + "information. BRIEF mode is synchronized and does not contain location information. " + + "ASYNC mode is the default output mode, which is asynchronous and does not contain " + + "location information. The performance of the three log output modes increases in sequence"}, options = {"NORMAL", "BRIEF", "ASYNC"}) public static String sys_log_mode = "ASYNC";