diff --git a/be/src/vec/functions/array/function_array_with_constant.cpp b/be/src/vec/functions/array/function_array_with_constant.cpp index bb3cbb53e41231..16e3947714cb62 100644 --- a/be/src/vec/functions/array/function_array_with_constant.cpp +++ b/be/src/vec/functions/array/function_array_with_constant.cpp @@ -91,9 +91,9 @@ class FunctionArrayWithConstant : public IFunction { array_sizes.reserve(input_rows_count); for (size_t i = 0; i < input_rows_count; ++i) { auto array_size = num->get_int(i); - if (UNLIKELY(array_size < 0)) { - return Status::RuntimeError("Array size can not be negative in function:" + - get_name()); + if (UNLIKELY(array_size < 0) || UNLIKELY(array_size > max_array_size_as_field)) { + return Status::RuntimeError("Array size should in range(0, {}) in function: {}", + max_array_size_as_field, get_name()); } offset += array_size; offsets.push_back(offset); diff --git a/regression-test/suites/datatype_p0/nested_types/query/array_functions/test_array_functions_array_with_const.groovy b/regression-test/suites/datatype_p0/nested_types/query/array_functions/test_array_functions_array_with_const.groovy index a155210fc507b8..087054d35e25e1 100644 --- a/regression-test/suites/datatype_p0/nested_types/query/array_functions/test_array_functions_array_with_const.groovy +++ b/regression-test/suites/datatype_p0/nested_types/query/array_functions/test_array_functions_array_with_const.groovy @@ -16,6 +16,7 @@ // under the License. suite("test_array_functions_array_with_const", "p0") { + sql "set enable_nereids_planner=false;" //array_with_constant qt_old_sql "SELECT 'array_with_constant';" order_qt_old_sql "SELECT array_with_constant(3, number) FROM numbers limit 10;" @@ -31,7 +32,16 @@ suite("test_array_functions_array_with_const", "p0") { SELECT array_with_constant(-231.37104, -138); """ } catch (Exception ex) { - assertTrue(ex.getMessage().contains("Array size can not be negative in function:array_with_constant")) + assertTrue(ex.getMessage().contains("Array size should in range(0, 1000000) in function")) + } + + // -- {server for large array} + try { + sql """ + SELECT array_with_constant(1000001, 1); + """ + } catch (Exception ex) { + assertTrue(ex.getMessage().contains("Array size should in range(0, 1000000) in function")) } @@ -53,7 +63,15 @@ suite("test_array_functions_array_with_const", "p0") { SELECT array_with_constant(-231.37104, -138); """ } catch (Exception ex) { - assertTrue(ex.getMessage().contains("Array size can not be negative in function:array_with_constant")) + assertTrue(ex.getMessage().contains("Array size should in range(0, 1000000) in function")) } + // -- {server for large array} + try { + sql """ + SELECT array_with_constant(1000001, 1); + """ + } catch (Exception ex) { + assertTrue(ex.getMessage().contains("Array size should in range(0, 1000000) in function")) + } }