From afdcdad6e0b64a4659524e5cc2b8b58ef469db10 Mon Sep 17 00:00:00 2001 From: yiguolei <676222867@qq.com> Date: Thu, 19 Sep 2024 13:56:39 +0800 Subject: [PATCH] [bugfix](cache) the cache capacity is wrong when memusage > soft memlimit (#40961) ## Proposed changes bug is introduced by https://github.com/apache/doris/pull/40542 Co-authored-by: yiguolei --- be/src/common/daemon.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/be/src/common/daemon.cpp b/be/src/common/daemon.cpp index 713813b4a334f9..b25856fb65dad9 100644 --- a/be/src/common/daemon.cpp +++ b/be/src/common/daemon.cpp @@ -245,10 +245,14 @@ void refresh_cache_capacity() { auto cache_capacity_reduce_mem_limit = uint64_t( doris::MemInfo::soft_mem_limit() * config::cache_capacity_reduce_mem_limit_frac); int64_t process_memory_usage = doris::GlobalMemoryArbitrator::process_memory_usage(); + // the rule is like this: + // 1. if the process mem usage < soft memlimit * 0.6, then do not need adjust cache capacity. + // 2. if the process mem usage > soft memlimit * 0.6 and process mem usage < soft memlimit, then it will be adjusted to a lower value. + // 3. if the process mem usage > soft memlimit, then the capacity is adjusted to 0. double new_cache_capacity_adjust_weighted = process_memory_usage <= cache_capacity_reduce_mem_limit ? 1 - : std::min( + : std::max( 1 - (process_memory_usage - cache_capacity_reduce_mem_limit) / (doris::MemInfo::soft_mem_limit() - cache_capacity_reduce_mem_limit),