From d654a26acc49317439f8a4fb0e9dd0af510e7b2a Mon Sep 17 00:00:00 2001 From: morrySnow Date: Wed, 25 Sep 2024 10:49:43 +0800 Subject: [PATCH] [chore](planner) remove useless legacy planner parse in ConnectProcessor --- .../org/apache/doris/qe/ConnectProcessor.java | 35 ------------------- 1 file changed, 35 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java b/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java index 3a1e95ad6d3ac3..42724eebbe112a 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java +++ b/fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java @@ -22,8 +22,6 @@ import org.apache.doris.analysis.KillStmt; import org.apache.doris.analysis.LiteralExpr; import org.apache.doris.analysis.QueryStmt; -import org.apache.doris.analysis.SqlParser; -import org.apache.doris.analysis.SqlScanner; import org.apache.doris.analysis.StatementBase; import org.apache.doris.analysis.UserIdentity; import org.apache.doris.catalog.Column; @@ -43,7 +41,6 @@ import org.apache.doris.common.Pair; import org.apache.doris.common.UserException; import org.apache.doris.common.util.DebugUtil; -import org.apache.doris.common.util.SqlParserUtils; import org.apache.doris.common.util.SqlUtils; import org.apache.doris.common.util.Util; import org.apache.doris.datasource.CatalogIf; @@ -87,7 +84,6 @@ import org.apache.thrift.TException; import java.io.IOException; -import java.io.StringReader; import java.nio.ByteBuffer; import java.util.ArrayList; import java.util.List; @@ -492,37 +488,6 @@ protected void handleQueryException(Throwable throwable, String origStmt, auditAfterExec(origStmt, parsedStmt, statistics, true); } - // analyze the origin stmt and return multi-statements - protected List parse(String originStmt) throws AnalysisException, DdlException { - if (LOG.isDebugEnabled()) { - LOG.debug("the originStmts are: {}", originStmt); - } - // Parse statement with parser generated by CUP&FLEX - SqlScanner input = new SqlScanner(new StringReader(originStmt), ctx.getSessionVariable().getSqlMode()); - SqlParser parser = new SqlParser(input); - try { - return SqlParserUtils.getMultiStmts(parser); - } catch (Error e) { - throw new AnalysisException("Please check your sql, we meet an error when parsing.", e); - } catch (AnalysisException | DdlException e) { - String errorMessage = parser.getErrorMsg(originStmt); - if (LOG.isDebugEnabled()) { - LOG.debug("origin stmt: {}; Analyze error message: {}", originStmt, parser.getErrorMsg(originStmt), e); - } - if (errorMessage == null) { - throw e; - } else { - throw new AnalysisException(errorMessage, e); - } - } catch (ArrayStoreException e) { - throw new AnalysisException("Sql parser can't convert the result to array, please check your sql.", e); - } catch (Exception e) { - // TODO(lingbin): we catch 'Exception' to prevent unexpected error, - // should be removed this try-catch clause future. - throw new AnalysisException("Internal Error, maybe syntax error or this is a bug: " + e.getMessage(), e); - } - } - // Get the column definitions of a table @SuppressWarnings("rawtypes") protected void handleFieldList(String tableName) throws ConnectionException {