From 73f61d723594a670628d5f35e0b4a29761cb1b6a Mon Sep 17 00:00:00 2001 From: zy-kkk Date: Fri, 27 Sep 2024 17:28:24 +0800 Subject: [PATCH] [fix](oracle scan) Fix performance issues caused by version judgment --- .../main/java/org/apache/doris/jdbc/OracleJdbcExecutor.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/OracleJdbcExecutor.java b/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/OracleJdbcExecutor.java index 6f38895335b986..344e88b96c2095 100644 --- a/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/OracleJdbcExecutor.java +++ b/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/OracleJdbcExecutor.java @@ -39,9 +39,11 @@ public class OracleJdbcExecutor extends BaseJdbcExecutor { private static final Logger LOG = Logger.getLogger(OracleJdbcExecutor.class); private final CharsetDecoder utf8Decoder = StandardCharsets.UTF_8.newDecoder(); + private final boolean isNewJdbcVersion; public OracleJdbcExecutor(byte[] thriftParams) throws Exception { super(thriftParams); + isNewJdbcVersion = isJdbcVersionGreaterThanOrEqualTo("12.2.0"); } @Override @@ -65,7 +67,7 @@ protected void initializeBlock(int columnCount, String[] replaceStringList, int @Override protected Object getColumnValue(int columnIndex, ColumnType type, String[] replaceStringList) throws SQLException { - if (isJdbcVersionGreaterThanOrEqualTo("12.2.0")) { + if (isNewJdbcVersion) { return newGetColumnValue(columnIndex, type, replaceStringList); } else { return oldGetColumnValue(columnIndex, type, replaceStringList);