From e5f90d93f3052acd311983f740e6b52dd5905f9a Mon Sep 17 00:00:00 2001 From: Jibing-Li <64681310+Jibing-Li@users.noreply.github.com> Date: Wed, 16 Oct 2024 19:11:34 +0800 Subject: [PATCH] [improvement](statistics)Use min row count of all replicas as tablet/table row count. (#41894) Use min row count of all replicas with same version as tablet/table row count. Because replica with the least row count means it perform more compaction operation than the others. Use it as tablet row count is more accurate. Meanwhile, use min row count as tablet row count while choosing tablets during sample analyze. --- .../java/org/apache/doris/catalog/Tablet.java | 17 +++++++++ .../apache/doris/catalog/TabletStatMgr.java | 12 +++++-- .../doris/statistics/OlapAnalysisTask.java | 3 +- .../org/apache/doris/catalog/TabletTest.java | 36 +++++++++++++++++++ 4 files changed, 65 insertions(+), 3 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java b/fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java index a7240895029b8d..baf21cbeebe2ba 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java +++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java @@ -476,6 +476,23 @@ public long getRowCount(boolean singleReplica) { return singleReplica ? Double.valueOf(s.average().orElse(0)).longValue() : s.sum(); } + // Get the least row count among all valid replicas. + // The replica with the least row count is the most accurate one. Because it performs most compaction. + public long getMinReplicaRowCount(long version) { + long minRowCount = Long.MAX_VALUE; + long maxReplicaVersion = 0; + for (Replica r : replicas) { + if (r.isAlive() + && r.checkVersionCatchUp(version, false) + && (r.getVersion() > maxReplicaVersion + || r.getVersion() == maxReplicaVersion && r.getRowCount() < minRowCount)) { + minRowCount = r.getRowCount(); + maxReplicaVersion = r.getVersion(); + } + } + return minRowCount == Long.MAX_VALUE ? 0 : minRowCount; + } + /** * A replica is healthy only if * 1. the backend is available diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/TabletStatMgr.java b/fe/fe-core/src/main/java/org/apache/doris/catalog/TabletStatMgr.java index 00b3bcfca87178..2cbb55dca193d7 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/catalog/TabletStatMgr.java +++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/TabletStatMgr.java @@ -115,14 +115,17 @@ protected void runAfterCatalogReady() { long indexRowCount = 0L; boolean indexReported = true; for (Tablet tablet : index.getTablets()) { - long tabletRowCount = 0L; + long tabletRowCount = Long.MAX_VALUE; boolean tabletReported = false; for (Replica replica : tablet.getReplicas()) { LOG.debug("Table {} replica {} current version {}, report version {}", olapTable.getName(), replica.getId(), replica.getVersion(), replica.getLastReportVersion()); + // Replica with less row count is more accurate than the others + // when replicas' version are identical. Because less row count + // means this replica does more compaction than the others. if (replica.checkVersionCatchUp(version, false) - && replica.getRowCount() >= tabletRowCount) { + && replica.getRowCount() < tabletRowCount) { // 1. If replica version and reported replica version are all equal to // PARTITION_INIT_VERSION, set tabletReported to true, which indicates this // tablet is empty for sure when previous report. @@ -139,6 +142,11 @@ protected void runAfterCatalogReady() { tabletRowCount = replica.getRowCount(); } } + + // When all BEs are down, avoid set Long.MAX_VALUE to index and table row count. Use 0. + if (tabletRowCount == Long.MAX_VALUE) { + tabletRowCount = 0L; + } indexRowCount += tabletRowCount; // Only when all tablets of this index are reported, we set indexReported to true. indexReported = indexReported && tabletReported; diff --git a/fe/fe-core/src/main/java/org/apache/doris/statistics/OlapAnalysisTask.java b/fe/fe-core/src/main/java/org/apache/doris/statistics/OlapAnalysisTask.java index 34fb339564abed..94370659b344f0 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/statistics/OlapAnalysisTask.java +++ b/fe/fe-core/src/main/java/org/apache/doris/statistics/OlapAnalysisTask.java @@ -284,7 +284,8 @@ protected Pair, Long> calcActualSampleTablets(boolean forPartitionCol int seekTid = (int) ((i + seek) % ids.size()); long tabletId = ids.get(seekTid); sampleTabletIds.add(tabletId); - actualSampledRowCount += materializedIndex.getTablet(tabletId).getRowCount(true); + actualSampledRowCount += materializedIndex.getTablet(tabletId) + .getMinReplicaRowCount(p.getVisibleVersion()); if (actualSampledRowCount >= sampleRows && !forPartitionColumn) { enough = true; break; diff --git a/fe/fe-core/src/test/java/org/apache/doris/catalog/TabletTest.java b/fe/fe-core/src/test/java/org/apache/doris/catalog/TabletTest.java index 99769a6b525058..665aaa078edaa2 100644 --- a/fe/fe-core/src/test/java/org/apache/doris/catalog/TabletTest.java +++ b/fe/fe-core/src/test/java/org/apache/doris/catalog/TabletTest.java @@ -213,4 +213,40 @@ public void testTabletColocateHealthStatus() { Pair.of(1L, false), Pair.of(2L, false), Pair.of(3L, false), Pair.of(4L, true) ); } + + @Test + public void testGetMinReplicaRowCount() { + Tablet t = new Tablet(1); + long row = t.getMinReplicaRowCount(1); + Assert.assertEquals(0, row); + + Replica r1 = new Replica(1, 1, 10, 0, 0, 0, 100, ReplicaState.NORMAL, 0, 10); + t.addReplica(r1); + row = t.getMinReplicaRowCount(10); + Assert.assertEquals(100, row); + + row = t.getMinReplicaRowCount(11); + Assert.assertEquals(0, row); + + Replica r2 = new Replica(2, 2, 10, 0, 0, 0, 110, ReplicaState.NORMAL, 0, 10); + Replica r3 = new Replica(3, 3, 10, 0, 0, 0, 90, ReplicaState.NORMAL, 0, 10); + t.addReplica(r2); + t.addReplica(r3); + row = t.getMinReplicaRowCount(11); + Assert.assertEquals(0, row); + row = t.getMinReplicaRowCount(9); + Assert.assertEquals(90, row); + + r3.setBad(true); + row = t.getMinReplicaRowCount(9); + Assert.assertEquals(100, row); + + r3.setBad(false); + row = t.getMinReplicaRowCount(9); + Assert.assertEquals(90, row); + + r2.updateVersion(11); + row = t.getMinReplicaRowCount(9); + Assert.assertEquals(110, row); + } }