From 4f07eaaed29d6e268db9d96ac7d912f24ae3cff2 Mon Sep 17 00:00:00 2001 From: Yongqiang YANG Date: Thu, 17 Oct 2024 14:32:30 +0800 Subject: [PATCH 1/4] [fix](exit) stop storage engine in exec_env before exit --- be/src/runtime/exec_env_init.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp index ff6205bf55e5d0..ea9222dee38168 100644 --- a/be/src/runtime/exec_env_init.cpp +++ b/be/src/runtime/exec_env_init.cpp @@ -677,6 +677,7 @@ void ExecEnv::destroy() { // StorageEngine must be destoried before _page_no_cache_mem_tracker.reset and _cache_manager destory // shouldn't use SAFE_STOP. otherwise will lead to twice stop. + _storage_engine.stop(); _storage_engine.reset(); SAFE_STOP(_spill_stream_mgr); From f2735f4e4df67ea7d1ad8f06630237a8bce05958 Mon Sep 17 00:00:00 2001 From: Yongqiang YANG Date: Thu, 17 Oct 2024 15:07:22 +0800 Subject: [PATCH 2/4] fix --- be/src/runtime/exec_env_init.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp index ea9222dee38168..df345a69e632a0 100644 --- a/be/src/runtime/exec_env_init.cpp +++ b/be/src/runtime/exec_env_init.cpp @@ -677,7 +677,7 @@ void ExecEnv::destroy() { // StorageEngine must be destoried before _page_no_cache_mem_tracker.reset and _cache_manager destory // shouldn't use SAFE_STOP. otherwise will lead to twice stop. - _storage_engine.stop(); + _storage_engine->stop(); _storage_engine.reset(); SAFE_STOP(_spill_stream_mgr); From f1d81e8b5851fbf251a2df149b9b8e9e08eff098 Mon Sep 17 00:00:00 2001 From: Yongqiang YANG Date: Sun, 20 Oct 2024 10:03:42 +0800 Subject: [PATCH 3/4] fix --- be/src/runtime/exec_env_init.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp index df345a69e632a0..91a8f8aca8ac70 100644 --- a/be/src/runtime/exec_env_init.cpp +++ b/be/src/runtime/exec_env_init.cpp @@ -677,7 +677,7 @@ void ExecEnv::destroy() { // StorageEngine must be destoried before _page_no_cache_mem_tracker.reset and _cache_manager destory // shouldn't use SAFE_STOP. otherwise will lead to twice stop. - _storage_engine->stop(); + SAFE_STOP(_storage_engine); _storage_engine.reset(); SAFE_STOP(_spill_stream_mgr); From f7a0d0002cfd7708c8503615d24bbc34f2d54d56 Mon Sep 17 00:00:00 2001 From: Yongqiang YANG Date: Wed, 30 Oct 2024 10:54:42 +0800 Subject: [PATCH 4/4] fix --- be/src/runtime/exec_env_init.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp index 91a8f8aca8ac70..9e1536d5186cfd 100644 --- a/be/src/runtime/exec_env_init.cpp +++ b/be/src/runtime/exec_env_init.cpp @@ -676,7 +676,6 @@ void ExecEnv::destroy() { SAFE_STOP(_write_cooldown_meta_executors); // StorageEngine must be destoried before _page_no_cache_mem_tracker.reset and _cache_manager destory - // shouldn't use SAFE_STOP. otherwise will lead to twice stop. SAFE_STOP(_storage_engine); _storage_engine.reset();