From 8961d7027a07385d848bfb517efa20c8d34b51c9 Mon Sep 17 00:00:00 2001 From: BiteTheDDDDt Date: Thu, 14 Nov 2024 10:41:19 +0800 Subject: [PATCH 1/2] fix core dump on rf between varchar and char --- be/src/exprs/create_predicate_function.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/be/src/exprs/create_predicate_function.h b/be/src/exprs/create_predicate_function.h index 4808caa00f37d0..9998db887c14f0 100644 --- a/be/src/exprs/create_predicate_function.h +++ b/be/src/exprs/create_predicate_function.h @@ -234,7 +234,7 @@ ColumnPredicate* create_olap_column_predicate(uint32_t column_id, std::shared_ptr filter_olap; filter_olap.reset(create_bloom_filter(PT)); filter_olap->light_copy(filter.get()); - return new BloomFilterColumnPredicate(column_id, filter); + return new BloomFilterColumnPredicate(column_id, filter_olap); } template From 91e2e840b79137eac65c8c8844ac665b55e23ba4 Mon Sep 17 00:00:00 2001 From: BiteTheDDDDt Date: Thu, 14 Nov 2024 13:19:26 +0800 Subject: [PATCH 2/2] update --- be/src/olap/bloom_filter_predicate.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/be/src/olap/bloom_filter_predicate.h b/be/src/olap/bloom_filter_predicate.h index 0e2ae500ac6a58..2759a5c5fe0e98 100644 --- a/be/src/olap/bloom_filter_predicate.h +++ b/be/src/olap/bloom_filter_predicate.h @@ -93,7 +93,9 @@ class BloomFilterColumnPredicate : public ColumnPredicate { int get_filter_id() const override { int filter_id = _filter->get_filter_id(); - DCHECK(filter_id != -1); + if (filter_id == 1) { + throw Exception(ErrorCode::INTERNAL_ERROR, "filter_id is -1"); + } return filter_id; } bool is_filter() const override { return true; }