From 9aa3818808035ec8f08fe27f242245ed86abb9e1 Mon Sep 17 00:00:00 2001
From: zhengyu <zhangzhengyu@selectdb.com>
Date: Fri, 15 Nov 2024 11:30:16 +0800
Subject: [PATCH 1/4] [fix](cloud) more specific error message when parse
 file_cache_path

---
 be/src/runtime/exec_env_init.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp
index 0f0b677bb1ce96..c01817510bbc38 100644
--- a/be/src/runtime/exec_env_init.cpp
+++ b/be/src/runtime/exec_env_init.cpp
@@ -422,7 +422,7 @@ void ExecEnv::init_file_cache_factory(std::vector<doris::CachePath>& cache_paths
     Status rest = doris::parse_conf_cache_paths(doris::config::file_cache_path, cache_paths);
     if (!rest) {
         LOG(FATAL) << "parse config file cache path failed, path="
-                   << doris::config::file_cache_path;
+                   << doris::config::file_cache_path << ", reason=" << rest.msg();
         exit(-1);
     }
     std::vector<std::thread> file_cache_init_threads;

From f45c8026b11958b80449499f0c49a6c884b7d8a0 Mon Sep 17 00:00:00 2001
From: zhengyu <zhangzhengyu@selectdb.com>
Date: Fri, 15 Nov 2024 11:34:52 +0800
Subject: [PATCH 2/4] Update exec_env_init.cpp

---
 be/src/runtime/exec_env_init.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp
index c01817510bbc38..706fd7efd07d0f 100644
--- a/be/src/runtime/exec_env_init.cpp
+++ b/be/src/runtime/exec_env_init.cpp
@@ -421,8 +421,8 @@ void ExecEnv::init_file_cache_factory(std::vector<doris::CachePath>& cache_paths
     std::unordered_set<std::string> cache_path_set;
     Status rest = doris::parse_conf_cache_paths(doris::config::file_cache_path, cache_paths);
     if (!rest) {
-        LOG(FATAL) << "parse config file cache path failed, path="
-                   << doris::config::file_cache_path << ", reason=" << rest.msg();
+        LOG(FATAL) << "parse config file cache path failed, path=" << doris::config::file_cache_path
+                   << ", reason=" << rest.msg();
         exit(-1);
     }
     std::vector<std::thread> file_cache_init_threads;

From 5c2df5760d98d98fa3d7d9084c6f217a9d9a4f1a Mon Sep 17 00:00:00 2001
From: zhengyu <zhangzhengyu@selectdb.com>
Date: Fri, 15 Nov 2024 11:38:33 +0800
Subject: [PATCH 3/4] Update options.cpp

---
 be/src/olap/options.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/be/src/olap/options.cpp b/be/src/olap/options.cpp
index 8668f8319d10e6..66b6636602f364 100644
--- a/be/src/olap/options.cpp
+++ b/be/src/olap/options.cpp
@@ -283,7 +283,7 @@ Status parse_conf_cache_paths(const std::string& config_path, std::vector<CacheP
         } else if (has_normal_percent || has_disposable_percent || has_index_percent ||
                    has_ttl_percent) {
             return Status::InvalidArgument(
-                    "cache percent config must either be all set or all unset.");
+                    "cache percent (ttl_percent, index_percent, normal_percent, disposable_percent) must either be all set or all unset.");
         }
         if ((normal_percent + disposable_percent + index_percent + ttl_percent) != 100) {
             return Status::InvalidArgument("The sum of cache percent config must equal 100.");

From 4ef0f8960d50301b4e6c95105723ad1221e84bdc Mon Sep 17 00:00:00 2001
From: zhengyu <zhangzhengyu@selectdb.com>
Date: Fri, 15 Nov 2024 11:45:25 +0800
Subject: [PATCH 4/4] Update options.cpp

---
 be/src/olap/options.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/be/src/olap/options.cpp b/be/src/olap/options.cpp
index 66b6636602f364..6e4cb61e3d0182 100644
--- a/be/src/olap/options.cpp
+++ b/be/src/olap/options.cpp
@@ -283,7 +283,10 @@ Status parse_conf_cache_paths(const std::string& config_path, std::vector<CacheP
         } else if (has_normal_percent || has_disposable_percent || has_index_percent ||
                    has_ttl_percent) {
             return Status::InvalidArgument(
-                    "cache percent (ttl_percent, index_percent, normal_percent, disposable_percent) must either be all set or all unset.");
+                    "cache percent (ttl_percent, index_percent, normal_percent, "
+                    "disposable_percent) must either be all set or all unset. "
+                    "when all unset, use default: ttl_percent=50, index_percent=5, "
+                    "normal_percent=40, disposable_percent=5.");
         }
         if ((normal_percent + disposable_percent + index_percent + ttl_percent) != 100) {
             return Status::InvalidArgument("The sum of cache percent config must equal 100.");