From a2673e9b978f6e32cc213ea77ff8b63b777c3de1 Mon Sep 17 00:00:00 2001
From: zhengyu <zhangzhengyu@selectdb.com>
Date: Mon, 18 Nov 2024 14:49:33 +0800
Subject: [PATCH] [fix](cloud) explicit message when parse file_cache_path
 error (#44004)

print more explicit reason why file_cache_path fail to parse
---
 be/src/olap/options.cpp          | 5 ++++-
 be/src/runtime/exec_env_init.cpp | 4 ++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/be/src/olap/options.cpp b/be/src/olap/options.cpp
index 8668f8319d10e6..6e4cb61e3d0182 100644
--- a/be/src/olap/options.cpp
+++ b/be/src/olap/options.cpp
@@ -283,7 +283,10 @@ Status parse_conf_cache_paths(const std::string& config_path, std::vector<CacheP
         } else if (has_normal_percent || has_disposable_percent || has_index_percent ||
                    has_ttl_percent) {
             return Status::InvalidArgument(
-                    "cache percent config must either be all set or all unset.");
+                    "cache percent (ttl_percent, index_percent, normal_percent, "
+                    "disposable_percent) must either be all set or all unset. "
+                    "when all unset, use default: ttl_percent=50, index_percent=5, "
+                    "normal_percent=40, disposable_percent=5.");
         }
         if ((normal_percent + disposable_percent + index_percent + ttl_percent) != 100) {
             return Status::InvalidArgument("The sum of cache percent config must equal 100.");
diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp
index 51714c7deb2053..b91adb4de9836e 100644
--- a/be/src/runtime/exec_env_init.cpp
+++ b/be/src/runtime/exec_env_init.cpp
@@ -418,8 +418,8 @@ void ExecEnv::init_file_cache_factory(std::vector<doris::CachePath>& cache_paths
     std::unordered_set<std::string> cache_path_set;
     Status rest = doris::parse_conf_cache_paths(doris::config::file_cache_path, cache_paths);
     if (!rest) {
-        LOG(FATAL) << "parse config file cache path failed, path="
-                   << doris::config::file_cache_path;
+        LOG(FATAL) << "parse config file cache path failed, path=" << doris::config::file_cache_path
+                   << ", reason=" << rest.msg();
         exit(-1);
     }
     std::vector<std::thread> file_cache_init_threads;