From 0f2c0dd101a3a0388d99d8c8ab1624e551ccdc7c Mon Sep 17 00:00:00 2001 From: wuwenchi Date: Fri, 13 Dec 2024 18:09:11 +0800 Subject: [PATCH] fix --- .../org/apache/doris/common/util/LocationPath.java | 2 +- .../apache/doris/common/util/LocationPathTest.java | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/common/util/LocationPath.java b/fe/fe-core/src/main/java/org/apache/doris/common/util/LocationPath.java index 4604e4deabb2b7..2318532cba697f 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/common/util/LocationPath.java +++ b/fe/fe-core/src/main/java/org/apache/doris/common/util/LocationPath.java @@ -90,7 +90,7 @@ public LocationPath(String location, Map props) { private LocationPath(String originLocation, Map props, boolean convertPath) { isBindBroker = props.containsKey(HMSExternalCatalog.BIND_BROKER_NAME); String tmpLocation = originLocation; - if (!originLocation.contains(SCHEME_DELIM)) { + if (!(originLocation.contains(SCHEME_DELIM) || originLocation.contains(NONSTANDARD_SCHEME_DELIM))) { // Sometimes the file path does not contain scheme, need to add default fs // eg, /path/to/file.parquet -> hdfs://nn/path/to/file.parquet // the default fs is from the catalog properties diff --git a/fe/fe-core/src/test/java/org/apache/doris/common/util/LocationPathTest.java b/fe/fe-core/src/test/java/org/apache/doris/common/util/LocationPathTest.java index 9d1edadd919b59..4457b7dd1efd60 100644 --- a/fe/fe-core/src/test/java/org/apache/doris/common/util/LocationPathTest.java +++ b/fe/fe-core/src/test/java/org/apache/doris/common/util/LocationPathTest.java @@ -205,4 +205,16 @@ public void testNoSchemeLocation() { String beLocation = locationPath.toStorageLocation().toString(); Assertions.assertTrue(beLocation.equalsIgnoreCase("/path/to/local")); } + + @Test + public void testLocalFileSystem() { + HashMap props = new HashMap<>(); + props.put("fs.defaultFS", "hdfs:///xyz"); + LocationPath p1 = new LocationPath("file:///abc/def", props); + Assertions.assertEquals(Scheme.LOCAL, p1.getScheme()); + LocationPath p2 = new LocationPath("file:/abc/def", props); + Assertions.assertEquals(Scheme.LOCAL, p2.getScheme()); + LocationPath p3 = new LocationPath("file://authority/abc/def", props); + Assertions.assertEquals(Scheme.LOCAL, p3.getScheme()); + } }