From b3baac61af3a0cf718a4b00430084383700f9bc3 Mon Sep 17 00:00:00 2001 From: morrySnow Date: Fri, 28 Feb 2025 18:11:38 +0800 Subject: [PATCH] [fix](Nereids) nested window function with order by raise exception --- .../rewrite/ExtractAndNormalizeWindowExpression.java | 2 +- .../normalize_window_nullable_agg_test.groovy | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ExtractAndNormalizeWindowExpression.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ExtractAndNormalizeWindowExpression.java index a74ebe4b76b9cf..0216570956418c 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ExtractAndNormalizeWindowExpression.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ExtractAndNormalizeWindowExpression.java @@ -62,7 +62,7 @@ private Plan normalize(LogicalProject project) { if (output instanceof WindowExpression) { WindowExpression windowExpression = (WindowExpression) output; Expression expression = ((WindowExpression) output).getFunction(); - if (expression.containsType(OrderExpression.class)) { + if (expression.children().stream().anyMatch(OrderExpression.class::isInstance)) { throw new AnalysisException("order by is not supported in " + expression); } if (expression instanceof NullableAggregateFunction) { diff --git a/regression-test/suites/nereids_rules_p0/normalize_window/normalize_window_nullable_agg_test.groovy b/regression-test/suites/nereids_rules_p0/normalize_window/normalize_window_nullable_agg_test.groovy index df3fd63d750742..3d95cc23549a9d 100644 --- a/regression-test/suites/nereids_rules_p0/normalize_window/normalize_window_nullable_agg_test.groovy +++ b/regression-test/suites/nereids_rules_p0/normalize_window/normalize_window_nullable_agg_test.groovy @@ -73,6 +73,16 @@ suite("normalize_window_nullable_agg") { exception "order by is not supported" } + test { + sql "select group_concat(cast(sum(xwhat) over(partition by xwho order by xwhen) as varchar) order by xwhat) over(partition by xwhen) from windowfunnel_test_normalize_window;" + exception "order by is not supported" + } + + // test only refuse order by in function's direct children + sql """ + select sum(sum(xwhat) over(partition by xwho order by xwhen)) over(partition by xwho) from windowfunnel_test_normalize_window + """ + sql "set enable_fold_constant_by_be = 1;" sql "drop table if exists fold_window1" sql """create table fold_window1 (