diff --git a/be/src/exec/csv_scan_node.cpp b/be/src/exec/csv_scan_node.cpp index 745f8a747652b1..a1ef55a8bd355f 100644 --- a/be/src/exec/csv_scan_node.cpp +++ b/be/src/exec/csv_scan_node.cpp @@ -258,7 +258,6 @@ Status CsvScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool* eos RETURN_IF_ERROR(exec_debug_action(TExecNodePhase::GETNEXT)); RETURN_IF_CANCELLED(state); SCOPED_TIMER(_runtime_profile->total_time_counter()); - SCOPED_TIMER(materialize_tuple_timer()); if (reached_limit()) { *eos = true; diff --git a/be/src/exec/es_scan_node.cpp b/be/src/exec/es_scan_node.cpp index 30c00fd1e58a84..54ae643625cda7 100644 --- a/be/src/exec/es_scan_node.cpp +++ b/be/src/exec/es_scan_node.cpp @@ -206,7 +206,6 @@ Status EsScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool* eos) RETURN_IF_ERROR(exec_debug_action(TExecNodePhase::GETNEXT)); RETURN_IF_CANCELLED(state); SCOPED_TIMER(_runtime_profile->total_time_counter()); - SCOPED_TIMER(materialize_tuple_timer()); // create tuple MemPool* tuple_pool = row_batch->tuple_data_pool(); diff --git a/be/src/exec/mysql_scan_node.cpp b/be/src/exec/mysql_scan_node.cpp index 1fecb87822f6cf..f76fcfee9eeac8 100644 --- a/be/src/exec/mysql_scan_node.cpp +++ b/be/src/exec/mysql_scan_node.cpp @@ -160,7 +160,6 @@ Status MysqlScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool* e RETURN_IF_ERROR(exec_debug_action(TExecNodePhase::GETNEXT)); RETURN_IF_CANCELLED(state); SCOPED_TIMER(_runtime_profile->total_time_counter()); - SCOPED_TIMER(materialize_tuple_timer()); // create new tuple buffer for row_batch int tuple_buffer_size = row_batch->capacity() * _tuple_desc->byte_size(); diff --git a/be/src/exec/odbc_scan_node.cpp b/be/src/exec/odbc_scan_node.cpp index ae30d63fed4c21..55614c59244ba9 100644 --- a/be/src/exec/odbc_scan_node.cpp +++ b/be/src/exec/odbc_scan_node.cpp @@ -139,7 +139,6 @@ Status OdbcScanNode::get_next(RuntimeState* state, RowBatch* row_batch, bool* eo RETURN_IF_ERROR(exec_debug_action(TExecNodePhase::GETNEXT)); RETURN_IF_CANCELLED(state); SCOPED_TIMER(_runtime_profile->total_time_counter()); - SCOPED_TIMER(materialize_tuple_timer()); if (reached_limit()) { *eos = true; diff --git a/be/src/exec/scan_node.cpp b/be/src/exec/scan_node.cpp index 3891b7edc4371e..5654f052c042ae 100644 --- a/be/src/exec/scan_node.cpp +++ b/be/src/exec/scan_node.cpp @@ -24,11 +24,7 @@ namespace doris { const string ScanNode::_s_bytes_read_counter = "BytesRead"; const string ScanNode::_s_rows_read_counter = "RowsRead"; const string ScanNode::_s_total_throughput_counter = "TotalReadThroughput"; -const string ScanNode::_s_materialize_tuple_timer = "MaterializeTupleTime(*)"; const string ScanNode::_s_num_disks_accessed_counter = "NumDiskAccess"; -const string ScanNode::_s_scanner_thread_counters_prefix = "ScannerThreads"; -const string ScanNode::_s_scanner_thread_total_wallclock_time = - "ScannerThreadsTotalWallClockTime"; Status ScanNode::prepare(RuntimeState* state) { RETURN_IF_ERROR(ExecNode::prepare(state)); @@ -42,8 +38,6 @@ Status ScanNode::prepare(RuntimeState* state) { _total_throughput_counter = runtime_profile()->add_rate_counter( _s_total_throughput_counter, _bytes_read_counter); #endif - _materialize_tuple_timer = ADD_CHILD_TIMER(runtime_profile(), _s_materialize_tuple_timer, - _s_scanner_thread_total_wallclock_time); _num_disks_accessed_counter = ADD_COUNTER(runtime_profile(), _s_num_disks_accessed_counter, TUnit::UNIT); diff --git a/be/src/exec/scan_node.h b/be/src/exec/scan_node.h index eacb75011bcbfe..cf42357c0a4492 100644 --- a/be/src/exec/scan_node.h +++ b/be/src/exec/scan_node.h @@ -64,15 +64,6 @@ class TScanRange; // // ScanRangesComplete - number of scan ranges completed // -// MaterializeTupleTime - time spent in creating in-memory tuple format -// -// ScannerThreadsTotalWallClockTime - total time spent in all scanner threads. -// -// ScannerThreadsUserTime, ScannerThreadsSysTime, -// ScannerThreadsVoluntaryContextSwitches, ScannerThreadsInvoluntaryContextSwitches - -// these are aggregated counters across all scanner threads of this scan node. They -// are taken from getrusage. See RuntimeProfile::ThreadCounters for details. -// class ScanNode : public ExecNode { public: ScanNode(ObjectPool* pool, const TPlanNode& tnode, const DescriptorTbl& descs) @@ -99,18 +90,12 @@ class ScanNode : public ExecNode { RuntimeProfile::Counter* total_throughput_counter() const { return _total_throughput_counter; } - RuntimeProfile::Counter* materialize_tuple_timer() const { - return _materialize_tuple_timer; - } // names of ScanNode common counters static const std::string _s_bytes_read_counter; static const std::string _s_rows_read_counter; static const std::string _s_total_throughput_counter; static const std::string _s_num_disks_accessed_counter; - static const std::string _s_materialize_tuple_timer; - static const std::string _s_scanner_thread_counters_prefix; - static const std::string _s_scanner_thread_total_wallclock_time; protected: RuntimeProfile::Counter* _bytes_read_counter; // # bytes read from the scanner @@ -119,7 +104,6 @@ class ScanNode : public ExecNode { // Wall based aggregate read throughput [bytes/sec] RuntimeProfile::Counter* _total_throughput_counter; RuntimeProfile::Counter* _num_disks_accessed_counter; - RuntimeProfile::Counter* _materialize_tuple_timer; // time writing tuple slots }; } diff --git a/be/src/exec/schema_scan_node.cpp b/be/src/exec/schema_scan_node.cpp index 6abee999382f7d..e937cc8dcd60b0 100644 --- a/be/src/exec/schema_scan_node.cpp +++ b/be/src/exec/schema_scan_node.cpp @@ -243,7 +243,6 @@ Status SchemaScanNode::get_next(RuntimeState* state, RowBatch* row_batch, RETURN_IF_CANCELLED(state); SCOPED_TIMER(_runtime_profile->total_time_counter()); - SCOPED_TIMER(materialize_tuple_timer()); if (reached_limit()) { *eos = true;