From 31cd5f67b6a5107cc75d0911e9c16279e45630eb Mon Sep 17 00:00:00 2001 From: yiguolei Date: Fri, 20 Jun 2025 14:07:45 +0800 Subject: [PATCH] [bugfix](memleak) fix memleak in arrow input stream (#51929) (#51992) --- be/src/vec/exec/format/arrow/arrow_pip_input_stream.cpp | 2 +- be/src/vec/exec/format/arrow/arrow_pip_input_stream.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/be/src/vec/exec/format/arrow/arrow_pip_input_stream.cpp b/be/src/vec/exec/format/arrow/arrow_pip_input_stream.cpp index 7bc32c7ab4bb91..1c4462befcc53b 100644 --- a/be/src/vec/exec/format/arrow/arrow_pip_input_stream.cpp +++ b/be/src/vec/exec/format/arrow/arrow_pip_input_stream.cpp @@ -32,7 +32,7 @@ namespace doris::vectorized { ArrowPipInputStream::ArrowPipInputStream(io::FileReaderSPtr file_reader) - : _file_reader(file_reader), _pos(0), _begin(true), _read_buf(new uint8_t[4]) { + : _file_reader(file_reader), _pos(0), _begin(true) { set_mode(arrow::io::FileMode::READ); } diff --git a/be/src/vec/exec/format/arrow/arrow_pip_input_stream.h b/be/src/vec/exec/format/arrow/arrow_pip_input_stream.h index fef4cf10903b4c..61276ab190534a 100644 --- a/be/src/vec/exec/format/arrow/arrow_pip_input_stream.h +++ b/be/src/vec/exec/format/arrow/arrow_pip_input_stream.h @@ -59,7 +59,8 @@ class ArrowPipInputStream : public arrow::io::InputStream { io::FileReaderSPtr _file_reader; int64_t _pos; bool _begin; - uint8_t* _read_buf; + // The read buf is very small, so use stack memory directly. + uint8_t _read_buf[4]; }; } // namespace vectorized