From 8d82a7004a16367fd602a599aa95e12509dda2c5 Mon Sep 17 00:00:00 2001 From: lide-reed Date: Thu, 14 Mar 2019 11:19:31 +0800 Subject: [PATCH 1/2] Add comment to avoid modification for variable_length --- be/src/exprs/expr.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/be/src/exprs/expr.cpp b/be/src/exprs/expr.cpp index e971006751500e..2330684a790f55 100644 --- a/be/src/exprs/expr.cpp +++ b/be/src/exprs/expr.cpp @@ -488,6 +488,10 @@ int Expr::compute_results_layout( data[i].variable_length = true; } else if (exprs[i]->type().type == TYPE_DECIMAL) { data[i].byte_size = get_byte_size(exprs[i]->type().type); + + // Although the current decimal has a fix-length, for the + // same data, it will work out different hash value if the + // variable_length here is set to false, so we have to keep it. data[i].variable_length = true; } else { data[i].byte_size = get_byte_size(exprs[i]->type().type); From 14494ba2988897a54055f631db494bf1bc5cec7b Mon Sep 17 00:00:00 2001 From: lide-reed Date: Thu, 14 Mar 2019 11:30:42 +0800 Subject: [PATCH 2/2] Complete comment to avoid modification for variable_length --- be/src/exprs/expr.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/be/src/exprs/expr.cpp b/be/src/exprs/expr.cpp index 2330684a790f55..7420f314f833dd 100644 --- a/be/src/exprs/expr.cpp +++ b/be/src/exprs/expr.cpp @@ -490,8 +490,9 @@ int Expr::compute_results_layout( data[i].byte_size = get_byte_size(exprs[i]->type().type); // Although the current decimal has a fix-length, for the - // same data, it will work out different hash value if the - // variable_length here is set to false, so we have to keep it. + // same value, it will work out different hash value due to the + // different memory represent if the variable_length here is set + // to false, so we have to keep it. data[i].variable_length = true; } else { data[i].byte_size = get_byte_size(exprs[i]->type().type);