From 674e673ba0e9ca63d98de19974f33f4d5d34ead0 Mon Sep 17 00:00:00 2001
From: BiteTheDDDDt <952130278@qq.com>
Date: Tue, 8 Feb 2022 13:30:40 +0800
Subject: [PATCH 1/3] support pmod

---
 be/src/vec/functions/functions_comparison.h | 64 ---------------------
 be/src/vec/functions/modulo.cpp             | 34 ++++++++++-
 gensrc/script/doris_builtins_functions.py   |  4 +-
 3 files changed, 33 insertions(+), 69 deletions(-)

diff --git a/be/src/vec/functions/functions_comparison.h b/be/src/vec/functions/functions_comparison.h
index 99070c29ecfd3b..8a6e1025d7cc1a 100644
--- a/be/src/vec/functions/functions_comparison.h
+++ b/be/src/vec/functions/functions_comparison.h
@@ -126,70 +126,6 @@ struct GenericComparisonImpl {
     }
 };
 
-#if USE_EMBEDDED_COMPILER
-
-template <template <typename, typename> typename Op>
-struct CompileOp;
-
-template <>
-struct CompileOp<EqualsOp> {
-    static llvm::Value* compile(llvm::IRBuilder<>& b, llvm::Value* x, llvm::Value* y,
-                                bool /*is_signed*/) {
-        return x->getType()->is_integer_ty() ? b.CreateICmpEQ(x, y)
-                                             : b.CreateFCmpOEQ(x, y); /// qNaNs always compare false
-    }
-};
-
-template <>
-struct CompileOp<NotEqualsOp> {
-    static llvm::Value* compile(llvm::IRBuilder<>& b, llvm::Value* x, llvm::Value* y,
-                                bool /*is_signed*/) {
-        return x->getType()->is_integer_ty() ? b.CreateICmpNE(x, y) : b.CreateFCmpONE(x, y);
-    }
-};
-
-template <>
-struct CompileOp<LessOp> {
-    static llvm::Value* compile(llvm::IRBuilder<>& b, llvm::Value* x, llvm::Value* y,
-                                bool is_signed) {
-        return x->getType()->is_integer_ty()
-                       ? (is_signed ? b.CreateICmpSLT(x, y) : b.CreateICmpULT(x, y))
-                       : b.CreateFCmpOLT(x, y);
-    }
-};
-
-template <>
-struct CompileOp<GreaterOp> {
-    static llvm::Value* compile(llvm::IRBuilder<>& b, llvm::Value* x, llvm::Value* y,
-                                bool is_signed) {
-        return x->getType()->is_integer_ty()
-                       ? (is_signed ? b.CreateICmpSGT(x, y) : b.CreateICmpUGT(x, y))
-                       : b.CreateFCmpOGT(x, y);
-    }
-};
-
-template <>
-struct CompileOp<LessOrEqualsOp> {
-    static llvm::Value* compile(llvm::IRBuilder<>& b, llvm::Value* x, llvm::Value* y,
-                                bool is_signed) {
-        return x->getType()->is_integer_ty()
-                       ? (is_signed ? b.CreateICmpSLE(x, y) : b.CreateICmpULE(x, y))
-                       : b.CreateFCmpOLE(x, y);
-    }
-};
-
-template <>
-struct CompileOp<GreaterOrEqualsOp> {
-    static llvm::Value* compile(llvm::IRBuilder<>& b, llvm::Value* x, llvm::Value* y,
-                                bool is_signed) {
-        return x->getType()->is_integer_ty()
-                       ? (is_signed ? b.CreateICmpSGE(x, y) : b.CreateICmpUGE(x, y))
-                       : b.CreateFCmpOGE(x, y);
-    }
-};
-
-#endif
-
 struct NameEquals {
     static constexpr auto name = "eq";
 };
diff --git a/be/src/vec/functions/modulo.cpp b/be/src/vec/functions/modulo.cpp
index e0d2e6dd7d4336..8fbfb8bb7f9804 100644
--- a/be/src/vec/functions/modulo.cpp
+++ b/be/src/vec/functions/modulo.cpp
@@ -52,10 +52,32 @@ struct ModuloImpl {
         null_map[index] = b == DecimalV2Value(0);
         return a % (b + DecimalV2Value(b == DecimalV2Value(0)));
     }
+};
 
-#if USE_EMBEDDED_COMPILER
-    static constexpr bool compilable = false; /// don't know how to throw from LLVM IR
-#endif
+template <typename A, typename B>
+struct PModuloImpl {
+    using ResultType = typename NumberTraits::ResultOfModulo<A, B>::Type;
+
+    template <typename Result = ResultType>
+    static inline Result apply(A a, B b, NullMap& null_map, size_t index) {
+        if constexpr (std::is_floating_point_v<Result>) {
+            null_map[index] = 0;
+            return std::fmod(std::fmod((double)a, (double)b) + (double)b, (double)b);
+        } else {
+            null_map[index] = b == 0;
+            return (typename NumberTraits::ToInteger<A>::Type(a) %
+                            (typename NumberTraits::ToInteger<B>::Type(b) + (b == 0)) +
+                    typename NumberTraits::ToInteger<B>::Type(b)) %
+                   (typename NumberTraits::ToInteger<B>::Type(b) + (b == 0));
+        }
+    }
+
+    static inline DecimalV2Value apply(DecimalV2Value a, DecimalV2Value b, NullMap& null_map,
+                                       size_t index) {
+        null_map[index] = b == DecimalV2Value(0);
+        return (a % (b + DecimalV2Value(b == DecimalV2Value(0))) + b) %
+               (b + DecimalV2Value(b == DecimalV2Value(0)));
+    }
 };
 
 template <typename A, typename B>
@@ -151,10 +173,16 @@ struct BinaryOperationImpl<Int32, Int64, ModuloImpl<Int32, Int64>>
 struct NameModulo {
     static constexpr auto name = "mod";
 };
+struct NamePModulo {
+    static constexpr auto name = "pmod";
+};
+
 using FunctionModulo = FunctionBinaryArithmeticToNullType<ModuloImpl, NameModulo, false>;
+using FunctionPModulo = FunctionBinaryArithmeticToNullType<PModuloImpl, NamePModulo, false>;
 
 void register_function_modulo(SimpleFunctionFactory& factory) {
     factory.register_function<FunctionModulo>();
+    factory.register_function<FunctionPModulo>();
 }
 
 } // namespace doris::vectorized
diff --git a/gensrc/script/doris_builtins_functions.py b/gensrc/script/doris_builtins_functions.py
index 1ce3395beb56b4..b82925fae195b2 100755
--- a/gensrc/script/doris_builtins_functions.py
+++ b/gensrc/script/doris_builtins_functions.py
@@ -637,10 +637,10 @@
 
     [['pmod'], 'BIGINT', ['BIGINT', 'BIGINT'],
             '_ZN5doris13MathFunctions11pmod_bigintEPN9doris_udf'
-            '15FunctionContextERKNS1_9BigIntValES6_', '', '', '', 'ALWAYS_NULLABLE'],
+            '15FunctionContextERKNS1_9BigIntValES6_', '', '', 'vec', 'ALWAYS_NULLABLE'],
     [['pmod'], 'DOUBLE', ['DOUBLE', 'DOUBLE'],
             '_ZN5doris13MathFunctions11pmod_doubleEPN9doris_udf'
-            '15FunctionContextERKNS1_9DoubleValES6_', '', '', '', 'ALWAYS_NULLABLE'],
+            '15FunctionContextERKNS1_9DoubleValES6_', '', '', 'vec', 'ALWAYS_NULLABLE'],
     [['mod'], 'TINYINT', ['TINYINT', 'TINYINT'],
             '_ZN5doris9Operators29mod_tiny_int_val_tiny_int_valEPN9doris_udf'
             '15FunctionContextERKNS1_10TinyIntValES6_', '', '', '', 'ALWAYS_NULLABLE'],

From 270e209312282528d99f3111911773c74010420d Mon Sep 17 00:00:00 2001
From: BiteTheDDDDt <952130278@qq.com>
Date: Tue, 8 Feb 2022 13:53:50 +0800
Subject: [PATCH 2/3] add pmod document

---
 docs/.vuepress/sidebar/en.js                  |  5 +-
 docs/.vuepress/sidebar/zh-CN.js               |  5 +-
 .../sql-functions/math-functions/pmod.md      | 54 ++++++++++++++++
 .../sql-functions/math-functions/pmod.md      | 61 +++++++++++++++++++
 4 files changed, 123 insertions(+), 2 deletions(-)
 create mode 100644 docs/en/sql-reference/sql-functions/math-functions/pmod.md
 create mode 100644 docs/zh-CN/sql-reference/sql-functions/math-functions/pmod.md

diff --git a/docs/.vuepress/sidebar/en.js b/docs/.vuepress/sidebar/en.js
index d03014c3434429..3b2605f6b2fa7c 100644
--- a/docs/.vuepress/sidebar/en.js
+++ b/docs/.vuepress/sidebar/en.js
@@ -475,7 +475,10 @@ module.exports = [
           {
             title: "Math Functions",
             directoryPath: "math-functions/",
-            children: ["conv"],
+            children: [
+              "conv",
+              "pmod"
+            ],
           },
           {
             title: "table functions",
diff --git a/docs/.vuepress/sidebar/zh-CN.js b/docs/.vuepress/sidebar/zh-CN.js
index 8a6903eda2bb4f..d24f406c5e4e4f 100644
--- a/docs/.vuepress/sidebar/zh-CN.js
+++ b/docs/.vuepress/sidebar/zh-CN.js
@@ -467,7 +467,10 @@ module.exports = [
           {
             title: "数学函数",
             directoryPath: "math-functions/",
-            children: ["conv"],
+            children: [
+              "conv",
+              "pmod"
+            ],
           },
           {
             title: "加密和信息摘要函数",
diff --git a/docs/en/sql-reference/sql-functions/math-functions/pmod.md b/docs/en/sql-reference/sql-functions/math-functions/pmod.md
new file mode 100644
index 00000000000000..a9693a03c8e135
--- /dev/null
+++ b/docs/en/sql-reference/sql-functions/math-functions/pmod.md
@@ -0,0 +1,54 @@
+---
+{
+    "title": "pmod",
+    "language": "en"
+}
+---
+
+<!-- 
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+  http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# pmod
+
+## description
+### Syntax
+
+`BIGINT PMOD(BIGINT x, BIGINT y)`
+`DOUBLE PMOD(DOUBLE x, DOUBLE y)`
+Returns the positive result of x mod y in the residue systems.
+Formally, return `(x%y+y)%y`.
+
+## example
+
+```
+MySQL [test]> SELECT PMOD(13,5);
++-------------+
+| pmod(13, 5) |
++-------------+
+|           3 |
++-------------+
+
+MySQL [test]> SELECT PMOD(-13,5);
++-------------+
+| pmod(-13, 5) |
++-------------+
+|           2 |
++-------------+
+```
+
+## keyword
+	PMOD
diff --git a/docs/zh-CN/sql-reference/sql-functions/math-functions/pmod.md b/docs/zh-CN/sql-reference/sql-functions/math-functions/pmod.md
new file mode 100644
index 00000000000000..a3aeaaf64d4743
--- /dev/null
+++ b/docs/zh-CN/sql-reference/sql-functions/math-functions/pmod.md
@@ -0,0 +1,61 @@
+---
+{
+    "title": "pmod",
+    "language": "zh-CN"
+}
+---
+
+<!-- 
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+  http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# pmod
+
+## description
+### Syntax
+
+`BIGINT PMOD(BIGINT x, BIGINT y)`
+`DOUBLE PMOD(DOUBLE x, DOUBLE y)`
+返回在模系下`x mod y`的最小正数解.
+具体地来说, 返回 `(x%y+y)%y`.
+
+## example
+
+```
+MySQL [test]> SELECT CONV(15,10,2);
++-----------------+
+| conv(15, 10, 2) |
++-----------------+
+| 1111            |
++-----------------+
+
+MySQL [test]> SELECT CONV('ff',16,10);
++--------------------+
+| conv('ff', 16, 10) |
++--------------------+
+| 255                |
++--------------------+
+
+MySQL [test]> SELECT CONV(230,10,16);
++-------------------+
+| conv(230, 10, 16) |
++-------------------+
+| E6                |
++-------------------+
+```
+
+## keyword
+	PMOD

From f596936eb500daed3201d91621e4c44695793903 Mon Sep 17 00:00:00 2001
From: BiteTheDDDDt <952130278@qq.com>
Date: Tue, 8 Feb 2022 13:59:30 +0800
Subject: [PATCH 3/3] fix pmod document

---
 .../sql-functions/math-functions/pmod.md      | 32 +++++++------------
 1 file changed, 12 insertions(+), 20 deletions(-)

diff --git a/docs/zh-CN/sql-reference/sql-functions/math-functions/pmod.md b/docs/zh-CN/sql-reference/sql-functions/math-functions/pmod.md
index a3aeaaf64d4743..d97968b9562672 100644
--- a/docs/zh-CN/sql-reference/sql-functions/math-functions/pmod.md
+++ b/docs/zh-CN/sql-reference/sql-functions/math-functions/pmod.md
@@ -35,26 +35,18 @@ under the License.
 ## example
 
 ```
-MySQL [test]> SELECT CONV(15,10,2);
-+-----------------+
-| conv(15, 10, 2) |
-+-----------------+
-| 1111            |
-+-----------------+
-
-MySQL [test]> SELECT CONV('ff',16,10);
-+--------------------+
-| conv('ff', 16, 10) |
-+--------------------+
-| 255                |
-+--------------------+
-
-MySQL [test]> SELECT CONV(230,10,16);
-+-------------------+
-| conv(230, 10, 16) |
-+-------------------+
-| E6                |
-+-------------------+
+MySQL [test]> SELECT PMOD(13,5);
++-------------+
+| pmod(13, 5) |
++-------------+
+|           3 |
++-------------+
+MySQL [test]> SELECT PMOD(-13,5);
++-------------+
+| pmod(-13, 5) |
++-------------+
+|           2 |
++-------------+
 ```
 
 ## keyword