From 088434a8ec42aef4b5d0d114c9850db819f17059 Mon Sep 17 00:00:00 2001 From: morrySnow Date: Wed, 18 May 2022 16:47:19 +0800 Subject: [PATCH 1/2] [style](fe) code correct rules and name rules --- build-support/IntelliJ-code-format.xml | 2 +- fe/check/checkstyle/checkstyle.xml | 40 ++- .../apache/doris/common/io/BitmapValue.java | 34 +- .../org/apache/doris/common/io/Codec.java | 4 +- .../common/io/FastByteArrayInputStream.java | 3 +- .../java/org/apache/doris/common/io/Hll.java | 28 +- .../java/org/apache/doris/common/io/Text.java | 16 +- .../doris/common/io/BitmapValueTest.java | 122 ++++---- .../org/apache/doris/common/io/HllTest.java | 2 +- .../org/apache/doris/alter/AlterHandler.java | 4 +- .../doris/alter/MaterializedViewHandler.java | 3 +- .../apache/doris/analysis/AggregateInfo.java | 288 +++++++++-------- .../doris/analysis/AggregateInfoBase.java | 88 +++--- .../apache/doris/analysis/AnalyticExpr.java | 9 +- .../apache/doris/analysis/AnalyticInfo.java | 86 ++--- .../apache/doris/analysis/AnalyticWindow.java | 181 ++++++----- .../org/apache/doris/analysis/Analyzer.java | 160 ++++++---- .../apache/doris/analysis/ArithmeticExpr.java | 1 + .../apache/doris/analysis/BaseTableRef.java | 6 +- .../doris/analysis/BetweenPredicate.java | 15 + .../doris/analysis/BinaryPredicate.java | 31 +- .../apache/doris/analysis/BoolLiteral.java | 15 + .../analysis/BuiltinAggregateFunction.java | 20 +- .../org/apache/doris/analysis/CaseExpr.java | 6 + .../org/apache/doris/analysis/CastExpr.java | 5 + .../org/apache/doris/analysis/ColumnDef.java | 1 + .../doris/analysis/CompoundPredicate.java | 6 +- .../apache/doris/analysis/DateLiteral.java | 31 +- .../doris/analysis/DescriptorTable.java | 14 +- .../java/org/apache/doris/analysis/Expr.java | 92 ++++-- .../org/apache/doris/analysis/ExprId.java | 4 +- .../doris/analysis/ExprSubstitutionMap.java | 100 +++--- .../doris/analysis/ExpressionFunctions.java | 6 +- .../org/apache/doris/analysis/FromClause.java | 68 ++-- .../doris/analysis/FunctionCallExpr.java | 8 +- .../apache/doris/analysis/FunctionName.java | 86 ++--- .../apache/doris/analysis/GroupByClause.java | 8 +- .../apache/doris/analysis/InPredicate.java | 8 +- .../apache/doris/analysis/InlineViewRef.java | 16 +- .../doris/analysis/IsNullPredicate.java | 4 +- .../apache/doris/analysis/LimitElement.java | 4 +- .../apache/doris/analysis/OutFileClause.java | 5 +- .../org/apache/doris/analysis/QueryStmt.java | 55 ++-- .../org/apache/doris/analysis/SelectStmt.java | 120 +++---- .../doris/analysis/SetOperationStmt.java | 174 ++++++---- .../doris/analysis/ShowStreamLoadStmt.java | 8 +- .../apache/doris/analysis/SlotDescriptor.java | 44 ++- .../org/apache/doris/analysis/SlotId.java | 4 +- .../org/apache/doris/analysis/SlotRef.java | 4 +- .../org/apache/doris/analysis/SortInfo.java | 88 +++--- .../apache/doris/analysis/StatementBase.java | 8 +- .../apache/doris/analysis/StmtRewriter.java | 20 +- .../org/apache/doris/analysis/Subquery.java | 12 +- .../org/apache/doris/analysis/TableRef.java | 64 ++-- .../doris/analysis/TupleDescriptor.java | 26 +- .../org/apache/doris/analysis/TupleId.java | 4 +- .../doris/analysis/TupleIsNullPredicate.java | 9 +- .../apache/doris/analysis/UserIdentity.java | 8 +- .../org/apache/doris/analysis/WithClause.java | 30 +- .../{HDFSStorage.java => HdfsStorage.java} | 2 +- .../apache/doris/catalog/AggregateType.java | 14 +- .../apache/doris/catalog/AliasFunction.java | 2 + .../org/apache/doris/catalog/ArrayType.java | 7 + .../org/apache/doris/catalog/Catalog.java | 9 +- .../java/org/apache/doris/catalog/Column.java | 11 + .../org/apache/doris/catalog/ColumnStats.java | 14 +- .../apache/doris/catalog/DataProperty.java | 6 + .../org/apache/doris/catalog/Database.java | 6 + .../org/apache/doris/catalog/Function.java | 2 +- .../org/apache/doris/catalog/FunctionSet.java | 2 +- .../org/apache/doris/catalog/OdbcTable.java | 3 +- .../org/apache/doris/catalog/Partition.java | 1 + .../apache/doris/catalog/PartitionKey.java | 10 +- .../doris/catalog/ReplicaAllocation.java | 8 +- .../apache/doris/catalog/ResourceType.java | 3 +- .../apache/doris/catalog/ScalarFunction.java | 8 +- .../java/org/apache/doris/catalog/Type.java | 56 +++- .../java/org/apache/doris/catalog/View.java | 20 +- .../clone/DynamicPartitionScheduler.java | 2 +- .../TwoDimensionalGreedyRebalanceAlgo.java | 14 +- .../org/apache/doris/common/IdGenerator.java | 2 +- .../common/ThriftServerEventProcessor.java | 3 +- .../org/apache/doris/common/TreeNode.java | 50 ++- ...ProcDir.java => BdbjeDatabaseProcDir.java} | 6 +- ...ode.java => BdbjeJournalDataProcNode.java} | 4 +- .../{BDBJEProcDir.java => BdbjeProcDir.java} | 4 +- .../apache/doris/common/proc/ProcService.java | 2 +- .../common/proc/TabletHealthProcDir.java | 2 +- .../doris/common/util/ReflectionUtils.java | 4 +- .../org/apache/doris/common/util/Util.java | 4 +- .../external/elasticsearch/EsNodeInfo.java | 8 +- .../doris/ha/{BDBHA.java => BdbHA.java} | 6 +- .../httpv2/controller/HelpController.java | 12 +- .../httpv2/rest/TableQueryPlanAction.java | 14 +- .../doris/httpv2/rest/manager/NodeAction.java | 6 +- .../apache/doris/httpv2/util/HttpUtil.java | 3 +- .../doris/httpv2/util/LoadSubmitter.java | 34 +- .../doris/httpv2/util/StatementSubmitter.java | 4 +- .../doris/journal/bdbje/BDBEnvironment.java | 4 +- .../{BDBJEJournal.java => BdbjeJournal.java} | 6 +- .../apache/doris/ldap/LdapPrivsChecker.java | 12 +- .../org/apache/doris/load/LoadErrorHub.java | 1 + .../doris/load/StreamLoadRecordMgr.java | 18 +- .../doris/load/loadv2/SparkRepository.java | 8 +- .../load/routineload/RoutineLoadManager.java | 6 +- .../doris/load/sync/SyncChannelHandle.java | 2 +- .../org/apache/doris/load/sync/SyncJob.java | 2 +- .../load/sync/canal/CanalDestination.java | 4 +- .../doris/load/sync/canal/CanalSyncJob.java | 2 + .../doris/load/update/UpdatePlanner.java | 8 +- .../doris/monitor/jvm/JvmPauseMonitor.java | 38 ++- .../apache/doris/monitor/jvm/JvmStats.java | 4 +- .../doris/monitor/unit/ByteSizeUnit.java | 40 +-- .../apache/doris/monitor/unit/TimeValue.java | 8 +- .../doris/mysql/nio/AcceptListener.java | 4 +- .../apache/doris/mysql/nio/NMysqlChannel.java | 2 +- .../apache/doris/mysql/nio/NMysqlServer.java | 2 +- .../apache/doris/mysql/nio/ReadListener.java | 2 +- .../doris/mysql/privilege/PaloAuth.java | 2 +- .../nereids/parser/LogicalPlanBuilder.java | 1 - .../trees/expressions/BinaryExpression.java | 1 - .../apache/doris/persist/AlterViewInfo.java | 4 +- .../doris/persist/ColocatePersistInfo.java | 6 + .../apache/doris/persist/CreateTableInfo.java | 6 + .../org/apache/doris/persist/EditLog.java | 4 +- .../apache/doris/persist/OperationType.java | 2 +- .../apache/doris/planner/AggregationNode.java | 6 +- .../apache/doris/planner/AnalyticPlanner.java | 12 +- .../apache/doris/planner/BrokerScanNode.java | 25 +- .../org/apache/doris/planner/ColumnBound.java | 8 +- .../apache/doris/planner/CrossJoinNode.java | 6 +- .../org/apache/doris/planner/DataSink.java | 6 +- .../doris/planner/DistributedPlanner.java | 127 ++++---- .../apache/doris/planner/EmptySetNode.java | 4 +- .../apache/doris/planner/ExchangeNode.java | 4 +- .../apache/doris/planner/HashJoinNode.java | 24 +- .../doris/planner/ListPartitionPrunerV2.java | 8 +- .../planner/MaterializedViewSelector.java | 8 +- .../apache/doris/planner/PlanFragment.java | 16 +- .../apache/doris/planner/PlanFragmentId.java | 4 +- .../org/apache/doris/planner/PlanNode.java | 16 +- .../org/apache/doris/planner/PlanNodeId.java | 4 +- .../apache/doris/planner/PlannerContext.java | 32 +- .../doris/planner/RangePartitionPrunerV2.java | 8 +- .../apache/doris/planner/ResultFileSink.java | 6 +- .../apache/doris/planner/RuntimeFilter.java | 55 +++- .../doris/planner/RuntimeFilterGenerator.java | 40 ++- .../apache/doris/planner/RuntimeFilterId.java | 4 +- .../org/apache/doris/planner/ScanNode.java | 1 + .../doris/planner/SetOperationNode.java | 121 +++---- .../org/apache/doris/qe/AuditLogBuilder.java | 10 +- .../org/apache/doris/qe/QeProcessorImpl.java | 7 +- .../apache/doris/qe/QueryStateException.java | 2 +- .../org/apache/doris/qe/StmtExecutor.java | 4 +- .../apache/doris/qe/cache/CacheAnalyzer.java | 4 +- .../doris/qe/cache/CacheCoordinator.java | 4 +- .../org/apache/doris/qe/cache/CacheProxy.java | 8 +- .../apache/doris/qe/cache/PartitionRange.java | 4 +- .../doris/qe/cache/RowBatchBuilder.java | 6 +- .../java/org/apache/doris/resource/Tag.java | 4 +- .../doris/rewrite/BetweenToCompoundRule.java | 4 +- .../rewrite/CompoundPredicateWriteRule.java | 36 ++- .../apache/doris/rewrite/ExprRewriter.java | 46 +-- .../NormalizeBinaryPredicatesRule.java | 12 +- .../rewrite/RewriteBinaryPredicatesRule.java | 4 +- .../doris/rewrite/RewriteDateLiteralRule.java | 4 +- .../apache/doris/service/FrontendOptions.java | 8 +- .../doris/statistics/BaseStatsDerive.java | 4 +- .../doris/statistics/DeriveFactory.java | 8 +- .../java/org/apache/doris/system/Backend.java | 6 + .../doris/task/UpdateTabletMetaInfoTask.java | 2 + .../org/apache/doris/alter/AlterTest.java | 36 +-- .../apache/doris/alter/RollupJobV2Test.java | 9 +- .../doris/analysis/AdminShowReplicaTest.java | 4 +- .../analysis/CreateDataSyncJobStmtTest.java | 7 +- .../CreateMaterializedViewStmtTest.java | 7 +- .../doris/analysis/DateLiteralTest.java | 2 +- .../TableNameComparedLowercaseTest.java | 4 +- .../TableNameStoredLowercaseTest.java | 4 +- .../apache/doris/backup/BackupJobTest.java | 6 +- .../doris/catalog/CreateTableLikeTest.java | 296 ++++++++---------- .../apache/doris/catalog/DatabaseTest.java | 2 +- .../catalog/DynamicPartitionTableTest.java | 2 +- .../org/apache/doris/catalog/FakeEditLog.java | 2 +- .../apache/doris/clone/DiskRebalanceTest.java | 2 +- .../org/apache/doris/clone/RebalanceTest.java | 2 +- .../clone/TabletRepairAndBalanceTest.java | 2 +- .../doris/clone/TabletReplicaTooSlowTest.java | 2 +- ...TwoDimensionalGreedyRebalanceAlgoTest.java | 12 +- .../common/{CIDRTest.java => CidrTest.java} | 2 +- .../apache/doris/common/GenericPoolTest.java | 10 +- .../load/loadv2/SparkRepositoryTest.java | 12 +- .../load/update/UpdateStmtExecutorTest.java | 10 +- .../doris/mysql/privilege/AuthTest.java | 2 + .../BatchModifyPartitionsInfoTest.java | 22 +- .../planner/MaterializedViewFunctionTest.java | 210 ++++++------- .../org/apache/doris/planner/PlannerTest.java | 4 +- .../doris/planner/ResourceTagQueryTest.java | 2 +- .../planner/RuntimeFilterGeneratorTest.java | 10 +- .../doris/planner/UpdatePlannerTest.java | 36 +-- .../org/apache/doris/qe/CoordinatorTest.java | 24 +- .../apache/doris/qe/PartitionCacheTest.java | 14 +- .../apache/doris/qe/QueryDetailQueueTest.java | 12 +- .../apache/doris/service/ExecuteEnvTest.java | 8 +- .../DatabaseTransactionMgrTest.java | 12 +- .../FakeTransactionIDGenerator.java | 2 +- .../apache/doris/utframe/AnotherDemoTest.java | 2 +- .../doris/utframe/DemoMultiBackendsTest.java | 2 +- .../doris/utframe/MockedBackendFactory.java | 12 +- .../doris/utframe/TestWithFeService.java | 48 +-- .../apache/doris/utframe/UtFrameUtils.java | 48 +-- .../org/apache/doris/udf/UdfExecutor.java | 266 ++++++++-------- .../doris/load/loadv2/dpp/DppColumns.java | 8 +- .../doris/load/loadv2/dpp/SparkDpp.java | 2 + 214 files changed, 2711 insertions(+), 2077 deletions(-) rename fe/fe-core/src/main/java/org/apache/doris/backup/{HDFSStorage.java => HdfsStorage.java} (97%) rename fe/fe-core/src/main/java/org/apache/doris/common/proc/{BDBJEDatabaseProcDir.java => BdbjeDatabaseProcDir.java} (92%) rename fe/fe-core/src/main/java/org/apache/doris/common/proc/{BDBJEJournalDataProcNode.java => BdbjeJournalDataProcNode.java} (94%) rename fe/fe-core/src/main/java/org/apache/doris/common/proc/{BDBJEProcDir.java => BdbjeProcDir.java} (95%) rename fe/fe-core/src/main/java/org/apache/doris/ha/{BDBHA.java => BdbHA.java} (98%) rename fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/{BDBJEJournal.java => BdbjeJournal.java} (99%) rename fe/fe-core/src/test/java/org/apache/doris/common/{CIDRTest.java => CidrTest.java} (99%) diff --git a/build-support/IntelliJ-code-format.xml b/build-support/IntelliJ-code-format.xml index 04c4e7a681e68b..eea3822f66ef32 100644 --- a/build-support/IntelliJ-code-format.xml +++ b/build-support/IntelliJ-code-format.xml @@ -66,6 +66,7 @@ under the License.