From 90993d961928759f12efa0b6a02e9f562ae1ec07 Mon Sep 17 00:00:00 2001 From: Vadim Ogievetsky Date: Sun, 24 Jan 2021 12:32:49 -0800 Subject: [PATCH 1/2] Remove first / last suggestions --- web-console/src/druid-models/metric-spec.tsx | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/web-console/src/druid-models/metric-spec.tsx b/web-console/src/druid-models/metric-spec.tsx index fd1282fe7702..e1afeb982d96 100644 --- a/web-console/src/druid-models/metric-spec.tsx +++ b/web-console/src/druid-models/metric-spec.tsx @@ -67,14 +67,17 @@ export const METRIC_SPEC_FIELDS: Field[] = [ group: 'max', suggestions: ['longMax', 'doubleMax', 'floatMax'], }, - { - group: 'first', - suggestions: ['longFirst', 'doubleFirst', 'floatFirst'], - }, - { - group: 'last', - suggestions: ['longLast', 'doubleLast', 'floatLast'], - }, + // Do not show first and last aggregators as they can not be used in ingestion specs and this definition is only used in the data loader. + // Ref: https://druid.apache.org/docs/latest/querying/aggregations.html#first--last-aggregator + // Should the first / last aggregators become usable at ingestion time, comment in the lines below: + // { + // group: 'first', + // suggestions: ['longFirst', 'doubleFirst', 'floatFirst'], + // }, + // { + // group: 'last', + // suggestions: ['longLast', 'doubleLast', 'floatLast'], + // }, 'thetaSketch', { group: 'HLLSketch', From d0db4bfe5f7020ee36384adcc4ed1a66e9f3cc8d Mon Sep 17 00:00:00 2001 From: Vadim Ogievetsky Date: Mon, 25 Jan 2021 10:32:12 -0800 Subject: [PATCH 2/2] remove commened out code --- web-console/src/druid-models/metric-spec.tsx | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/web-console/src/druid-models/metric-spec.tsx b/web-console/src/druid-models/metric-spec.tsx index e1afeb982d96..e72d114cff35 100644 --- a/web-console/src/druid-models/metric-spec.tsx +++ b/web-console/src/druid-models/metric-spec.tsx @@ -69,15 +69,8 @@ export const METRIC_SPEC_FIELDS: Field[] = [ }, // Do not show first and last aggregators as they can not be used in ingestion specs and this definition is only used in the data loader. // Ref: https://druid.apache.org/docs/latest/querying/aggregations.html#first--last-aggregator - // Should the first / last aggregators become usable at ingestion time, comment in the lines below: - // { - // group: 'first', - // suggestions: ['longFirst', 'doubleFirst', 'floatFirst'], - // }, - // { - // group: 'last', - // suggestions: ['longLast', 'doubleLast', 'floatLast'], - // }, + // Should the first / last aggregators become usable at ingestion time, reverse the changes made in: + // https://github.com/apache/druid/pull/10794 'thetaSketch', { group: 'HLLSketch',