diff --git a/web-console/src/dialogs/lookup-edit-dialog/__snapshots__/lookup-edit-dialog.spec.tsx.snap b/web-console/src/dialogs/lookup-edit-dialog/__snapshots__/lookup-edit-dialog.spec.tsx.snap index e5056501c0cd..14d7d58fbb1f 100644 --- a/web-console/src/dialogs/lookup-edit-dialog/__snapshots__/lookup-edit-dialog.spec.tsx.snap +++ b/web-console/src/dialogs/lookup-edit-dialog/__snapshots__/lookup-edit-dialog.spec.tsx.snap @@ -223,25 +223,6 @@ exports[`LookupEditDialog matches snapshot 1`] = ` "name": "extractionNamespace.pollPeriod", "type": "string", }, - Object { - "defined": [Function], - "info": -

- The namespace value in the SQL query: -

-

- SELECT keyColumn, valueColumn, tsColumn? FROM - - namespace - - .table WHERE filter -

-
, - "name": "extractionNamespace.namespace", - "placeholder": "some_lookup", - "required": true, - "type": "string", - }, Object { "defined": [Function], "info": "Defines the connectURI value on the The connector config to used", diff --git a/web-console/src/druid-models/lookup-spec.spec.ts b/web-console/src/druid-models/lookup-spec.spec.ts index 0978f7cf97c2..689b680a6353 100644 --- a/web-console/src/druid-models/lookup-spec.spec.ts +++ b/web-console/src/druid-models/lookup-spec.spec.ts @@ -235,36 +235,12 @@ describe('lookup-spec', () => { }); describe('ExtractionNamespace type JDBC', () => { - it('No namespace', () => { - expect( - isLookupInvalid('lookup', 'v1', '__default', { - type: 'cachedNamespace', - extractionNamespace: { - type: 'jdbc', - namespace: undefined, - connectorConfig: { - createTables: true, - connectURI: 'jdbc:mysql://localhost:3306/druid', - user: 'druid', - password: 'diurd', - }, - table: 'some_lookup_table', - keyColumn: 'the_old_dim_value', - valueColumn: 'the_new_dim_value', - tsColumn: 'timestamp_column', - pollPeriod: 600000, - }, - }), - ).toBe(true); - }); - it('No connectorConfig', () => { expect( isLookupInvalid('lookup', 'v1', '__default', { type: 'cachedNamespace', extractionNamespace: { type: 'jdbc', - namespace: 'some_lookup', connectorConfig: undefined, table: 'some_lookup_table', keyColumn: 'the_old_dim_value', @@ -282,7 +258,6 @@ describe('lookup-spec', () => { type: 'cachedNamespace', extractionNamespace: { type: 'jdbc', - namespace: 'some_lookup', connectorConfig: { createTables: true, connectURI: 'jdbc:mysql://localhost:3306/druid', @@ -305,7 +280,6 @@ describe('lookup-spec', () => { type: 'cachedNamespace', extractionNamespace: { type: 'jdbc', - namespace: 'some_lookup', connectorConfig: { createTables: true, connectURI: 'jdbc:mysql://localhost:3306/druid', @@ -322,13 +296,12 @@ describe('lookup-spec', () => { ).toBe(true); }); - it('No keyColumn', () => { + it('No valueColumn', () => { expect( isLookupInvalid('lookup', 'v1', '__default', { type: 'cachedNamespace', extractionNamespace: { type: 'jdbc', - namespace: 'some_lookup', connectorConfig: { createTables: true, connectURI: 'jdbc:mysql://localhost:3306/druid', @@ -428,13 +401,12 @@ describe('lookup-spec', () => { }); describe('ExtractionNamespace type JDBC', () => { - it('No namespace', () => { + it('All good', () => { expect( isLookupInvalid('lookup', 'v1', '__default', { type: 'cachedNamespace', extractionNamespace: { type: 'jdbc', - namespace: 'lookup', connectorConfig: { createTables: true, connectURI: 'jdbc:mysql://localhost:3306/druid', diff --git a/web-console/src/druid-models/lookup-spec.tsx b/web-console/src/druid-models/lookup-spec.tsx index 31405f311719..245d6a04b1eb 100644 --- a/web-console/src/druid-models/lookup-spec.tsx +++ b/web-console/src/druid-models/lookup-spec.tsx @@ -28,7 +28,6 @@ export interface ExtractionNamespaceSpec { uriPrefix?: string; fileRegex?: string; namespaceParseSpec?: NamespaceParseSpec; - namespace?: string; connectorConfig?: { createTables: boolean; connectURI: string; @@ -268,22 +267,6 @@ export const LOOKUP_FIELDS: Field[] = [ }, // JDBC stuff - { - name: 'extractionNamespace.namespace', - type: 'string', - placeholder: 'some_lookup', - defined: (model: LookupSpec) => deepGet(model, 'extractionNamespace.type') === 'jdbc', - required: true, - info: ( - <> -

The namespace value in the SQL query:

-

- SELECT keyColumn, valueColumn, tsColumn? FROM namespace.table WHERE - filter -

- - ), - }, { name: 'extractionNamespace.connectorConfig.connectURI', label: 'Connect URI',