From 61eb7497d90fd50848be4cb4ffefa0b3b7d78a9c Mon Sep 17 00:00:00 2001
From: Jihoon Son <jihoonson@apache.org>
Date: Sun, 28 Mar 2021 10:57:38 -0700
Subject: [PATCH] Add explicit EOF and use assert instead of exception

---
 core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4  | 2 ++
 .../apache/druid/sql/calcite/filtration/BottomUpTransform.java | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 b/core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4
index 9b9eda9dfded..166530265de4 100644
--- a/core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4
+++ b/core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4
@@ -15,6 +15,8 @@
 
 grammar Expr;
 
+start : expr EOF;
+
 expr : NULL                                                         # null
      | ('-'|'!') expr                                               # unaryOpExpr
      |<assoc=right> expr '^' expr                                   # powOpExpr
diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/filtration/BottomUpTransform.java b/sql/src/main/java/org/apache/druid/sql/calcite/filtration/BottomUpTransform.java
index 9aacde425ab4..f594878b2947 100644
--- a/sql/src/main/java/org/apache/druid/sql/calcite/filtration/BottomUpTransform.java
+++ b/sql/src/main/java/org/apache/druid/sql/calcite/filtration/BottomUpTransform.java
@@ -36,7 +36,8 @@ public abstract class BottomUpTransform implements Function<Filtration, Filtrati
   private DimFilter checkedProcess(final DimFilter filter)
   {
     final DimFilter retVal = process(Preconditions.checkNotNull(filter, "filter"));
-    return Preconditions.checkNotNull(retVal, "process(filter) result in %s", getClass().getSimpleName());
+    assert retVal != null;
+    return retVal;
   }
 
   @Override