From 7b6e1bf903644ac6f75dc4eaff092dd0858e5bec Mon Sep 17 00:00:00 2001 From: Soumyava Das Date: Mon, 18 Apr 2022 09:05:56 -0700 Subject: [PATCH 1/2] Updating an error msg --- .../java/org/apache/druid/sql/calcite/rel/DruidQuery.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java b/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java index a0627dfa4f18..e2955d6c67e5 100644 --- a/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java +++ b/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java @@ -1204,7 +1204,7 @@ private ScanQuery toScanQuery(final QueryFeatureInspector queryFeatureInspector) // Cannot handle this ordering. // Scan cannot ORDER BY non-time columns. plannerContext.setPlanningError( - "SQL query requires order by non-time column %s that is not supported.", + "SQL query requires order by non-time column [%s] that is not supported.", orderByColumns ); return null; @@ -1213,7 +1213,7 @@ private ScanQuery toScanQuery(final QueryFeatureInspector queryFeatureInspector) // Cannot handle this ordering. // Scan cannot ORDER BY non-time columns. plannerContext.setPlanningError( - "SQL query requires order by non-time column on a datasource[%s], which is not supported.", + "SQL query is a scan and requires order by on a datasource[%s], which is not supported.", dataSource ); return null; From 36b20112e620300b5a039f769f79a113e67b304c Mon Sep 17 00:00:00 2001 From: Soumyava Das Date: Tue, 19 Apr 2022 10:08:12 -0700 Subject: [PATCH 2/2] Added an extra [] so removing it --- .../main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java b/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java index e2955d6c67e5..cab3d74f42a5 100644 --- a/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java +++ b/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java @@ -1204,7 +1204,7 @@ private ScanQuery toScanQuery(final QueryFeatureInspector queryFeatureInspector) // Cannot handle this ordering. // Scan cannot ORDER BY non-time columns. plannerContext.setPlanningError( - "SQL query requires order by non-time column [%s] that is not supported.", + "SQL query requires order by non-time column %s that is not supported.", orderByColumns ); return null;