diff --git a/processing/src/main/java/org/apache/druid/annotations/SuppressFBWarnings.java b/processing/src/main/java/org/apache/druid/annotations/SuppressFBWarnings.java index fb1d5b1a126d..f3e899d871a4 100644 --- a/processing/src/main/java/org/apache/druid/annotations/SuppressFBWarnings.java +++ b/processing/src/main/java/org/apache/druid/annotations/SuppressFBWarnings.java @@ -25,6 +25,7 @@ /** * Annotation for suppressing spotbugs checks when necessary. */ +@SuppressWarnings("unused") @Retention(RetentionPolicy.CLASS) public @interface SuppressFBWarnings { diff --git a/processing/src/main/java/org/apache/druid/data/input/FirehoseFactory.java b/processing/src/main/java/org/apache/druid/data/input/FirehoseFactory.java index 986d1d94a5e4..5561dc933725 100644 --- a/processing/src/main/java/org/apache/druid/data/input/FirehoseFactory.java +++ b/processing/src/main/java/org/apache/druid/data/input/FirehoseFactory.java @@ -86,6 +86,7 @@ default Firehose connectForSampler(T parser, @Nullable File temporaryDirectory) return connect(parser, temporaryDirectory); } + @SuppressWarnings("unused") @JsonIgnore default boolean isSplittable() { diff --git a/processing/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java b/processing/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java index 35322c2a0fdf..ca74798e96fe 100644 --- a/processing/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java +++ b/processing/src/main/java/org/apache/druid/data/input/FirehoseFactoryToInputSourceAdaptor.java @@ -45,11 +45,6 @@ public FiniteFirehoseFactory getFirehoseFactory() return firehoseFactory; } - public InputRowParser getInputRowParser() - { - return inputRowParser; - } - @Override public boolean isSplittable() { diff --git a/processing/src/main/java/org/apache/druid/data/input/InputFormat.java b/processing/src/main/java/org/apache/druid/data/input/InputFormat.java index 4957bfb1e975..345b47ca3ee9 100644 --- a/processing/src/main/java/org/apache/druid/data/input/InputFormat.java +++ b/processing/src/main/java/org/apache/druid/data/input/InputFormat.java @@ -58,6 +58,7 @@ public interface InputFormat * This method is not being used anywhere for now, but should be considered * in {@link SplittableInputSource#createSplits} in the future. */ + @SuppressWarnings("unused") @JsonIgnore boolean isSplittable(); diff --git a/processing/src/main/java/org/apache/druid/indexer/TaskLocation.java b/processing/src/main/java/org/apache/druid/indexer/TaskLocation.java index 1cc83db4d82f..fe8accd33d33 100644 --- a/processing/src/main/java/org/apache/druid/indexer/TaskLocation.java +++ b/processing/src/main/java/org/apache/druid/indexer/TaskLocation.java @@ -21,7 +21,6 @@ import com.fasterxml.jackson.annotation.JsonCreator; import com.fasterxml.jackson.annotation.JsonProperty; -import com.google.common.net.HostAndPort; import org.apache.druid.java.util.common.IAE; import javax.annotation.Nullable; @@ -133,12 +132,4 @@ public int hashCode() { return Objects.hash(host, port, tlsPort); } - - public HostAndPort toHostAndPort() - { - if (tlsPort >= 0) { - return HostAndPort.fromParts(host, tlsPort); - } - return HostAndPort.fromParts(host, port); - } } diff --git a/processing/src/main/java/org/apache/druid/indexer/TaskMetricsGetter.java b/processing/src/main/java/org/apache/druid/indexer/TaskMetricsGetter.java index e51e626fce34..4498a3e56a6e 100644 --- a/processing/src/main/java/org/apache/druid/indexer/TaskMetricsGetter.java +++ b/processing/src/main/java/org/apache/druid/indexer/TaskMetricsGetter.java @@ -26,7 +26,10 @@ public interface TaskMetricsGetter { + @SuppressWarnings("unused") List getKeys(); + + @SuppressWarnings("unused") @Nullable Map getTotalMetrics(); } diff --git a/processing/src/main/java/org/apache/druid/java/util/common/DefineClassUtils.java b/processing/src/main/java/org/apache/druid/java/util/common/DefineClassUtils.java index dba354d12b78..604ef987394e 100644 --- a/processing/src/main/java/org/apache/druid/java/util/common/DefineClassUtils.java +++ b/processing/src/main/java/org/apache/druid/java/util/common/DefineClassUtils.java @@ -171,11 +171,6 @@ private static MethodHandle defineClassJava8(MethodHandles.Lookup lookup) throws return defineClass; } - static int getArrayLength(byte[] bytes) - { - return bytes.length; - } - public static Class defineClass( Class targetClass, byte[] byteCode, diff --git a/processing/src/main/java/org/apache/druid/java/util/common/HumanReadableBytesRange.java b/processing/src/main/java/org/apache/druid/java/util/common/HumanReadableBytesRange.java index 4d7fa37f78fd..644dae797d20 100644 --- a/processing/src/main/java/org/apache/druid/java/util/common/HumanReadableBytesRange.java +++ b/processing/src/main/java/org/apache/druid/java/util/common/HumanReadableBytesRange.java @@ -47,6 +47,7 @@ @Target({ElementType.METHOD, ElementType.FIELD, ElementType.ANNOTATION_TYPE, ElementType.CONSTRUCTOR, ElementType.PARAMETER}) @Retention(RetentionPolicy.RUNTIME) @Documented +@SuppressWarnings("unused") @Constraint(validatedBy = HumanReadableBytesRange.HumanReadableBytesRangeValidator.class) public @interface HumanReadableBytesRange { @@ -66,9 +67,11 @@ //ConstraintValidator requires String message() default "value must be in the range of [{min}, {max}]"; + //ConstraintValidator requires Class[] payload() default {}; + @SuppressWarnings("unused") class HumanReadableBytesRangeValidator implements ConstraintValidator { private HumanReadableBytesRange range; diff --git a/processing/src/main/java/org/apache/druid/java/util/common/Numbers.java b/processing/src/main/java/org/apache/druid/java/util/common/Numbers.java index d24d9799cca5..06c988e8af5b 100644 --- a/processing/src/main/java/org/apache/druid/java/util/common/Numbers.java +++ b/processing/src/main/java/org/apache/druid/java/util/common/Numbers.java @@ -200,21 +200,13 @@ public static Long parseLongObject(@Nullable String val) return lobj; } // try as a double, for "ddd.dd" , Longs.tryParse(..) returns null - Double dobj = Doubles.tryParse((String) val); + Double dobj = Doubles.tryParse(val); if (dobj != null) { return dobj.longValue(); } throw new NumberFormatException("Cannot parse string to long"); } - public static int toIntExact(long value, String error) - { - if ((int) value != value) { - throw new ArithmeticException(error); - } - return (int) value; - } - private Numbers() { } diff --git a/processing/src/main/java/org/apache/druid/java/util/common/StringUtils.java b/processing/src/main/java/org/apache/druid/java/util/common/StringUtils.java index d13098650193..e86d51b8d965 100644 --- a/processing/src/main/java/org/apache/druid/java/util/common/StringUtils.java +++ b/processing/src/main/java/org/apache/druid/java/util/common/StringUtils.java @@ -21,12 +21,10 @@ import com.google.common.base.Strings; import it.unimi.dsi.fastutil.bytes.ByteArrayList; -import it.unimi.dsi.fastutil.bytes.ByteList; import org.apache.commons.io.IOUtils; import javax.annotation.Nonnull; import javax.annotation.Nullable; - import java.io.IOException; import java.io.InputStream; import java.io.UnsupportedEncodingException; @@ -268,11 +266,6 @@ public static String fromUtf8(final ByteArrayList buffer) return StringUtils.fromUtf8(buffer.elements(), 0, buffer.size()); } - public static String fromUtf8(final ByteList buffer) - { - return StringUtils.fromUtf8(buffer.toByteArray()); - } - /** * If buffer is Decodes a UTF-8 string from the remaining bytes of a buffer. * Advances the position of the buffer by {@link ByteBuffer#remaining()}. diff --git a/processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java b/processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java index da7904240680..b0b3d1d726e2 100644 --- a/processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java +++ b/processing/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java @@ -93,7 +93,7 @@ public ParallelMergeCombiningSequence( BinaryOperator combineFn, boolean hasTimeout, long timeoutMillis, - int queryPriority, + @SuppressWarnings("unused") int queryPriority, int parallelism, int yieldAfter, int batchSize, diff --git a/processing/src/main/java/org/apache/druid/java/util/common/io/Closer.java b/processing/src/main/java/org/apache/druid/java/util/common/io/Closer.java index c843f29b714e..a366f6c3fa26 100644 --- a/processing/src/main/java/org/apache/druid/java/util/common/io/Closer.java +++ b/processing/src/main/java/org/apache/druid/java/util/common/io/Closer.java @@ -130,18 +130,6 @@ public C register(@Nullable C closeable) return closeable; } - /** - * Registers a list of {@code Closeable} to be closed when this {@code Closer} is - * {@linkplain #close closed}. - * - * @return the supplied list of {@code Closeable} - */ - public Iterable registerAll(Iterable closeables) - { - closeables.forEach(this::register); - return closeables; - } - /** * Stores the given throwable and rethrows it. It will be rethrown as is if it is an * {@code IOException}, {@code RuntimeException} or {@code Error}. Otherwise, it will be rethrown diff --git a/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java b/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java index 8306dcad9e60..07f1cd1fbaa1 100644 --- a/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java +++ b/processing/src/main/java/org/apache/druid/java/util/common/logger/Logger.java @@ -63,6 +63,7 @@ protected org.slf4j.Logger getSlf4jLogger() return log; } + @SuppressWarnings("unused") @Override public String toString() { diff --git a/processing/src/main/java/org/apache/druid/java/util/emitter/core/EventMap.java b/processing/src/main/java/org/apache/druid/java/util/emitter/core/EventMap.java index 5cf031b2dc37..50237eb02386 100644 --- a/processing/src/main/java/org/apache/druid/java/util/emitter/core/EventMap.java +++ b/processing/src/main/java/org/apache/druid/java/util/emitter/core/EventMap.java @@ -79,15 +79,6 @@ public Builder putNonNull(String key, Object value) return this; } - /** - * Adds map entry to the map - */ - public Builder put(Map.Entry entry) - { - map.put(entry.getKey(), entry.getValue()); - return this; - } - /** * Adds all key -> value pairs from other map */ diff --git a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/HttpEmitterFactory.java b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/HttpEmitterFactory.java index 53f5b7a9d687..e1811b8c90d2 100644 --- a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/HttpEmitterFactory.java +++ b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/HttpEmitterFactory.java @@ -26,9 +26,9 @@ import org.apache.druid.java.util.emitter.core.HttpPostEmitter; import org.asynchttpclient.AsyncHttpClient; +@SuppressWarnings("unused") public class HttpEmitterFactory extends HttpEmitterConfig implements EmitterFactory { - @Override public Emitter makeEmitter(ObjectMapper objectMapper, AsyncHttpClient httpClient, Lifecycle lifecycle) { diff --git a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/LoggingEmitterFactory.java b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/LoggingEmitterFactory.java index 897787bee939..f5dac9e909ac 100644 --- a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/LoggingEmitterFactory.java +++ b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/LoggingEmitterFactory.java @@ -26,12 +26,9 @@ import org.apache.druid.java.util.emitter.core.LoggingEmitterConfig; import org.asynchttpclient.AsyncHttpClient; +@SuppressWarnings("unused") public class LoggingEmitterFactory extends LoggingEmitterConfig implements EmitterFactory { - public LoggingEmitterFactory() - { - } - @Override public Emitter makeEmitter(ObjectMapper objectMapper, AsyncHttpClient httpClient, Lifecycle lifecycle) { diff --git a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/NoopEmitterFactory.java b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/NoopEmitterFactory.java index db9bf6035097..2067204d6cd9 100644 --- a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/NoopEmitterFactory.java +++ b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/NoopEmitterFactory.java @@ -25,6 +25,7 @@ import org.apache.druid.java.util.emitter.core.NoopEmitter; import org.asynchttpclient.AsyncHttpClient; +@SuppressWarnings("unused") public class NoopEmitterFactory implements EmitterFactory { @Override diff --git a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/ParametrizedUriEmitterFactory.java b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/ParametrizedUriEmitterFactory.java index 5f5670586eff..9bf8537597bf 100644 --- a/processing/src/main/java/org/apache/druid/java/util/emitter/factory/ParametrizedUriEmitterFactory.java +++ b/processing/src/main/java/org/apache/druid/java/util/emitter/factory/ParametrizedUriEmitterFactory.java @@ -26,9 +26,9 @@ import org.apache.druid.java.util.emitter.core.ParametrizedUriEmitterConfig; import org.asynchttpclient.AsyncHttpClient; +@SuppressWarnings("unused") public class ParametrizedUriEmitterFactory extends ParametrizedUriEmitterConfig implements EmitterFactory { - @Override public Emitter makeEmitter(ObjectMapper objectMapper, AsyncHttpClient httpClient, Lifecycle lifecycle) { diff --git a/processing/src/main/java/org/apache/druid/java/util/http/client/HttpClientProxyConfig.java b/processing/src/main/java/org/apache/druid/java/util/http/client/HttpClientProxyConfig.java index fec5c9e365fc..6a4a6dda8fed 100644 --- a/processing/src/main/java/org/apache/druid/java/util/http/client/HttpClientProxyConfig.java +++ b/processing/src/main/java/org/apache/druid/java/util/http/client/HttpClientProxyConfig.java @@ -40,6 +40,7 @@ public class HttpClientProxyConfig @JsonProperty("password") private String password; + @SuppressWarnings("unused") public HttpClientProxyConfig() { } diff --git a/processing/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java b/processing/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java index 27c2ed25123f..e7242eb29c79 100644 --- a/processing/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java +++ b/processing/src/main/java/org/apache/druid/java/util/http/client/response/FullResponseHolder.java @@ -49,5 +49,6 @@ public HttpResponse getResponse() /** * Get the data. */ + @SuppressWarnings("unused") public abstract T getContent(); } diff --git a/processing/src/main/java/org/apache/druid/java/util/metrics/AbstractMonitor.java b/processing/src/main/java/org/apache/druid/java/util/metrics/AbstractMonitor.java index 6e67bc0272e1..3fa5fc5c9c19 100644 --- a/processing/src/main/java/org/apache/druid/java/util/metrics/AbstractMonitor.java +++ b/processing/src/main/java/org/apache/druid/java/util/metrics/AbstractMonitor.java @@ -41,6 +41,7 @@ public void stop() started = false; } + @SuppressWarnings("unused") public boolean isStarted() { return started; diff --git a/processing/src/main/java/org/apache/druid/java/util/metrics/PidDiscoverer.java b/processing/src/main/java/org/apache/druid/java/util/metrics/PidDiscoverer.java index 7a2153105864..4744b4ae5750 100644 --- a/processing/src/main/java/org/apache/druid/java/util/metrics/PidDiscoverer.java +++ b/processing/src/main/java/org/apache/druid/java/util/metrics/PidDiscoverer.java @@ -21,5 +21,6 @@ public interface PidDiscoverer { + @SuppressWarnings("unused") long getPid(); } diff --git a/processing/src/main/java/org/apache/druid/java/util/metrics/ProcFsReader.java b/processing/src/main/java/org/apache/druid/java/util/metrics/ProcFsReader.java index 1a1ca08c7c60..e8425448f6ab 100644 --- a/processing/src/main/java/org/apache/druid/java/util/metrics/ProcFsReader.java +++ b/processing/src/main/java/org/apache/druid/java/util/metrics/ProcFsReader.java @@ -38,7 +38,6 @@ public class ProcFsReader private final File procDir; private static final Logger LOG = new Logger(ProcFsReader.class); - public static final Path DEFAULT_PROC_FS_ROOT = Paths.get("/proc/"); private static final String BOOT_ID_PATH = "sys/kernel/random/boot_id"; private static final String CPUINFO_PATH = "cpuinfo"; diff --git a/processing/src/main/java/org/apache/druid/math/expr/ExprEval.java b/processing/src/main/java/org/apache/druid/math/expr/ExprEval.java index dbfc11d3c4ee..f06618a23a5d 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/ExprEval.java +++ b/processing/src/main/java/org/apache/druid/math/expr/ExprEval.java @@ -1249,12 +1249,6 @@ public Expr toExpr() return new ArrayExpr(arrayType, value); } - @Nullable - public Object getIndex(int index) - { - return value == null ? null : value[index]; - } - protected boolean isScalar() { return value != null && value.length == 1; diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateDoubleFunctionVectorValueProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateDoubleFunctionVectorValueProcessor.java index 904feb5d7059..f23ee5aa38ff 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateDoubleFunctionVectorValueProcessor.java +++ b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateDoubleFunctionVectorValueProcessor.java @@ -34,7 +34,6 @@ public abstract class BivariateDoubleFunctionVectorValueProcessor left; final ExprVectorProcessor right; - final int maxVectorSize; final boolean[] outNulls; final double[] outValues; @@ -46,7 +45,6 @@ protected BivariateDoubleFunctionVectorValueProcessor( { this.left = left; this.right = right; - this.maxVectorSize = maxVectorSize; this.outValues = new double[maxVectorSize]; this.outNulls = new boolean[maxVectorSize]; } diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateFunctionVectorObjectProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateFunctionVectorObjectProcessor.java index 2f1279a6d2d5..2f7ae4f079bb 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateFunctionVectorObjectProcessor.java +++ b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateFunctionVectorObjectProcessor.java @@ -35,20 +35,17 @@ public abstract class BivariateFunctionVectorObjectProcessor left; final ExprVectorProcessor right; - final int maxVectorSize; final TOutput outValues; final boolean sqlCompatible = NullHandling.sqlCompatible(); protected BivariateFunctionVectorObjectProcessor( ExprVectorProcessor left, ExprVectorProcessor right, - int maxVectorSize, TOutput outValues ) { this.left = left; this.right = right; - this.maxVectorSize = maxVectorSize; this.outValues = outValues; } diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateLongFunctionVectorValueProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateLongFunctionVectorValueProcessor.java index 243b7ae79b5f..fb68317bec27 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateLongFunctionVectorValueProcessor.java +++ b/processing/src/main/java/org/apache/druid/math/expr/vector/BivariateLongFunctionVectorValueProcessor.java @@ -34,7 +34,6 @@ public abstract class BivariateLongFunctionVectorValueProcessor left; final ExprVectorProcessor right; - final int maxVectorSize; final boolean[] outNulls; final long[] outValues; @@ -46,7 +45,6 @@ protected BivariateLongFunctionVectorValueProcessor( { this.left = left; this.right = right; - this.maxVectorSize = maxVectorSize; this.outValues = new long[maxVectorSize]; this.outNulls = new boolean[maxVectorSize]; } diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectInFunctionVectorProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectInFunctionVectorProcessor.java index 8ae0c4d75198..7847d71ec224 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectInFunctionVectorProcessor.java +++ b/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectInFunctionVectorProcessor.java @@ -27,8 +27,6 @@ public abstract class LongOutObjectInFunctionVectorProcessor extends UnivariateFunctionVectorObjectProcessor { - final ExpressionType inputType; - public LongOutObjectInFunctionVectorProcessor( ExprVectorProcessor processor, int maxVectorSize, @@ -36,7 +34,6 @@ public LongOutObjectInFunctionVectorProcessor( ) { super(CastToTypeVectorProcessor.cast(processor, inputType), maxVectorSize, new long[maxVectorSize]); - this.inputType = inputType; } @Override diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectsInFunctionVectorProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectsInFunctionVectorProcessor.java index 88f2f0ff54b3..de34db9afd48 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectsInFunctionVectorProcessor.java +++ b/processing/src/main/java/org/apache/druid/math/expr/vector/LongOutObjectsInFunctionVectorProcessor.java @@ -38,7 +38,6 @@ protected LongOutObjectsInFunctionVectorProcessor( super( CastToTypeVectorProcessor.cast(left, inputType), CastToTypeVectorProcessor.cast(right, inputType), - maxVectorSize, new long[maxVectorSize] ); this.outNulls = new boolean[maxVectorSize]; diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutMultiObjectInVectorProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutMultiObjectInVectorProcessor.java index 2a58e3ea826f..0d668dc2900a 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutMultiObjectInVectorProcessor.java +++ b/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutMultiObjectInVectorProcessor.java @@ -28,7 +28,6 @@ public abstract class ObjectOutMultiObjectInVectorProcessor implements ExprVectorProcessor { final ExprVectorProcessor[] inputs; - final int maxVectorSize; final Object[] outValues; final ExpressionType expressionType; @@ -40,7 +39,6 @@ protected ObjectOutMultiObjectInVectorProcessor( ) { this.inputs = inputs; - this.maxVectorSize = maxVectorSize; this.outValues = new Object[maxVectorSize]; this.expressionType = objectType; } diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutObjectsInFunctionVectorProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutObjectsInFunctionVectorProcessor.java index 93089f5fc5e4..d64ffa384236 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutObjectsInFunctionVectorProcessor.java +++ b/processing/src/main/java/org/apache/druid/math/expr/vector/ObjectOutObjectsInFunctionVectorProcessor.java @@ -38,7 +38,6 @@ protected ObjectOutObjectsInFunctionVectorProcessor( super( CastToTypeVectorProcessor.cast(left, expressionType), CastToTypeVectorProcessor.cast(right, expressionType), - maxVectorSize, new Object[maxVectorSize] ); this.expressionType = expressionType; diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateDoubleFunctionVectorValueProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateDoubleFunctionVectorValueProcessor.java index 03f9be1eb9a2..65ad076fea12 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateDoubleFunctionVectorValueProcessor.java +++ b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateDoubleFunctionVectorValueProcessor.java @@ -32,7 +32,6 @@ public abstract class UnivariateDoubleFunctionVectorValueProcessor implements ExprVectorProcessor { final ExprVectorProcessor processor; - final int maxVectorSize; final boolean[] outNulls; final double[] outValues; @@ -42,7 +41,6 @@ public UnivariateDoubleFunctionVectorValueProcessor( ) { this.processor = processor; - this.maxVectorSize = maxVectorSize; this.outNulls = new boolean[maxVectorSize]; this.outValues = new double[maxVectorSize]; } diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateFunctionVectorObjectProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateFunctionVectorObjectProcessor.java index 02fa6dd3768c..da9be989cffd 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateFunctionVectorObjectProcessor.java +++ b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateFunctionVectorObjectProcessor.java @@ -28,7 +28,6 @@ public abstract class UnivariateFunctionVectorObjectProcessor implements ExprVectorProcessor { final ExprVectorProcessor processor; - final int maxVectorSize; final boolean[] outNulls; final TOutput outValues; @@ -39,7 +38,6 @@ public UnivariateFunctionVectorObjectProcessor( ) { this.processor = processor; - this.maxVectorSize = maxVectorSize; this.outNulls = new boolean[maxVectorSize]; this.outValues = outValues; } diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateLongFunctionVectorValueProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateLongFunctionVectorValueProcessor.java index 869448945086..d24a5e9f1482 100644 --- a/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateLongFunctionVectorValueProcessor.java +++ b/processing/src/main/java/org/apache/druid/math/expr/vector/UnivariateLongFunctionVectorValueProcessor.java @@ -32,7 +32,6 @@ public abstract class UnivariateLongFunctionVectorValueProcessor implements ExprVectorProcessor { final ExprVectorProcessor processor; - final int maxVectorSize; final boolean[] outNulls; final long[] outValues; @@ -42,7 +41,6 @@ public UnivariateLongFunctionVectorValueProcessor( ) { this.processor = processor; - this.maxVectorSize = maxVectorSize; this.outNulls = new boolean[maxVectorSize]; this.outValues = new long[maxVectorSize]; } diff --git a/processing/src/main/java/org/apache/druid/metadata/PasswordProviderRedactionMixIn.java b/processing/src/main/java/org/apache/druid/metadata/PasswordProviderRedactionMixIn.java index 37a5b9a48f79..5a96decb7981 100644 --- a/processing/src/main/java/org/apache/druid/metadata/PasswordProviderRedactionMixIn.java +++ b/processing/src/main/java/org/apache/druid/metadata/PasswordProviderRedactionMixIn.java @@ -28,6 +28,7 @@ */ public interface PasswordProviderRedactionMixIn { + @SuppressWarnings("unused") @JsonIgnore String getPassword(); } diff --git a/processing/src/main/java/org/apache/druid/timeline/SegmentId.java b/processing/src/main/java/org/apache/druid/timeline/SegmentId.java index 986d9aafe276..99d17c4405aa 100644 --- a/processing/src/main/java/org/apache/druid/timeline/SegmentId.java +++ b/processing/src/main/java/org/apache/druid/timeline/SegmentId.java @@ -29,7 +29,6 @@ import com.google.common.primitives.Ints; import org.apache.druid.guice.annotations.PublicApi; import org.apache.druid.java.util.common.DateTimes; -import org.apache.druid.java.util.common.IAE; import org.apache.druid.java.util.common.Intervals; import org.apache.druid.query.SegmentDescriptor; import org.apache.druid.timeline.partition.ShardSpec; @@ -41,7 +40,6 @@ import java.util.Collections; import java.util.List; import java.util.Objects; -import java.util.function.Function; import java.util.regex.Matcher; import java.util.stream.IntStream; @@ -233,18 +231,6 @@ static String tryExtractMostProbableDataSource(String segmentId) } } - public static Function makeIntervalExtractor(final String dataSource) - { - return identifier -> { - SegmentId segmentIdentifierParts = tryParse(dataSource, identifier); - if (segmentIdentifierParts == null) { - throw new IAE("Invalid identifier [%s]", identifier); - } - - return segmentIdentifierParts.getInterval(); - }; - } - /** * Creates a dummy SegmentId with the given data source. This method is useful in benchmark and test code. */ diff --git a/processing/src/main/java/org/apache/druid/timeline/partition/BuildingSingleDimensionShardSpec.java b/processing/src/main/java/org/apache/druid/timeline/partition/BuildingSingleDimensionShardSpec.java index ff7d5b9ba804..8bc12de40f37 100644 --- a/processing/src/main/java/org/apache/druid/timeline/partition/BuildingSingleDimensionShardSpec.java +++ b/processing/src/main/java/org/apache/druid/timeline/partition/BuildingSingleDimensionShardSpec.java @@ -79,17 +79,20 @@ public Map getSerializableObject() return jsonMap; } + @SuppressWarnings("unused") public String getDimension() { return dimension; } + @SuppressWarnings("unused") @Nullable public String getStart() { return start; } + @SuppressWarnings("unused") @Nullable public String getEnd() { diff --git a/processing/src/main/java/org/apache/druid/timeline/partition/SingleDimensionShardSpec.java b/processing/src/main/java/org/apache/druid/timeline/partition/SingleDimensionShardSpec.java index a8ebbe8dfc86..59ef1be3d6ac 100644 --- a/processing/src/main/java/org/apache/druid/timeline/partition/SingleDimensionShardSpec.java +++ b/processing/src/main/java/org/apache/druid/timeline/partition/SingleDimensionShardSpec.java @@ -93,6 +93,7 @@ public Map getSerializableObject() return jsonMap; } + @SuppressWarnings("unused") public String getDimension() { return dimension; diff --git a/processing/src/main/java/org/apache/druid/utils/CircularBuffer.java b/processing/src/main/java/org/apache/druid/utils/CircularBuffer.java index b61149a01229..ba1299ade88f 100644 --- a/processing/src/main/java/org/apache/druid/utils/CircularBuffer.java +++ b/processing/src/main/java/org/apache/druid/utils/CircularBuffer.java @@ -28,6 +28,7 @@ */ public class CircularBuffer { + @SuppressWarnings("unused") public E[] getBuffer() { return buffer; diff --git a/processing/src/main/java/org/apache/druid/utils/Runnables.java b/processing/src/main/java/org/apache/druid/utils/Runnables.java index 8cb57df631a8..a4bf36fc910c 100644 --- a/processing/src/main/java/org/apache/druid/utils/Runnables.java +++ b/processing/src/main/java/org/apache/druid/utils/Runnables.java @@ -26,6 +26,7 @@ @PublicApi public class Runnables { + @SuppressWarnings("unused") public static Runnable getNoopRunnable() { return () -> {};