From b860f2ab83eabfc2b77ff966069526b6370549a5 Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Tue, 16 May 2023 12:33:06 +0530 Subject: [PATCH 01/13] Suppress flagged CVEs --- .github/workflows/cron-job-its.yml | 5 ++-- owasp-dependency-check-suppressions.xml | 34 +++++++++++++++++++++++-- 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cron-job-its.yml b/.github/workflows/cron-job-its.yml index 02f42292163e..68e93f5b4d45 100644 --- a/.github/workflows/cron-job-its.yml +++ b/.github/workflows/cron-job-its.yml @@ -27,7 +27,7 @@ on: jobs: build: - if: github.event_name == 'schedule' + if: (github.event_name == 'schedule' && github.repository == 'apache/druid') name: build (jdk8) runs-on: ubuntu-latest steps: @@ -107,10 +107,11 @@ jobs: group: other security_vulnerabilities: + if: github.repository == 'apache/druid' name: security vulnerabilities strategy: matrix: - HADOOP_PROFILE: [ '', '-Phadoop3' ] + HADOOP_PROFILE: [ '', '-Phadoop2' ] runs-on: ubuntu-latest steps: - name: Checkout branch diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index 3095ed160c63..55caaca35e2b 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -192,10 +192,12 @@ ~ ... 27 more --> ^pkg:maven/org\.hibernate/hibernate\-validator@.*$ - CVE-2017-7536 + CVE-2019-10219 + CVE-2019-14900 + CVE-2020-10693 CVE-2020-25638 @@ -216,8 +218,13 @@ CVE-2019-20444 CVE-2019-20445 CVE-2020-11612 + CVE-2021-21290 + CVE-2021-21295 + CVE-2021-21409 CVE-2021-37136 CVE-2021-37137 + CVE-2021-43797 + CVE-2022-24823 CVE-2022-41881 @@ -619,6 +626,7 @@ ]]> ^pkg:maven/org\.asynchttpclient/async-http-client-netty-utils@2.5.3$ CVE-2021-43138 + CVE-2021-4277 @@ -833,4 +841,26 @@ CVE-2021-40331 + + + + + ^pkg:maven/.*/.*@.*$ + CVE-2021-4277 + + + + + + ^pkg:maven/com\.google\.guava/guava@16.0.1$ + CVE-2018-10237 + CVE-2020-8908 + From 069b9c1ac1d8533c7f123dc0ebd425f1407bf7c7 Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Tue, 16 May 2023 12:47:15 +0530 Subject: [PATCH 02/13] remove duplicate --- owasp-dependency-check-suppressions.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index 55caaca35e2b..b153587fd67e 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -626,7 +626,6 @@ ]]> ^pkg:maven/org\.asynchttpclient/async-http-client-netty-utils@2.5.3$ CVE-2021-43138 - CVE-2021-4277 From ccc87b5b857a163ade8e8cad88416e662dec7f10 Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Tue, 16 May 2023 13:24:08 +0530 Subject: [PATCH 03/13] force update snapshots --- .github/workflows/cron-job-its.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cron-job-its.yml b/.github/workflows/cron-job-its.yml index 68e93f5b4d45..04bcf7401a73 100644 --- a/.github/workflows/cron-job-its.yml +++ b/.github/workflows/cron-job-its.yml @@ -126,7 +126,7 @@ jobs: - name: security vulnerabilities check env: - MVN: mvn --no-snapshot-updates + MVN: mvn -U HADOOP_PROFILE: ${{ matrix.HADOOP_PROFILE }} run: | mvn dependency-check:purge dependency-check:check ${HADOOP_PROFILE} || { echo " From c01c2406c13144e7f1947aef66eadb1828d5ccff Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Tue, 16 May 2023 13:36:05 +0530 Subject: [PATCH 04/13] clean install before dependency check --- .github/workflows/cron-job-its.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cron-job-its.yml b/.github/workflows/cron-job-its.yml index 04bcf7401a73..0f0d303fcd5a 100644 --- a/.github/workflows/cron-job-its.yml +++ b/.github/workflows/cron-job-its.yml @@ -124,9 +124,13 @@ jobs: distribution: 'zulu' cache: maven + - name: Maven build + id: maven_build + run: ./it.sh ci + - name: security vulnerabilities check env: - MVN: mvn -U + MVN: mvn --no-snapshot-updates HADOOP_PROFILE: ${{ matrix.HADOOP_PROFILE }} run: | mvn dependency-check:purge dependency-check:check ${HADOOP_PROFILE} || { echo " From 6acd3e1994acd473320cdc9e709eb6dab13af69b Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Tue, 23 May 2023 15:05:40 +0530 Subject: [PATCH 05/13] suppress CVE-2017-7536 from hibernate-validator-5.2.5.Final.jar while using hadoop2 --- owasp-dependency-check-suppressions.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index b153587fd67e..a92d57c7945e 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -193,8 +193,10 @@ --> ^pkg:maven/org\.hibernate/hibernate\-validator@.*$ + CVE-2017-7536 CVE-2019-10219 CVE-2019-14900 CVE-2020-10693 From 15eb9ce9985c50418b402dee6ef4ee53ebcea894 Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Tue, 20 Jun 2023 03:07:22 +0530 Subject: [PATCH 06/13] add comments in suppressions file --- owasp-dependency-check-suppressions.xml | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index a92d57c7945e..860da64ee6fa 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -197,9 +197,9 @@ ]]> ^pkg:maven/org\.hibernate/hibernate\-validator@.*$ CVE-2017-7536 - CVE-2019-10219 - CVE-2019-14900 - CVE-2020-10693 + CVE-2019-10219 + CVE-2019-14900 + CVE-2020-10693 CVE-2020-25638 @@ -220,13 +220,13 @@ CVE-2019-20444 CVE-2019-20445 CVE-2020-11612 - CVE-2021-21290 - CVE-2021-21295 - CVE-2021-21409 + CVE-2021-21290 + CVE-2021-21295 + CVE-2021-21409 CVE-2021-37136 CVE-2021-37137 - CVE-2021-43797 - CVE-2022-24823 + CVE-2021-43797 + CVE-2022-24823 CVE-2022-41881 @@ -861,7 +861,11 @@ file name: guava-16.0.1.jar ]]> ^pkg:maven/com\.google\.guava/guava@16.0.1$ + CVE-2018-10237 - CVE-2020-8908 + CVE-2020-8908 From 4b58e77c3bbcd1da79d8b8c96c0d779d74136adf Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Tue, 20 Jun 2023 13:38:06 +0530 Subject: [PATCH 07/13] suppress CVE-2023-35116, fix cve-2023-34455 by upgrading snappy-java --- .github/workflows/cron-job-its.yml | 1 + owasp-dependency-check-suppressions.xml | 1 + pom.xml | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cron-job-its.yml b/.github/workflows/cron-job-its.yml index 0f0d303fcd5a..184ac5d5a9ca 100644 --- a/.github/workflows/cron-job-its.yml +++ b/.github/workflows/cron-job-its.yml @@ -110,6 +110,7 @@ jobs: if: github.repository == 'apache/druid' name: security vulnerabilities strategy: + fail-fast: false matrix: HADOOP_PROFILE: [ '', '-Phadoop2' ] runs-on: ubuntu-latest diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index 860da64ee6fa..bf8132cb4e73 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -122,6 +122,7 @@ https://github.com/FasterXML/jackson-databind/issues/3328 --> CVE-2021-46877 + CVE-2023-35116 diff --git a/pom.xml b/pom.xml index 432adba40438..51772b29d2b8 100644 --- a/pom.xml +++ b/pom.xml @@ -754,7 +754,7 @@ org.xerial.snappy snappy-java - 1.1.8.4 + 1.1.10.1 com.google.protobuf From 390b78d0d8b032946af8da68c43fdb1221b08305 Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Mon, 3 Jul 2023 15:37:56 +0530 Subject: [PATCH 08/13] suppress CVE-2023-2976, jquery.datatables@1.10.18 prototype pollution --- owasp-dependency-check-suppressions.xml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index cd26f100ad92..f8a50bb8ee42 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -826,6 +826,14 @@ CVE-2022-26612 CVE-2023-25613 + CVE-2023-2976 + + + + + prototype pollution CVE-2018-10237 - CVE-2020-8908 + CVE-2020-8908 + CVE-2023-2976 From 5d2e222b6ad1c80007c45928c0abe6d79a8d6863 Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Mon, 3 Jul 2023 20:55:53 +0530 Subject: [PATCH 09/13] update description, remove maven build before dependency-check --- .github/workflows/cron-job-its.yml | 4 ---- owasp-dependency-check-suppressions.xml | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/cron-job-its.yml b/.github/workflows/cron-job-its.yml index d78eec88fb5d..dffd6aa48508 100644 --- a/.github/workflows/cron-job-its.yml +++ b/.github/workflows/cron-job-its.yml @@ -125,10 +125,6 @@ jobs: distribution: 'zulu' cache: maven - - name: Maven build - id: maven_build - run: ./it.sh ci - - name: security vulnerabilities check env: MVN: mvn --no-snapshot-updates diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index f8a50bb8ee42..53f20081e1aa 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -826,7 +826,7 @@ CVE-2022-26612 CVE-2023-25613 - CVE-2023-2976 + CVE-2023-2976 From fecb0ccafe693e89f3386eb09922b222e4b2070e Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Wed, 5 Jul 2023 12:19:40 +0530 Subject: [PATCH 10/13] update comments --- owasp-dependency-check-suppressions.xml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index 53f20081e1aa..e72225a54aa4 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -122,7 +122,8 @@ https://github.com/FasterXML/jackson-databind/issues/3328 --> CVE-2021-46877 - CVE-2023-35116 + + CVE-2023-35116 @@ -221,13 +222,13 @@ CVE-2019-20444 CVE-2019-20445 CVE-2020-11612 - CVE-2021-21290 - CVE-2021-21295 - CVE-2021-21409 + CVE-2021-21290 + CVE-2021-21295 + CVE-2021-21409 CVE-2021-37136 CVE-2021-37137 - CVE-2021-43797 - CVE-2022-24823 + CVE-2021-43797 + CVE-2022-24823 CVE-2022-41881 From 94a4f4e5bb97abcb5fa70d557f9ee532982a6db0 Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Wed, 5 Jul 2023 19:12:21 +0530 Subject: [PATCH 11/13] force update snapshots --- .github/workflows/cron-job-its.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cron-job-its.yml b/.github/workflows/cron-job-its.yml index dffd6aa48508..0fb69f22b948 100644 --- a/.github/workflows/cron-job-its.yml +++ b/.github/workflows/cron-job-its.yml @@ -125,9 +125,11 @@ jobs: distribution: 'zulu' cache: maven + - name: maven build # needed to rebuild incase of maven snapshot resolution fails + run: ./it.sh ci + - name: security vulnerabilities check env: - MVN: mvn --no-snapshot-updates HADOOP_PROFILE: ${{ matrix.HADOOP_PROFILE }} run: | mvn dependency-check:purge dependency-check:check ${HADOOP_PROFILE} || { echo " From 47cc31fc4ec4105eb9571d308e0d97267fad8af6 Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Thu, 6 Jul 2023 10:26:39 +0530 Subject: [PATCH 12/13] skip web console build --- .github/workflows/cron-job-its.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cron-job-its.yml b/.github/workflows/cron-job-its.yml index 0fb69f22b948..3752b6c60eae 100644 --- a/.github/workflows/cron-job-its.yml +++ b/.github/workflows/cron-job-its.yml @@ -126,7 +126,7 @@ jobs: cache: maven - name: maven build # needed to rebuild incase of maven snapshot resolution fails - run: ./it.sh ci + run: mvn clean install dependency:go-offline -P dist -P skip-static-checks,skip-tests -Dmaven.javadoc.skip=true -Dcyclonedx.skip=true -Dweb.console.skip=true - name: security vulnerabilities check env: From 3876641b678d95b38cedc34a257f7985d0e2f7a7 Mon Sep 17 00:00:00 2001 From: "tejaswini.bandlamudi" Date: Thu, 6 Jul 2023 19:39:28 +0530 Subject: [PATCH 13/13] address review comments --- owasp-dependency-check-suppressions.xml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/owasp-dependency-check-suppressions.xml b/owasp-dependency-check-suppressions.xml index e72225a54aa4..2a2b2220b649 100644 --- a/owasp-dependency-check-suppressions.xml +++ b/owasp-dependency-check-suppressions.xml @@ -122,7 +122,7 @@ https://github.com/FasterXML/jackson-databind/issues/3328 --> CVE-2021-46877 - + CVE-2023-35116 @@ -855,9 +855,6 @@ CVE-2021-4277 -