From 102df31cd51048eba90ee475b5d55790247283c8 Mon Sep 17 00:00:00 2001 From: Abhishek Balaji Radhakrishnan Date: Mon, 10 Jul 2023 15:51:44 -0700 Subject: [PATCH 1/3] Doc fixes. --- docs/operations/metrics.md | 2 +- docs/querying/lookups.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/operations/metrics.md b/docs/operations/metrics.md index b742fff795d6..3e0958946c14 100644 --- a/docs/operations/metrics.md +++ b/docs/operations/metrics.md @@ -350,7 +350,7 @@ These metrics are for the Druid Coordinator and are reset each time the Coordina ### JVM -These metrics are only available if the `JVMMonitor` module is included. +These metrics are only available if the `JvmMonitor` module is included. |Metric|Description|Dimensions|Normal Value| |------|-----------|----------|------------| diff --git a/docs/querying/lookups.md b/docs/querying/lookups.md index d69f31619a56..ec82dc93933f 100644 --- a/docs/querying/lookups.md +++ b/docs/querying/lookups.md @@ -79,7 +79,7 @@ In native queries, lookups can be queried with [dimension specs or extraction fu Query Execution --------------- -When executing an aggregation query involving lookup functions (like the SQL [`LOOKUP` function](sql-scalar.md#string-functions), +When executing an aggregation query involving lookup functions, like the SQL [`LOOKUP` function](sql-scalar.md#string-functions), Druid can decide to apply them while scanning and aggregating rows, or to apply them after aggregation is complete. It is more efficient to apply lookups after aggregation is complete, so Druid will do this if it can. Druid decides this by checking if the lookup is marked as "injective" or not. In general, you should set this property for any lookup that From 1babaa1d778cbc53d1cdcede947f73c1d4566cc6 Mon Sep 17 00:00:00 2001 From: Abhishek Radhakrishnan Date: Tue, 11 Jul 2023 08:08:27 -0700 Subject: [PATCH 2/3] Update docs/operations/metrics.md Co-authored-by: Kashif Faraz --- docs/operations/metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/operations/metrics.md b/docs/operations/metrics.md index 3e0958946c14..12f830e1aa29 100644 --- a/docs/operations/metrics.md +++ b/docs/operations/metrics.md @@ -350,7 +350,7 @@ These metrics are for the Druid Coordinator and are reset each time the Coordina ### JVM -These metrics are only available if the `JvmMonitor` module is included. +These metrics are only available if the `JvmMonitor` module is included in `druid.monitoring.monitors`. |Metric|Description|Dimensions|Normal Value| |------|-----------|----------|------------| From ab41d2478b68955dc00893dc76fbf53d7afa9ec8 Mon Sep 17 00:00:00 2001 From: Abhishek Balaji Radhakrishnan Date: Tue, 11 Jul 2023 12:02:24 -0700 Subject: [PATCH 3/3] Review feedback: include link to the enabling emitters section --- docs/operations/metrics.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/operations/metrics.md b/docs/operations/metrics.md index 12f830e1aa29..ecadf53c4cd2 100644 --- a/docs/operations/metrics.md +++ b/docs/operations/metrics.md @@ -351,6 +351,7 @@ These metrics are for the Druid Coordinator and are reset each time the Coordina ### JVM These metrics are only available if the `JvmMonitor` module is included in `druid.monitoring.monitors`. +For more information, see [Enabling Metrics](../configuration/index.md#enabling-metrics). |Metric|Description|Dimensions|Normal Value| |------|-----------|----------|------------|