From 0a2896cb5bf4204506ee55c82d16d4ff43dc3e41 Mon Sep 17 00:00:00 2001 From: cryptoe Date: Thu, 20 Jul 2023 17:53:28 +0530 Subject: [PATCH 1/3] Error messaging fixes. --- docs/multi-stage-query/reference.md | 3 ++ .../apache/druid/msq/exec/ControllerImpl.java | 4 +- .../org/apache/druid/msq/exec/WorkerImpl.java | 8 ++-- .../destination/MSQSelectDestination.java | 25 ++++++++++-- ...torageQueryResultsInputChannelFactory.java | 2 +- .../druid/msq/sql/MSQTaskQueryMaker.java | 14 ++++--- .../druid/msq/sql/entity/PageInformation.java | 28 +++++++------ .../sql/resources/SqlStatementResource.java | 24 ++++++------ .../msq/util/MultiStageQueryContext.java | 4 +- .../msq/util/SqlStatementResourceHelper.java | 39 +++++-------------- .../apache/druid/msq/exec/MSQSelectTest.java | 4 +- .../sql/SqlMSQStatementResourcePostTest.java | 16 ++++---- .../msq/sql/SqlStatementResourceTest.java | 2 +- .../sql/entity/ResultSetInformationTest.java | 10 ++--- .../sql/entity/SqlStatementResultTest.java | 7 ++-- .../msq/util/MultiStageQueryContextTest.java | 2 +- .../org/apache/druid/query/QueryContexts.java | 9 ++++- 17 files changed, 108 insertions(+), 93 deletions(-) diff --git a/docs/multi-stage-query/reference.md b/docs/multi-stage-query/reference.md index fe86ccad5058..682a239b63c7 100644 --- a/docs/multi-stage-query/reference.md +++ b/docs/multi-stage-query/reference.md @@ -243,6 +243,7 @@ The following table lists the context parameters for the MSQ task engine: | `indexSpec` | INSERT or REPLACE

An [`indexSpec`](../ingestion/ingestion-spec.md#indexspec) to use when generating segments. May be a JSON string or object. See [Front coding](../ingestion/ingestion-spec.md#front-coding) for details on configuring an `indexSpec` with front coding. | See [`indexSpec`](../ingestion/ingestion-spec.md#indexspec). | | `durableShuffleStorage` | SELECT, INSERT, REPLACE

Whether to use durable storage for shuffle mesh. To use this feature, configure the durable storage at the server level using `druid.msq.intermediate.storage.enable=true`). If these properties are not configured, any query with the context variable `durableShuffleStorage=true` fails with a configuration error.

| `false` | | `faultTolerance` | SELECT, INSERT, REPLACE

Whether to turn on fault tolerance mode or not. Failed workers are retried based on [Limits](#limits). Cannot be used when `durableShuffleStorage` is explicitly set to false. | `false` | + | `selectDestination` | SELECT

Controls where the final result of the select query is written.
Use `taskReport`(the default) to write select results to the task report. This is not scalable since task reports size explodes for large results
Use `durableStorage` to write results to durable storage location. For large results sets, its recommended to use `durableStorage` . To configure durable storage see [`this`](#durable-storage) section. | `taskReport` | ## Joins @@ -376,6 +377,8 @@ When you run a query, include the context parameter `durableShuffleStorage` and For queries where you want to use fault tolerance for workers, set `faultTolerance` to `true`, which automatically sets `durableShuffleStorage` to `true`. +For select queryies which want to write the final result to `durableStoage`, set `selectDestination`:`durableStorage`. Which shuffle mesh the job uses can still be controller by `durableShuffleStorage` flag ie. a combination where `selectDestination`:`durableStorage` and `durableShuffleStorage`:`false` is perfectly valid. + ## Durable storage configurations The following common service properties control how durable storage behaves: diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java index f5f7b0cc1aa3..6cf7a2f5181b 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java @@ -605,14 +605,14 @@ private QueryDefinition initializeQueryDefAndState(final Closer closer) if (MSQControllerTask.writeResultsToDurableStorage(task.getQuerySpec())) { taskContextOverridesBuilder.put( MultiStageQueryContext.CTX_SELECT_DESTINATION, - MSQSelectDestination.DURABLE_STORAGE.name() + MSQSelectDestination.DURABLESTORAGE.getName() ); } else { // we need not pass the value 'TaskReport' to the worker since the worker impl does not do anything in such a case. // but we are passing it anyway for completeness taskContextOverridesBuilder.put( MultiStageQueryContext.CTX_SELECT_DESTINATION, - MSQSelectDestination.TASK_REPORT.name() + MSQSelectDestination.TASKREPORT.getName() ); } } diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerImpl.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerImpl.java index 942d8b44b0c9..2c347c4275e9 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerImpl.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerImpl.java @@ -732,7 +732,7 @@ private OutputChannelFactory makeStageOutputChannelFactory( final int frameSize = frameContext.memoryParameters().getStandardFrameSize(); if (durableStageStorageEnabled || (isFinalStage - && MSQSelectDestination.DURABLE_STORAGE.equals(selectDestination))) { + && MSQSelectDestination.DURABLESTORAGE.equals(selectDestination))) { return DurableStorageOutputChannelFactory.createStandardImplementation( task.getControllerTaskId(), task().getWorkerNumber(), @@ -741,7 +741,7 @@ private OutputChannelFactory makeStageOutputChannelFactory( frameSize, MSQTasks.makeStorageConnector(context.injector()), context.tempDir(), - (isFinalStage && MSQSelectDestination.DURABLE_STORAGE.equals(selectDestination)) + (isFinalStage && MSQSelectDestination.DURABLESTORAGE.equals(selectDestination)) ); } else { final File fileChannelDirectory = @@ -1320,7 +1320,7 @@ private void writeDurableStorageSuccessFileIfNeeded(final int stageNumber, boole { final DurableStorageOutputChannelFactory durableStorageOutputChannelFactory; if (durableStageStorageEnabled || (isFinalStage - && MSQSelectDestination.DURABLE_STORAGE.equals(selectDestination))) { + && MSQSelectDestination.DURABLESTORAGE.equals(selectDestination))) { durableStorageOutputChannelFactory = DurableStorageOutputChannelFactory.createStandardImplementation( task.getControllerTaskId(), task().getWorkerNumber(), @@ -1329,7 +1329,7 @@ private void writeDurableStorageSuccessFileIfNeeded(final int stageNumber, boole frameContext.memoryParameters().getStandardFrameSize(), MSQTasks.makeStorageConnector(context.injector()), context.tempDir(), - (isFinalStage && MSQSelectDestination.DURABLE_STORAGE.equals(selectDestination)) + (isFinalStage && MSQSelectDestination.DURABLESTORAGE.equals(selectDestination)) ); } else { return; diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/MSQSelectDestination.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/MSQSelectDestination.java index d41a85622693..db57fdc5dc07 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/MSQSelectDestination.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/MSQSelectDestination.java @@ -19,6 +19,8 @@ package org.apache.druid.msq.indexing.destination; +import com.fasterxml.jackson.annotation.JsonValue; + /** * Determines the destination for results of select queries. */ @@ -27,12 +29,13 @@ public enum MSQSelectDestination /** * Writes all the results directly to the report. */ - TASK_REPORT(false), + TASKREPORT("taskReport", false), /** * Writes the results as frame files to durable storage. Task report can be truncated to a preview. */ - DURABLE_STORAGE(true); + DURABLESTORAGE("durableStorage", true); + private final String name; private final boolean shouldTruncateResultsInTaskReport; public boolean shouldTruncateResultsInTaskReport() @@ -40,8 +43,24 @@ public boolean shouldTruncateResultsInTaskReport() return shouldTruncateResultsInTaskReport; } - MSQSelectDestination(boolean shouldTruncateResultsInTaskReport) + MSQSelectDestination(String name, boolean shouldTruncateResultsInTaskReport) { + this.name = name; this.shouldTruncateResultsInTaskReport = shouldTruncateResultsInTaskReport; } + + @JsonValue + public String getName() + { + return name; + } + + @Override + public String toString() + { + return "MSQSelectDestination{" + + "name='" + name + '\'' + + ", shouldTruncateResultsInTaskReport=" + shouldTruncateResultsInTaskReport + + '}'; + } } diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/shuffle/input/DurableStorageQueryResultsInputChannelFactory.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/shuffle/input/DurableStorageQueryResultsInputChannelFactory.java index b29220e790d7..620b2271e252 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/shuffle/input/DurableStorageQueryResultsInputChannelFactory.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/shuffle/input/DurableStorageQueryResultsInputChannelFactory.java @@ -25,7 +25,7 @@ import java.util.concurrent.ExecutorService; /** - * Used for reading results when select destination is {@link org.apache.druid.msq.indexing.destination.MSQSelectDestination#DURABLE_STORAGE} + * Used for reading results when select destination is {@link org.apache.druid.msq.indexing.destination.MSQSelectDestination#DURABLESTORAGE} */ public class DurableStorageQueryResultsInputChannelFactory extends DurableStorageInputChannelFactory { diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java index 772af8524e24..de48387db200 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java @@ -66,6 +66,7 @@ import javax.annotation.Nullable; import java.util.ArrayList; +import java.util.Arrays; import java.util.Collections; import java.util.HashMap; import java.util.List; @@ -233,17 +234,18 @@ public QueryResponse runQuery(final DruidQuery druidQuery) ); } else { final MSQSelectDestination msqSelectDestination = MultiStageQueryContext.getSelectDestination(sqlQueryContext); - if (msqSelectDestination.equals(MSQSelectDestination.TASK_REPORT)) { + if (msqSelectDestination.equals(MSQSelectDestination.TASKREPORT)) { destination = TaskReportMSQDestination.instance(); - } else if (msqSelectDestination.equals(MSQSelectDestination.DURABLE_STORAGE)) { + } else if (msqSelectDestination.equals(MSQSelectDestination.DURABLESTORAGE)) { destination = DurableStorageMSQDestination.instance(); } else { throw InvalidInput.exception( "Unsupported select destination [%s] provided in the query context. MSQ can currently write the select results to " - + "[%s] and [%s]", - msqSelectDestination.name(), - MSQSelectDestination.TASK_REPORT.toString(), - MSQSelectDestination.DURABLE_STORAGE.toString() + + "[%s]", + msqSelectDestination.getName(), + Arrays.stream(MSQSelectDestination.values()) + .map(MSQSelectDestination::getName) + .collect(Collectors.joining(",")) ); } } diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/entity/PageInformation.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/entity/PageInformation.java index 1c212f275ee1..6db1f371af7c 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/entity/PageInformation.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/entity/PageInformation.java @@ -21,6 +21,7 @@ import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonInclude; import com.fasterxml.jackson.annotation.JsonProperty; import javax.annotation.Nullable; @@ -32,25 +33,32 @@ */ public class PageInformation { + private final long id; @Nullable private final Long numRows; @Nullable private final Long sizeInBytes; - private final long id; @JsonCreator public PageInformation( + @JsonProperty("id") long id, @JsonProperty("numRows") @Nullable Long numRows, - @JsonProperty("sizeInBytes") @Nullable Long sizeInBytes, - @JsonProperty("id") long id + @JsonProperty("sizeInBytes") @Nullable Long sizeInBytes ) { + this.id = id; this.numRows = numRows; this.sizeInBytes = sizeInBytes; - this.id = id; } @JsonProperty + public long getId() + { + return id; + } + + @JsonProperty + @JsonInclude(JsonInclude.Include.NON_NULL) @Nullable public Long getNumRows() { @@ -58,17 +66,13 @@ public Long getNumRows() } @JsonProperty + @JsonInclude(JsonInclude.Include.NON_NULL) @Nullable public Long getSizeInBytes() { return sizeInBytes; } - @JsonProperty - public long getId() - { - return id; - } @Override public boolean equals(Object o) @@ -89,16 +93,16 @@ public boolean equals(Object o) @Override public int hashCode() { - return Objects.hash(numRows, sizeInBytes, id); + return Objects.hash(id, numRows, sizeInBytes); } @Override public String toString() { return "PageInformation{" + - "numRows=" + numRows + + "id=" + id + + ", numRows=" + numRows + ", sizeInBytes=" + sizeInBytes + - ", id=" + id + '}'; } diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java index f5268bd8fbec..2c92b94ac279 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java @@ -28,6 +28,7 @@ import org.apache.druid.client.indexing.TaskPayloadResponse; import org.apache.druid.client.indexing.TaskStatusResponse; import org.apache.druid.common.guava.FutureUtils; +import org.apache.druid.discovery.NodeRole; import org.apache.druid.error.DruidException; import org.apache.druid.error.ErrorResponse; import org.apache.druid.error.Forbidden; @@ -704,7 +705,7 @@ private Optional> getResultYielder( } else { selectedPageId = null; } - checkForDurableStorageConnectorImpl(); + checkForDurableStorageConnectorImpl(NodeRole.BROKER); final DurableStorageInputChannelFactory standardImplementation = DurableStorageInputChannelFactory.createStandardImplementation( msqControllerTask.getId(), storageConnector, @@ -830,16 +831,16 @@ private void contextChecks(QueryContext queryContext) if (executionMode == null) { throw InvalidInput.exception( - "Execution mode is not provided to the SQL statement API. " + "Execution mode is not provided to the sql statement api. " + "Please set [%s] to [%s] in the query context", QueryContexts.CTX_EXECUTION_MODE, ExecutionMode.ASYNC ); } - if (ExecutionMode.ASYNC != executionMode) { + if (!ExecutionMode.ASYNC.equals(executionMode)) { throw InvalidInput.exception( - "The SQL statement API currently does not support the provided execution mode [%s]. " + "The sql statement api currently does not support the provided execution mode [%s]. " + "Please set [%s] to [%s] in the query context", executionMode, QueryContexts.CTX_EXECUTION_MODE, @@ -848,24 +849,25 @@ private void contextChecks(QueryContext queryContext) } MSQSelectDestination selectDestination = MultiStageQueryContext.getSelectDestination(queryContext); - if (selectDestination == MSQSelectDestination.DURABLE_STORAGE) { - checkForDurableStorageConnectorImpl(); + if (MSQSelectDestination.DURABLESTORAGE.equals(selectDestination)) { + checkForDurableStorageConnectorImpl(NodeRole.BROKER); } } - private void checkForDurableStorageConnectorImpl() + private void checkForDurableStorageConnectorImpl(NodeRole nodeRole) { if (storageConnector instanceof NilStorageConnector) { throw DruidException.forPersona(DruidException.Persona.USER) .ofCategory(DruidException.Category.INVALID_INPUT) .build( StringUtils.format( - "The SQL Statement API cannot read from the select destination [%s] provided " - + "in the query context [%s] since it is not configured. It is recommended to configure the durable storage " + "The sql statement api cannot read from the select destination [%s] provided " + + "in the query context [%s] since it is not configured on the [%s]. It is recommended to configure durable storage " + "as it allows the user to fetch large result sets. Please contact your cluster admin to " + "configure durable storage.", - MSQSelectDestination.DURABLE_STORAGE.name(), - MultiStageQueryContext.CTX_SELECT_DESTINATION + MSQSelectDestination.DURABLESTORAGE.getName(), + MultiStageQueryContext.CTX_SELECT_DESTINATION, + nodeRole.getJsonName() ) ); } diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java index b3f012d2c667..7bdded98c1e8 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java @@ -67,7 +67,7 @@ * *
  • selectDestination: If the query is a Select, determines the location to write results to, once the query * is finished. Depending on the location, the results might also be truncated to {@link Limits#MAX_SELECT_RESULT_ROWS}. - * Default value is {@link MSQSelectDestination#TASK_REPORT}, which writes all the results to the report. + * Default value is {@link MSQSelectDestination#TASKREPORT}, which writes all the results to the report. * *
  • useAutoColumnSchemas: Temporary flag to allow experimentation using * {@link org.apache.druid.segment.AutoTypeColumnSchema} for all 'standard' type columns during segment generation, @@ -93,7 +93,7 @@ public class MultiStageQueryContext public static final String CTX_DURABLE_SHUFFLE_STORAGE = "durableShuffleStorage"; private static final boolean DEFAULT_DURABLE_SHUFFLE_STORAGE = false; public static final String CTX_SELECT_DESTINATION = "selectDestination"; - private static final String DEFAULT_SELECT_DESTINATION = MSQSelectDestination.TASK_REPORT.toString(); + private static final String DEFAULT_SELECT_DESTINATION = MSQSelectDestination.TASKREPORT.getName(); public static final String CTX_FAULT_TOLERANCE = "faultTolerance"; public static final boolean DEFAULT_FAULT_TOLERANCE = false; diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/SqlStatementResourceHelper.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/SqlStatementResourceHelper.java index 4211a062b5df..a11d40fbbcee 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/SqlStatementResourceHelper.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/SqlStatementResourceHelper.java @@ -142,27 +142,6 @@ public static SqlStatementState getSqlStatementState(TaskStatusPlus taskStatusPl } } - @SuppressWarnings("unchecked") - - - public static long getLastIndex(Long numberOfRows, long start) - { - final long last; - if (numberOfRows == null) { - last = Long.MAX_VALUE; - } else { - long finalIndex; - try { - finalIndex = Math.addExact(start, numberOfRows); - } - catch (ArithmeticException e) { - finalIndex = Long.MAX_VALUE; - } - last = finalIndex; - } - return last; - } - /** * Populates pages list from the {@link CounterSnapshotsTree}. *
    @@ -170,7 +149,7 @@ public static long getLastIndex(Long numberOfRows, long start) *
      *
    1. {@link DataSourceMSQDestination} a single page is returned which adds all the counters of {@link SegmentGenerationProgressCounter.Snapshot}
      2. *
    2. {@link TaskReportMSQDestination} a single page is returned which adds all the counters of {@link ChannelCounters}
      3. - *
    3. {@link DurableStorageMSQDestination} a page is returned for each worker which has generated output rows. + *
    4. {@link DurableStorageMSQDestination} a page is returned for each worker which has generated output rows. The list is sorted on page Id. * If the worker generated 0 rows, we do no populated a page for it. {@link PageInformation#id} is equal to the worker number
      5. *
    */ @@ -183,8 +162,9 @@ public static Optional> populatePageList( return Optional.empty(); } int finalStage = msqTaskReportPayload.getStages().getStages().size() - 1; - Map workerCounters = msqTaskReportPayload.getCounters().snapshotForStage(finalStage); - if (workerCounters == null) { + CounterSnapshotsTree counterSnapshotsTree = msqTaskReportPayload.getCounters(); + Map workerCounters = counterSnapshotsTree.snapshotForStage(finalStage); + if (workerCounters == null || workerCounters.isEmpty()) { return Optional.empty(); } @@ -198,7 +178,7 @@ public static Optional> populatePageList( } } if (rows != 0L) { - return Optional.of(ImmutableList.of(new PageInformation(rows, null, 0))); + return Optional.of(ImmutableList.of(new PageInformation(0, rows, null))); } else { return Optional.empty(); } @@ -213,7 +193,7 @@ public static Optional> populatePageList( } } if (rows != 0L) { - return Optional.of(ImmutableList.of(new PageInformation(rows, size, 0))); + return Optional.of(ImmutableList.of(new PageInformation(0, rows, size))); } else { return Optional.empty(); } @@ -230,10 +210,10 @@ public static Optional> populatePageList( } // do not populate a page if the worker generated 0 rows. if (rows != 0L) { - pageList.add(new PageInformation(rows, size, counterSnapshots.getKey())); + pageList.add(new PageInformation(counterSnapshots.getKey(), rows, size)); } } - Collections.sort(pageList, PageInformation.getIDComparator()); + pageList.sort(PageInformation.getIDComparator()); return Optional.of(pageList); } else { return Optional.empty(); @@ -378,7 +358,6 @@ public static Map getMap(Map map, String key) public static Map getPayload(Map results) { Map msqReport = getMap(results, "multiStageQuery"); - Map payload = getMap(msqReport, "payload"); - return payload; + return getMap(msqReport, "payload"); } } diff --git a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQSelectTest.java b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQSelectTest.java index 6d444ac70de5..65e7baa7bf4c 100644 --- a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQSelectTest.java +++ b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQSelectTest.java @@ -111,7 +111,7 @@ public class MSQSelectTest extends MSQTestBase .putAll(DURABLE_STORAGE_MSQ_CONTEXT) .put( MultiStageQueryContext.CTX_SELECT_DESTINATION, - MSQSelectDestination.DURABLE_STORAGE.name().toLowerCase(Locale.ENGLISH) + MSQSelectDestination.DURABLESTORAGE.getName().toLowerCase(Locale.ENGLISH) ) .build(); @@ -121,7 +121,7 @@ public class MSQSelectTest extends MSQTestBase .putAll(DEFAULT_MSQ_CONTEXT) .put( MultiStageQueryContext.CTX_SELECT_DESTINATION, - MSQSelectDestination.DURABLE_STORAGE.name().toLowerCase(Locale.ENGLISH) + MSQSelectDestination.DURABLESTORAGE.getName().toLowerCase(Locale.ENGLISH) ) .build(); diff --git a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlMSQStatementResourcePostTest.java b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlMSQStatementResourcePostTest.java index 4f96b132ef07..2d022f76f039 100644 --- a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlMSQStatementResourcePostTest.java +++ b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlMSQStatementResourcePostTest.java @@ -124,7 +124,7 @@ public void testMSQSelectQueryTest() throws IOException null, MSQControllerTask.DUMMY_DATASOURCE_FOR_SELECT, results, - ImmutableList.of(new PageInformation(6L, 316L, 0)) + ImmutableList.of(new PageInformation(0, 6L, 316L)) ), null ); @@ -150,7 +150,7 @@ public void nonSupportedModes() ImmutableMap.of(), null ), SqlStatementResourceTest.makeOkRequest()), - "Execution mode is not provided to the SQL statement API. " + "Execution mode is not provided to the sql statement api. " + "Please set [executionMode] to [ASYNC] in the query context", Response.Status.BAD_REQUEST ); @@ -165,7 +165,7 @@ public void nonSupportedModes() ImmutableMap.of(QueryContexts.CTX_EXECUTION_MODE, ExecutionMode.SYNC.name()), null ), SqlStatementResourceTest.makeOkRequest()), - "The SQL statement API currently does not support the provided execution mode [SYNC]. " + "The sql statement api currently does not support the provided execution mode [SYNC]. " + "Please set [executionMode] to [ASYNC] in the query context", Response.Status.BAD_REQUEST ); @@ -273,12 +273,12 @@ public void durableStorageDisabledTest() NilStorageConnector.getInstance() ); - String errorMessage = "The SQL Statement API cannot read from the select destination [DURABLE_STORAGE] provided in " - + "the query context [selectDestination] since it is not configured. It is recommended to " - + "configure the durable storage as it allows the user to fetch large result sets. " + String errorMessage = "The sql statement api cannot read from the select destination [durableStorage] provided in " + + "the query context [selectDestination] since it is not configured on the [broker]. It is recommended to " + + "configure durable storage as it allows the user to fetch large result sets. " + "Please contact your cluster admin to configure durable storage."; Map context = defaultAsyncContext(); - context.put(MultiStageQueryContext.CTX_SELECT_DESTINATION, MSQSelectDestination.DURABLE_STORAGE.name()); + context.put(MultiStageQueryContext.CTX_SELECT_DESTINATION, MSQSelectDestination.DURABLESTORAGE.getName()); SqlStatementResourceTest.assertExceptionMessage(resourceWithDurableStorage.doPost( new SqlQuery( @@ -300,7 +300,7 @@ public void durableStorageDisabledTest() public void testWithDurableStorage() throws IOException { Map context = defaultAsyncContext(); - context.put(MultiStageQueryContext.CTX_SELECT_DESTINATION, MSQSelectDestination.DURABLE_STORAGE.name()); + context.put(MultiStageQueryContext.CTX_SELECT_DESTINATION, MSQSelectDestination.DURABLESTORAGE.getName()); SqlStatementResult sqlStatementResult = (SqlStatementResult) resource.doPost( new SqlQuery( diff --git a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlStatementResourceTest.java b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlStatementResourceTest.java index 049b57c340e3..aab89bb42870 100644 --- a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlStatementResourceTest.java +++ b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlStatementResourceTest.java @@ -732,7 +732,7 @@ public void testFinishedSelectMSQQuery() throws Exception null, MSQControllerTask.DUMMY_DATASOURCE_FOR_SELECT, RESULT_ROWS, - ImmutableList.of(new PageInformation(3L, 8L, 0L)) + ImmutableList.of(new PageInformation(0, 3L, 8L)) ), null )), objectMapper.writeValueAsString(response.getEntity())); diff --git a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/ResultSetInformationTest.java b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/ResultSetInformationTest.java index 67b77fa51b33..b9a1230ef15a 100644 --- a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/ResultSetInformationTest.java +++ b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/ResultSetInformationTest.java @@ -37,7 +37,7 @@ public class ResultSetInformationTest ResultFormat.OBJECT, "ds", null, - ImmutableList.of(new PageInformation(1L, 1L, 0)) + ImmutableList.of(new PageInformation(0, 1L, 1L)) ); @@ -51,10 +51,10 @@ public class ResultSetInformationTest new String[]{"2"}, new String[]{"3"} ), - ImmutableList.of(new PageInformation(1L, 1L, 0)) + ImmutableList.of(new PageInformation(0, 1L, 1L)) ); - public static final String JSON_STRING = "{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"pages\":[{\"numRows\":1,\"sizeInBytes\":1,\"id\":0}]}"; - public static final String JSON_STRING_1 = "{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"sampleRecords\":[[\"1\"],[\"2\"],[\"3\"]],\"pages\":[{\"numRows\":1,\"sizeInBytes\":1,\"id\":0}]}"; + public static final String JSON_STRING = "{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"pages\":[{\"id\":0,\"numRows\":1,\"sizeInBytes\":1}]}"; + public static final String JSON_STRING_1 = "{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"sampleRecords\":[[\"1\"],[\"2\"],[\"3\"]],\"pages\":[{\"id\":0,\"numRows\":1,\"sizeInBytes\":1}]}"; @Test public void sanityTest() throws JsonProcessingException @@ -66,7 +66,7 @@ public void sanityTest() throws JsonProcessingException MAPPER.readValue(MAPPER.writeValueAsString(RESULTS), ResultSetInformation.class).hashCode() ); Assert.assertEquals( - "ResultSetInformation{numTotalRows=1, totalSizeInBytes=1, resultFormat=object, records=null, dataSource='ds', pages=[PageInformation{numRows=1, sizeInBytes=1, id=0}]}", + "ResultSetInformation{numTotalRows=1, totalSizeInBytes=1, resultFormat=object, records=null, dataSource='ds', pages=[PageInformation{id=0, numRows=1, sizeInBytes=1}]}", RESULTS.toString() ); } diff --git a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/SqlStatementResultTest.java b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/SqlStatementResultTest.java index 88cff552a713..9612d2a46fa2 100644 --- a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/SqlStatementResultTest.java +++ b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/SqlStatementResultTest.java @@ -43,7 +43,7 @@ public class SqlStatementResultTest + "\"createdAt\":\"2023-05-31T12:00:00.000Z\"," + "\"schema\":[{\"name\":\"_time\",\"type\":\"TIMESTAMP\",\"nativeType\":\"LONG\"},{\"name\":\"alias\",\"type\":\"VARCHAR\",\"nativeType\":\"STRING\"},{\"name\":\"market\",\"type\":\"VARCHAR\",\"nativeType\":\"STRING\"}]," + "\"durationMs\":100," - + "\"result\":{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"pages\":[{\"numRows\":1,\"sizeInBytes\":1,\"id\":0}]}," + + "\"result\":{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"pages\":[{\"id\":0,\"numRows\":1,\"sizeInBytes\":1}]}," + "\"errorDetails\":{\"error\":\"druidException\",\"errorCode\":\"QueryNotSupported\",\"persona\":\"USER\",\"category\":\"UNCATEGORIZED\",\"errorMessage\":\"QueryNotSupported\",\"context\":{}}}"; public static final SqlStatementResult SQL_STATEMENT_RESULT = new SqlStatementResult( @@ -58,10 +58,9 @@ public class SqlStatementResultTest @Override protected DruidException makeException(DruidException.DruidExceptionBuilder bob) { - DruidException ex = bob.forPersona(DruidException.Persona.USER) + return bob.forPersona(DruidException.Persona.USER) .ofCategory(DruidException.Category.UNCATEGORIZED) .build(MSQ_EXCEPTION.getMessage()); - return ex; } }).toErrorResponse() ); @@ -87,7 +86,7 @@ public void sanityTest() throws JsonProcessingException + " createdAt=2023-05-31T12:00:00.000Z," + " sqlRowSignature=[ColumnNameAndTypes{colName='_time', sqlTypeName='TIMESTAMP', nativeTypeName='LONG'}, ColumnNameAndTypes{colName='alias', sqlTypeName='VARCHAR', nativeTypeName='STRING'}, ColumnNameAndTypes{colName='market', sqlTypeName='VARCHAR', nativeTypeName='STRING'}]," + " durationInMs=100," - + " resultSetInformation=ResultSetInformation{numTotalRows=1, totalSizeInBytes=1, resultFormat=object, records=null, dataSource='ds', pages=[PageInformation{numRows=1, sizeInBytes=1, id=0}]}," + + " resultSetInformation=ResultSetInformation{numTotalRows=1, totalSizeInBytes=1, resultFormat=object, records=null, dataSource='ds', pages=[PageInformation{id=0, numRows=1, sizeInBytes=1}]}," + " errorResponse={error=druidException, errorCode=QueryNotSupported, persona=USER, category=UNCATEGORIZED, errorMessage=QueryNotSupported, context={}}}", SQL_STATEMENT_RESULT.toString() ); diff --git a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/util/MultiStageQueryContextTest.java b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/util/MultiStageQueryContextTest.java index 6d9389267419..830b414daedb 100644 --- a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/util/MultiStageQueryContextTest.java +++ b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/util/MultiStageQueryContextTest.java @@ -253,7 +253,7 @@ public void getMSQModeParameterSetReturnsCorrectValue() @Test public void limitSelectResultReturnsDefaultValue() { - Assert.assertEquals(MSQSelectDestination.TASK_REPORT, MultiStageQueryContext.getSelectDestination(QueryContext.empty())); + Assert.assertEquals(MSQSelectDestination.TASKREPORT, MultiStageQueryContext.getSelectDestination(QueryContext.empty())); } @Test diff --git a/processing/src/main/java/org/apache/druid/query/QueryContexts.java b/processing/src/main/java/org/apache/druid/query/QueryContexts.java index 203e63f23f68..e6ac3496c070 100644 --- a/processing/src/main/java/org/apache/druid/query/QueryContexts.java +++ b/processing/src/main/java/org/apache/druid/query/QueryContexts.java @@ -31,10 +31,12 @@ import javax.annotation.Nullable; import java.math.BigDecimal; +import java.util.Arrays; import java.util.HashMap; import java.util.Map; import java.util.Map.Entry; import java.util.concurrent.TimeUnit; +import java.util.stream.Collectors; @PublicApi public class QueryContexts @@ -454,7 +456,12 @@ public static > E getAsEnum(String key, Object value, Class catch (IllegalArgumentException e) { throw badValueException( key, - StringUtils.format("a value of enum [%s]", clazz.getSimpleName()), + StringUtils.format( + "referring to one of the values[%s] of enum [%s]", + Arrays.stream(clazz.getEnumConstants()).map(E::name).collect( + Collectors.joining(",")), + clazz.getSimpleName() + ), value ); } From 76769dbf4b2cdd3081f7771348c71e4fca79560d Mon Sep 17 00:00:00 2001 From: cryptoe Date: Thu, 20 Jul 2023 19:07:52 +0530 Subject: [PATCH 2/3] Static check fix --- docs/multi-stage-query/reference.md | 4 ++-- .../org/apache/druid/msq/util/SqlStatementResourceHelper.java | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/multi-stage-query/reference.md b/docs/multi-stage-query/reference.md index 682a239b63c7..0a3fbbce976d 100644 --- a/docs/multi-stage-query/reference.md +++ b/docs/multi-stage-query/reference.md @@ -243,7 +243,7 @@ The following table lists the context parameters for the MSQ task engine: | `indexSpec` | INSERT or REPLACE

    An [`indexSpec`](../ingestion/ingestion-spec.md#indexspec) to use when generating segments. May be a JSON string or object. See [Front coding](../ingestion/ingestion-spec.md#front-coding) for details on configuring an `indexSpec` with front coding. | See [`indexSpec`](../ingestion/ingestion-spec.md#indexspec). | | `durableShuffleStorage` | SELECT, INSERT, REPLACE

    Whether to use durable storage for shuffle mesh. To use this feature, configure the durable storage at the server level using `druid.msq.intermediate.storage.enable=true`). If these properties are not configured, any query with the context variable `durableShuffleStorage=true` fails with a configuration error.

    | `false` | | `faultTolerance` | SELECT, INSERT, REPLACE

    Whether to turn on fault tolerance mode or not. Failed workers are retried based on [Limits](#limits). Cannot be used when `durableShuffleStorage` is explicitly set to false. | `false` | - | `selectDestination` | SELECT

    Controls where the final result of the select query is written.
    Use `taskReport`(the default) to write select results to the task report. This is not scalable since task reports size explodes for large results
    Use `durableStorage` to write results to durable storage location. For large results sets, its recommended to use `durableStorage` . To configure durable storage see [`this`](#durable-storage) section. | `taskReport` | +| `selectDestination` | SELECT

    Controls where the final result of the select query is written.
    Use `taskReport`(the default) to write select results to the task report. This is not scalable since task reports size explodes for large results
    Use `durableStorage` to write results to durable storage location. For large results sets, its recommended to use `durableStorage` . To configure durable storage see [`this`](#durable-storage) section. | `taskReport` | ## Joins @@ -377,7 +377,7 @@ When you run a query, include the context parameter `durableShuffleStorage` and For queries where you want to use fault tolerance for workers, set `faultTolerance` to `true`, which automatically sets `durableShuffleStorage` to `true`. -For select queryies which want to write the final result to `durableStoage`, set `selectDestination`:`durableStorage`. Which shuffle mesh the job uses can still be controller by `durableShuffleStorage` flag ie. a combination where `selectDestination`:`durableStorage` and `durableShuffleStorage`:`false` is perfectly valid. +For select queries where you want to write the final result to `durableStorage`, set `selectDestination`:`durableStorage`. Which shuffle mesh the job uses can still be controlled by `durableShuffleStorage` flag. A combination of `selectDestination`:`durableStorage` and `durableShuffleStorage`:`false` for a select query is perfectly valid. ## Durable storage configurations diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/SqlStatementResourceHelper.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/SqlStatementResourceHelper.java index a11d40fbbcee..a498aad60af4 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/SqlStatementResourceHelper.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/SqlStatementResourceHelper.java @@ -61,7 +61,6 @@ import javax.annotation.Nullable; import java.util.ArrayList; import java.util.Arrays; -import java.util.Collections; import java.util.HashMap; import java.util.Iterator; import java.util.List; From b89e2cef1ebc57c89fcd53cff56a37cc67399dff Mon Sep 17 00:00:00 2001 From: cryptoe Date: Thu, 20 Jul 2023 20:08:42 +0530 Subject: [PATCH 3/3] Review comments --- docs/multi-stage-query/reference.md | 6 +++++- .../druid/msq/sql/resources/SqlStatementResource.java | 10 +++++----- .../druid/msq/sql/SqlMSQStatementResourcePostTest.java | 2 +- .../druid/msq/sql/entity/ResultSetInformationTest.java | 6 +++--- .../druid/msq/sql/entity/SqlStatementResultTest.java | 8 ++++---- .../java/org/apache/druid/query/QueryContexts.java | 2 +- 6 files changed, 19 insertions(+), 15 deletions(-) diff --git a/docs/multi-stage-query/reference.md b/docs/multi-stage-query/reference.md index 0a3fbbce976d..3fa179e1de2b 100644 --- a/docs/multi-stage-query/reference.md +++ b/docs/multi-stage-query/reference.md @@ -377,7 +377,11 @@ When you run a query, include the context parameter `durableShuffleStorage` and For queries where you want to use fault tolerance for workers, set `faultTolerance` to `true`, which automatically sets `durableShuffleStorage` to `true`. -For select queries where you want to write the final result to `durableStorage`, set `selectDestination`:`durableStorage`. Which shuffle mesh the job uses can still be controlled by `durableShuffleStorage` flag. A combination of `selectDestination`:`durableStorage` and `durableShuffleStorage`:`false` for a select query is perfectly valid. +Set `selectDestination`:`durableStorage` for select queries that want to write the final results to durable storage instead of the task reports. Saving the results in the durable +storage allows users to fetch large result sets. The location where the workers write the intermediate results is different than the location where final results get stored. Therefore, `durableShuffleStorage`:`false` and +`selectDestination`:`durableStorage` is a valid configuration to use in the query context, that instructs the controller to persist only the final result in the durable storage, and not the +intermediate results. + ## Durable storage configurations diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java index 2c92b94ac279..35ad2768158f 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java @@ -705,7 +705,7 @@ private Optional> getResultYielder( } else { selectedPageId = null; } - checkForDurableStorageConnectorImpl(NodeRole.BROKER); + checkForDurableStorageConnectorImpl(); final DurableStorageInputChannelFactory standardImplementation = DurableStorageInputChannelFactory.createStandardImplementation( msqControllerTask.getId(), storageConnector, @@ -850,11 +850,11 @@ private void contextChecks(QueryContext queryContext) MSQSelectDestination selectDestination = MultiStageQueryContext.getSelectDestination(queryContext); if (MSQSelectDestination.DURABLESTORAGE.equals(selectDestination)) { - checkForDurableStorageConnectorImpl(NodeRole.BROKER); + checkForDurableStorageConnectorImpl(); } } - private void checkForDurableStorageConnectorImpl(NodeRole nodeRole) + private void checkForDurableStorageConnectorImpl() { if (storageConnector instanceof NilStorageConnector) { throw DruidException.forPersona(DruidException.Persona.USER) @@ -862,12 +862,12 @@ private void checkForDurableStorageConnectorImpl(NodeRole nodeRole) .build( StringUtils.format( "The sql statement api cannot read from the select destination [%s] provided " - + "in the query context [%s] since it is not configured on the [%s]. It is recommended to configure durable storage " + + "in the query context [%s] since it is not configured on the %s. It is recommended to configure durable storage " + "as it allows the user to fetch large result sets. Please contact your cluster admin to " + "configure durable storage.", MSQSelectDestination.DURABLESTORAGE.getName(), MultiStageQueryContext.CTX_SELECT_DESTINATION, - nodeRole.getJsonName() + NodeRole.BROKER.getJsonName() ) ); } diff --git a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlMSQStatementResourcePostTest.java b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlMSQStatementResourcePostTest.java index 2d022f76f039..385b3a89b6b2 100644 --- a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlMSQStatementResourcePostTest.java +++ b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/SqlMSQStatementResourcePostTest.java @@ -274,7 +274,7 @@ public void durableStorageDisabledTest() ); String errorMessage = "The sql statement api cannot read from the select destination [durableStorage] provided in " - + "the query context [selectDestination] since it is not configured on the [broker]. It is recommended to " + + "the query context [selectDestination] since it is not configured on the broker. It is recommended to " + "configure durable storage as it allows the user to fetch large result sets. " + "Please contact your cluster admin to configure durable storage."; Map context = defaultAsyncContext(); diff --git a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/ResultSetInformationTest.java b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/ResultSetInformationTest.java index b9a1230ef15a..ce84ac91fd40 100644 --- a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/ResultSetInformationTest.java +++ b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/ResultSetInformationTest.java @@ -37,7 +37,7 @@ public class ResultSetInformationTest ResultFormat.OBJECT, "ds", null, - ImmutableList.of(new PageInformation(0, 1L, 1L)) + ImmutableList.of(new PageInformation(0, null, 1L)) ); @@ -53,7 +53,7 @@ public class ResultSetInformationTest ), ImmutableList.of(new PageInformation(0, 1L, 1L)) ); - public static final String JSON_STRING = "{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"pages\":[{\"id\":0,\"numRows\":1,\"sizeInBytes\":1}]}"; + public static final String JSON_STRING = "{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"pages\":[{\"id\":0,\"sizeInBytes\":1}]}"; public static final String JSON_STRING_1 = "{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"sampleRecords\":[[\"1\"],[\"2\"],[\"3\"]],\"pages\":[{\"id\":0,\"numRows\":1,\"sizeInBytes\":1}]}"; @Test @@ -66,7 +66,7 @@ public void sanityTest() throws JsonProcessingException MAPPER.readValue(MAPPER.writeValueAsString(RESULTS), ResultSetInformation.class).hashCode() ); Assert.assertEquals( - "ResultSetInformation{numTotalRows=1, totalSizeInBytes=1, resultFormat=object, records=null, dataSource='ds', pages=[PageInformation{id=0, numRows=1, sizeInBytes=1}]}", + "ResultSetInformation{numTotalRows=1, totalSizeInBytes=1, resultFormat=object, records=null, dataSource='ds', pages=[PageInformation{id=0, numRows=null, sizeInBytes=1}]}", RESULTS.toString() ); } diff --git a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/SqlStatementResultTest.java b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/SqlStatementResultTest.java index 9612d2a46fa2..9fd4a63b52b3 100644 --- a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/SqlStatementResultTest.java +++ b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/sql/entity/SqlStatementResultTest.java @@ -43,7 +43,7 @@ public class SqlStatementResultTest + "\"createdAt\":\"2023-05-31T12:00:00.000Z\"," + "\"schema\":[{\"name\":\"_time\",\"type\":\"TIMESTAMP\",\"nativeType\":\"LONG\"},{\"name\":\"alias\",\"type\":\"VARCHAR\",\"nativeType\":\"STRING\"},{\"name\":\"market\",\"type\":\"VARCHAR\",\"nativeType\":\"STRING\"}]," + "\"durationMs\":100," - + "\"result\":{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"pages\":[{\"id\":0,\"numRows\":1,\"sizeInBytes\":1}]}," + + "\"result\":{\"numTotalRows\":1,\"totalSizeInBytes\":1,\"resultFormat\":\"object\",\"dataSource\":\"ds\",\"pages\":[{\"id\":0,\"sizeInBytes\":1}]}," + "\"errorDetails\":{\"error\":\"druidException\",\"errorCode\":\"QueryNotSupported\",\"persona\":\"USER\",\"category\":\"UNCATEGORIZED\",\"errorMessage\":\"QueryNotSupported\",\"context\":{}}}"; public static final SqlStatementResult SQL_STATEMENT_RESULT = new SqlStatementResult( @@ -59,8 +59,8 @@ public class SqlStatementResultTest protected DruidException makeException(DruidException.DruidExceptionBuilder bob) { return bob.forPersona(DruidException.Persona.USER) - .ofCategory(DruidException.Category.UNCATEGORIZED) - .build(MSQ_EXCEPTION.getMessage()); + .ofCategory(DruidException.Category.UNCATEGORIZED) + .build(MSQ_EXCEPTION.getMessage()); } }).toErrorResponse() ); @@ -86,7 +86,7 @@ public void sanityTest() throws JsonProcessingException + " createdAt=2023-05-31T12:00:00.000Z," + " sqlRowSignature=[ColumnNameAndTypes{colName='_time', sqlTypeName='TIMESTAMP', nativeTypeName='LONG'}, ColumnNameAndTypes{colName='alias', sqlTypeName='VARCHAR', nativeTypeName='STRING'}, ColumnNameAndTypes{colName='market', sqlTypeName='VARCHAR', nativeTypeName='STRING'}]," + " durationInMs=100," - + " resultSetInformation=ResultSetInformation{numTotalRows=1, totalSizeInBytes=1, resultFormat=object, records=null, dataSource='ds', pages=[PageInformation{id=0, numRows=1, sizeInBytes=1}]}," + + " resultSetInformation=ResultSetInformation{numTotalRows=1, totalSizeInBytes=1, resultFormat=object, records=null, dataSource='ds', pages=[PageInformation{id=0, numRows=null, sizeInBytes=1}]}," + " errorResponse={error=druidException, errorCode=QueryNotSupported, persona=USER, category=UNCATEGORIZED, errorMessage=QueryNotSupported, context={}}}", SQL_STATEMENT_RESULT.toString() ); diff --git a/processing/src/main/java/org/apache/druid/query/QueryContexts.java b/processing/src/main/java/org/apache/druid/query/QueryContexts.java index e6ac3496c070..7d39edfde66a 100644 --- a/processing/src/main/java/org/apache/druid/query/QueryContexts.java +++ b/processing/src/main/java/org/apache/druid/query/QueryContexts.java @@ -457,7 +457,7 @@ public static > E getAsEnum(String key, Object value, Class throw badValueException( key, StringUtils.format( - "referring to one of the values[%s] of enum [%s]", + "referring to one of the values [%s] of enum [%s]", Arrays.stream(clazz.getEnumConstants()).map(E::name).collect( Collectors.joining(",")), clazz.getSimpleName()