From 0da7c56cc599ef3a3b71721482c4071c241e686a Mon Sep 17 00:00:00 2001 From: cryptoe Date: Wed, 13 Mar 2024 17:15:34 +0530 Subject: [PATCH 1/2] Better retryable stream s3 logging --- .../druid/storage/s3/output/RetryableS3OutputStream.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java b/extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java index 82f5cd812cc9..e5e84261ec02 100644 --- a/extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java +++ b/extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java @@ -269,7 +269,12 @@ public void close() throws IOException // Closeables are closed in LIFO order closer.register(() -> { // This should be emitted as a metric - LOG.info("Total push time: [%d] ms", pushStopwatch.elapsed(TimeUnit.MILLISECONDS)); + LOG.info( + "Total: %d parts has a push time: %d ms with cumulative size: %d bytes ", + numChunksPushed, + pushStopwatch.elapsed(TimeUnit.MILLISECONDS), + resultsSize + ); }); closer.register(() -> org.apache.commons.io.FileUtils.forceDelete(chunkStorePath)); From d6d8d4798543870cc0db3f442ed6f2a42e470c2c Mon Sep 17 00:00:00 2001 From: cryptoe Date: Wed, 13 Mar 2024 18:00:14 +0530 Subject: [PATCH 2/2] Adding suggestions --- .../druid/storage/s3/output/RetryableS3OutputStream.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java b/extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java index e5e84261ec02..c71bb4e788b7 100644 --- a/extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java +++ b/extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java @@ -270,10 +270,10 @@ public void close() throws IOException closer.register(() -> { // This should be emitted as a metric LOG.info( - "Total: %d parts has a push time: %d ms with cumulative size: %d bytes ", + "Pushed total [%d] parts containing [%d] bytes in [%d]ms.", numChunksPushed, - pushStopwatch.elapsed(TimeUnit.MILLISECONDS), - resultsSize + resultsSize, + pushStopwatch.elapsed(TimeUnit.MILLISECONDS) ); });