From 8bac73783bf1a6341e428159049ee563ee9a3e0d Mon Sep 17 00:00:00 2001 From: Akshat Jain Date: Fri, 16 Aug 2024 12:41:20 +0530 Subject: [PATCH 1/2] Propagate TooManyRowsInAWindowFault error message properly to the user --- .../main/java/org/apache/druid/msq/guice/MSQIndexingModule.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQIndexingModule.java b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQIndexingModule.java index 01a8743dd865..4e28edc3ac16 100644 --- a/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQIndexingModule.java +++ b/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQIndexingModule.java @@ -60,6 +60,7 @@ import org.apache.druid.msq.indexing.error.TooManyColumnsFault; import org.apache.druid.msq.indexing.error.TooManyInputFilesFault; import org.apache.druid.msq.indexing.error.TooManyPartitionsFault; +import org.apache.druid.msq.indexing.error.TooManyRowsInAWindowFault; import org.apache.druid.msq.indexing.error.TooManyRowsWithSameKeyFault; import org.apache.druid.msq.indexing.error.TooManySegmentsInTimeChunkFault; import org.apache.druid.msq.indexing.error.TooManyWarningsFault; @@ -128,6 +129,7 @@ public class MSQIndexingModule implements DruidModule TooManyColumnsFault.class, TooManyInputFilesFault.class, TooManyPartitionsFault.class, + TooManyRowsInAWindowFault.class, TooManyRowsWithSameKeyFault.class, TooManySegmentsInTimeChunkFault.class, TooManyWarningsFault.class, From 7277133e9645015228327d2e513013783a576345 Mon Sep 17 00:00:00 2001 From: Akshat Jain Date: Fri, 16 Aug 2024 17:18:41 +0530 Subject: [PATCH 2/2] Add TooManyRowsInAWindowFault to MSQFaultSerdeTest --- .../org/apache/druid/msq/indexing/error/MSQFaultSerdeTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/error/MSQFaultSerdeTest.java b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/error/MSQFaultSerdeTest.java index cffc0f78a497..0c16ae08af5d 100644 --- a/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/error/MSQFaultSerdeTest.java +++ b/extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/error/MSQFaultSerdeTest.java @@ -85,6 +85,7 @@ public void testFaultSerde() throws IOException assertFaultSerde(new TooManyClusteredByColumnsFault(10, 8, 1)); assertFaultSerde(new TooManyInputFilesFault(15, 10, 5)); assertFaultSerde(new TooManyPartitionsFault(10)); + assertFaultSerde(new TooManyRowsInAWindowFault(10, 20)); assertFaultSerde(new TooManyRowsWithSameKeyFault(Arrays.asList("foo", 123), 1, 2)); assertFaultSerde(new TooManySegmentsInTimeChunkFault(DateTimes.nowUtc(), 10, 1, Granularities.ALL)); assertFaultSerde(new TooManyWarningsFault(10, "the error"));