From f174d942865e6b1b6e4e847ecc1af5810058b2cd Mon Sep 17 00:00:00 2001
From: Akshat Jain <akjn11@gmail.com>
Date: Wed, 13 Nov 2024 12:36:37 +0530
Subject: [PATCH 1/5] Remove intellij-inspections check from CI

---
 .github/workflows/static-checks.yml | 32 -----------------------------
 1 file changed, 32 deletions(-)

diff --git a/.github/workflows/static-checks.yml b/.github/workflows/static-checks.yml
index 6ece670dae2b..f32b362f84d9 100644
--- a/.github/workflows/static-checks.yml
+++ b/.github/workflows/static-checks.yml
@@ -113,38 +113,6 @@ jobs:
         if: ${{ matrix.java == '8' }}
         run: ${MVN} spotbugs:check --fail-at-end -pl '!benchmarks'
 
-  intellij-inspections:
-    strategy:
-      fail-fast: false
-    runs-on: ubuntu-latest
-    steps:
-      - name: checkout branch
-        uses: actions/checkout@v4
-
-      - uses: actions/setup-java@v4
-        with:
-          distribution: 'zulu'
-          java-version: '8'
-          cache: 'maven'
-
-      - name: maven install
-        run: |
-          echo 'Running Maven install...' &&
-          ${MVN} clean install -q -ff -pl '!distribution' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS} -T1C &&
-          ${MVN} install -q -ff -pl 'distribution' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS}
-
-      - name: intellij inspections
-        run: |
-          docker run --rm \
-          -v $(pwd):/project \
-          -v ~/.m2:/home/inspect/.m2 \
-          -v $(pwd)/.idea/misc-for-inspection.xml:/project/.idea/misc.xml \
-          ccaominh/intellij-inspect:1.0.0 \
-          /project/pom.xml \
-          /project/.idea/inspectionProfiles/Druid.xml \
-          --levels ERROR \
-          --scope JavaInspectionsScope
-
   openrewrite:
     runs-on: ubuntu-latest
     steps:

From 81e20c8190f344eb841cd655816ff59dfb71e46c Mon Sep 17 00:00:00 2001
From: Akshat Jain <akjn11@gmail.com>
Date: Wed, 13 Nov 2024 12:58:14 +0530
Subject: [PATCH 2/5] Remove misc-for-inspection.xml

---
 .idea/misc-for-inspection.xml | 91 -----------------------------------
 1 file changed, 91 deletions(-)
 delete mode 100644 .idea/misc-for-inspection.xml

diff --git a/.idea/misc-for-inspection.xml b/.idea/misc-for-inspection.xml
deleted file mode 100644
index f890d06f1fe6..000000000000
--- a/.idea/misc-for-inspection.xml
+++ /dev/null
@@ -1,91 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project version="4">
-  <component name="EntryPointsManager">
-    <list size="14">
-      <item index="0" class="java.lang.String" itemvalue="com.fasterxml.jackson.annotation.JsonCreator" />
-      <item index="1" class="java.lang.String" itemvalue="com.fasterxml.jackson.annotation.JsonProperty" />
-      <item index="2" class="java.lang.String" itemvalue="com.fasterxml.jackson.annotation.JsonValue" />
-      <item index="3" class="java.lang.String" itemvalue="com.google.inject.Inject" />
-      <item index="4" class="java.lang.String" itemvalue="com.google.inject.Provides" />
-      <item index="5" class="java.lang.String" itemvalue="io.airlift.airline.Command" />
-      <item index="6" class="java.lang.String" itemvalue="org.apache.druid.annotations.UsedByJUnitParamsRunner" />
-      <item index="7" class="java.lang.String" itemvalue="org.apache.druid.annotations.UsedInGeneratedCode" />
-      <item index="8" class="java.lang.String" itemvalue="org.apache.druid.guice.annotations.ExtensionPoint" />
-      <item index="9" class="java.lang.String" itemvalue="org.apache.druid.guice.annotations.PublicApi" />
-      <item index="10" class="java.lang.String" itemvalue="org.apache.druid.java.util.common.lifecycle.LifecycleStart" />
-      <item index="11" class="java.lang.String" itemvalue="org.apache.druid.java.util.common.lifecycle.LifecycleStop" />
-      <item index="12" class="java.lang.String" itemvalue="javax.inject.Inject" />
-      <item index="13" class="java.lang.String" itemvalue="org.openjdk.jmh.annotations.Benchmark" />
-    </list>
-    <pattern value="org.apache.druid.cli.GuiceRunnable" hierarchically="true" method="run" />
-    <pattern value="org.apache.druid.cli.GuiceRunnable" hierarchically="true" />
-    <pattern value="org.apache.druid.initialization.DruidModule" hierarchically="true" method="getJacksonModules" />
-    <writeAnnotations>
-      <writeAnnotation name="com.fasterxml.jackson.annotation.JacksonInject" />
-      <writeAnnotation name="com.fasterxml.jackson.annotation.JsonProperty" />
-      <writeAnnotation name="com.google.caliper.Param" />
-      <writeAnnotation name="io.airlift.airline.Option" />
-      <writeAnnotation name="org.easymock.Mock" />
-      <writeAnnotation name="org.mockito.Mock" />
-      <writeAnnotation name="org.openjdk.jmh.annotations.Param" />
-      <writeAnnotation name="org.powermock.api.easymock.annotation.Mock" />
-    </writeAnnotations>
-  </component>
-  <component name="JavaScriptSettings">
-    <option name="languageLevel" value="ES6" />
-  </component>
-  <component name="MavenProjectsManager">
-    <option name="originalFiles">
-      <list>
-        <option value="$PROJECT_DIR$/pom.xml" />
-      </list>
-    </option>
-  </component>
-  <component name="NullableNotNullManager">
-    <option name="myDefaultNullable" value="javax.annotation.Nullable" />
-    <option name="myDefaultNotNull" value="javax.annotation.Nonnull" />
-    <option name="myNullables">
-      <value>
-        <list size="12">
-          <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.Nullable" />
-          <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nullable" />
-          <item index="2" class="java.lang.String" itemvalue="javax.annotation.CheckForNull" />
-          <item index="3" class="java.lang.String" itemvalue="org.springframework.lang.Nullable" />
-          <item index="4" class="java.lang.String" itemvalue="edu.umd.cs.findbugs.annotations.Nullable" />
-          <item index="5" class="java.lang.String" itemvalue="android.support.annotation.Nullable" />
-          <item index="6" class="java.lang.String" itemvalue="androidx.annotation.Nullable" />
-          <item index="7" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.qual.Nullable" />
-          <item index="8" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NullableDecl" />
-          <item index="9" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NullableType" />
-          <item index="10" class="java.lang.String" itemvalue="androidx.annotation.RecentlyNullable" />
-          <item index="11" class="java.lang.String" itemvalue="com.android.annotations.Nullable" />
-        </list>
-      </value>
-    </option>
-    <option name="myNotNulls">
-      <value>
-        <list size="11">
-          <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.NotNull" />
-          <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nonnull" />
-          <item index="2" class="java.lang.String" itemvalue="edu.umd.cs.findbugs.annotations.NonNull" />
-          <item index="3" class="java.lang.String" itemvalue="android.support.annotation.NonNull" />
-          <item index="4" class="java.lang.String" itemvalue="javax.validation.constraints.NotNull" />
-          <item index="5" class="java.lang.String" itemvalue="androidx.annotation.NonNull" />
-          <item index="6" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.qual.NonNull" />
-          <item index="7" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NonNullDecl" />
-          <item index="8" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NonNullType" />
-          <item index="9" class="java.lang.String" itemvalue="androidx.annotation.RecentlyNonNull" />
-          <item index="10" class="java.lang.String" itemvalue="com.android.annotations.NonNull" />
-        </list>
-      </value>
-    </option>
-  </component>
-  <component name="ProjectResources">
-    <resource url="http://maven.apache.org/ASSEMBLY/2.0.0" location="$PROJECT_DIR$/.idea/xml-schemas/assembly-2.0.0.xsd" />
-    <resource url="http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd" location="$PROJECT_DIR$/.idea/xml-schemas/svg11.dtd" />
-  </component>
-  <component name="ProjectRootManager" version="2" languageLevel="JDK_1_8" default="false" project-jdk-name="1.8" project-jdk-type="JavaSDK">
-    <output url="file://$PROJECT_DIR$/classes" />
-  </component>
-</project>
-

From 01d0d304b832626fe515d718d0415c8da89a7d5c Mon Sep 17 00:00:00 2001
From: Akshat Jain <akjn11@gmail.com>
Date: Wed, 13 Nov 2024 13:09:44 +0530
Subject: [PATCH 3/5] Remove JavaInspectionsScope.xml

---
 .idea/scopes/JavaInspectionsScope.xml | 3 ---
 1 file changed, 3 deletions(-)
 delete mode 100644 .idea/scopes/JavaInspectionsScope.xml

diff --git a/.idea/scopes/JavaInspectionsScope.xml b/.idea/scopes/JavaInspectionsScope.xml
deleted file mode 100644
index b4dff3d5c6f8..000000000000
--- a/.idea/scopes/JavaInspectionsScope.xml
+++ /dev/null
@@ -1,3 +0,0 @@
-<component name="DependencyValidationManager">
-  <scope name="JavaInspectionsScope" pattern="file:*.java||file:pom.xml" />
-</component>
\ No newline at end of file

From dd128840f552d07243d7bfc9577343485d2b65c1 Mon Sep 17 00:00:00 2001
From: Akshat Jain <akjn11@gmail.com>
Date: Wed, 13 Nov 2024 14:19:22 +0530
Subject: [PATCH 4/5] Revert "Remove JavaInspectionsScope.xml"

This reverts commit 01d0d304b832626fe515d718d0415c8da89a7d5c.
---
 .idea/scopes/JavaInspectionsScope.xml | 3 +++
 1 file changed, 3 insertions(+)
 create mode 100644 .idea/scopes/JavaInspectionsScope.xml

diff --git a/.idea/scopes/JavaInspectionsScope.xml b/.idea/scopes/JavaInspectionsScope.xml
new file mode 100644
index 000000000000..b4dff3d5c6f8
--- /dev/null
+++ b/.idea/scopes/JavaInspectionsScope.xml
@@ -0,0 +1,3 @@
+<component name="DependencyValidationManager">
+  <scope name="JavaInspectionsScope" pattern="file:*.java||file:pom.xml" />
+</component>
\ No newline at end of file

From 814bbedf93f53b128534260b21d82b885f7bd8d8 Mon Sep 17 00:00:00 2001
From: Akshat Jain <akjn11@gmail.com>
Date: Wed, 13 Nov 2024 14:19:36 +0530
Subject: [PATCH 5/5] Revert "Remove misc-for-inspection.xml"

This reverts commit 81e20c8190f344eb841cd655816ff59dfb71e46c.
---
 .idea/misc-for-inspection.xml | 91 +++++++++++++++++++++++++++++++++++
 1 file changed, 91 insertions(+)
 create mode 100644 .idea/misc-for-inspection.xml

diff --git a/.idea/misc-for-inspection.xml b/.idea/misc-for-inspection.xml
new file mode 100644
index 000000000000..f890d06f1fe6
--- /dev/null
+++ b/.idea/misc-for-inspection.xml
@@ -0,0 +1,91 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="EntryPointsManager">
+    <list size="14">
+      <item index="0" class="java.lang.String" itemvalue="com.fasterxml.jackson.annotation.JsonCreator" />
+      <item index="1" class="java.lang.String" itemvalue="com.fasterxml.jackson.annotation.JsonProperty" />
+      <item index="2" class="java.lang.String" itemvalue="com.fasterxml.jackson.annotation.JsonValue" />
+      <item index="3" class="java.lang.String" itemvalue="com.google.inject.Inject" />
+      <item index="4" class="java.lang.String" itemvalue="com.google.inject.Provides" />
+      <item index="5" class="java.lang.String" itemvalue="io.airlift.airline.Command" />
+      <item index="6" class="java.lang.String" itemvalue="org.apache.druid.annotations.UsedByJUnitParamsRunner" />
+      <item index="7" class="java.lang.String" itemvalue="org.apache.druid.annotations.UsedInGeneratedCode" />
+      <item index="8" class="java.lang.String" itemvalue="org.apache.druid.guice.annotations.ExtensionPoint" />
+      <item index="9" class="java.lang.String" itemvalue="org.apache.druid.guice.annotations.PublicApi" />
+      <item index="10" class="java.lang.String" itemvalue="org.apache.druid.java.util.common.lifecycle.LifecycleStart" />
+      <item index="11" class="java.lang.String" itemvalue="org.apache.druid.java.util.common.lifecycle.LifecycleStop" />
+      <item index="12" class="java.lang.String" itemvalue="javax.inject.Inject" />
+      <item index="13" class="java.lang.String" itemvalue="org.openjdk.jmh.annotations.Benchmark" />
+    </list>
+    <pattern value="org.apache.druid.cli.GuiceRunnable" hierarchically="true" method="run" />
+    <pattern value="org.apache.druid.cli.GuiceRunnable" hierarchically="true" />
+    <pattern value="org.apache.druid.initialization.DruidModule" hierarchically="true" method="getJacksonModules" />
+    <writeAnnotations>
+      <writeAnnotation name="com.fasterxml.jackson.annotation.JacksonInject" />
+      <writeAnnotation name="com.fasterxml.jackson.annotation.JsonProperty" />
+      <writeAnnotation name="com.google.caliper.Param" />
+      <writeAnnotation name="io.airlift.airline.Option" />
+      <writeAnnotation name="org.easymock.Mock" />
+      <writeAnnotation name="org.mockito.Mock" />
+      <writeAnnotation name="org.openjdk.jmh.annotations.Param" />
+      <writeAnnotation name="org.powermock.api.easymock.annotation.Mock" />
+    </writeAnnotations>
+  </component>
+  <component name="JavaScriptSettings">
+    <option name="languageLevel" value="ES6" />
+  </component>
+  <component name="MavenProjectsManager">
+    <option name="originalFiles">
+      <list>
+        <option value="$PROJECT_DIR$/pom.xml" />
+      </list>
+    </option>
+  </component>
+  <component name="NullableNotNullManager">
+    <option name="myDefaultNullable" value="javax.annotation.Nullable" />
+    <option name="myDefaultNotNull" value="javax.annotation.Nonnull" />
+    <option name="myNullables">
+      <value>
+        <list size="12">
+          <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.Nullable" />
+          <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nullable" />
+          <item index="2" class="java.lang.String" itemvalue="javax.annotation.CheckForNull" />
+          <item index="3" class="java.lang.String" itemvalue="org.springframework.lang.Nullable" />
+          <item index="4" class="java.lang.String" itemvalue="edu.umd.cs.findbugs.annotations.Nullable" />
+          <item index="5" class="java.lang.String" itemvalue="android.support.annotation.Nullable" />
+          <item index="6" class="java.lang.String" itemvalue="androidx.annotation.Nullable" />
+          <item index="7" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.qual.Nullable" />
+          <item index="8" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NullableDecl" />
+          <item index="9" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NullableType" />
+          <item index="10" class="java.lang.String" itemvalue="androidx.annotation.RecentlyNullable" />
+          <item index="11" class="java.lang.String" itemvalue="com.android.annotations.Nullable" />
+        </list>
+      </value>
+    </option>
+    <option name="myNotNulls">
+      <value>
+        <list size="11">
+          <item index="0" class="java.lang.String" itemvalue="org.jetbrains.annotations.NotNull" />
+          <item index="1" class="java.lang.String" itemvalue="javax.annotation.Nonnull" />
+          <item index="2" class="java.lang.String" itemvalue="edu.umd.cs.findbugs.annotations.NonNull" />
+          <item index="3" class="java.lang.String" itemvalue="android.support.annotation.NonNull" />
+          <item index="4" class="java.lang.String" itemvalue="javax.validation.constraints.NotNull" />
+          <item index="5" class="java.lang.String" itemvalue="androidx.annotation.NonNull" />
+          <item index="6" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.qual.NonNull" />
+          <item index="7" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NonNullDecl" />
+          <item index="8" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NonNullType" />
+          <item index="9" class="java.lang.String" itemvalue="androidx.annotation.RecentlyNonNull" />
+          <item index="10" class="java.lang.String" itemvalue="com.android.annotations.NonNull" />
+        </list>
+      </value>
+    </option>
+  </component>
+  <component name="ProjectResources">
+    <resource url="http://maven.apache.org/ASSEMBLY/2.0.0" location="$PROJECT_DIR$/.idea/xml-schemas/assembly-2.0.0.xsd" />
+    <resource url="http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd" location="$PROJECT_DIR$/.idea/xml-schemas/svg11.dtd" />
+  </component>
+  <component name="ProjectRootManager" version="2" languageLevel="JDK_1_8" default="false" project-jdk-name="1.8" project-jdk-type="JavaSDK">
+    <output url="file://$PROJECT_DIR$/classes" />
+  </component>
+</project>
+