From 7006e24e3c3911aa571f9c0e7ecfc0b40f0f56ce Mon Sep 17 00:00:00 2001 From: Akshat Jain Date: Wed, 19 Mar 2025 19:44:41 +0530 Subject: [PATCH] CI improvement: Leverage cancelled() instead of always() for CI jobs --- .github/workflows/unit-and-integration-tests-unified.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/unit-and-integration-tests-unified.yml b/.github/workflows/unit-and-integration-tests-unified.yml index 15eb29df604e..e15bdaa278ec 100644 --- a/.github/workflows/unit-and-integration-tests-unified.yml +++ b/.github/workflows/unit-and-integration-tests-unified.yml @@ -209,12 +209,12 @@ jobs: standard-its: needs: [build, unit-tests-unapproved, check-approval] - if: ${{ always() && (needs.check-approval.outputs.approved == 'true' || needs.unit-tests-unapproved.result == 'success') }} + if: ${{ !cancelled() && (needs.check-approval.outputs.approved == 'true' || needs.unit-tests-unapproved.result == 'success') }} uses: ./.github/workflows/standard-its.yml revised-its: needs: [build, unit-tests-unapproved, check-approval] - if: ${{ always() && (needs.check-approval.outputs.approved == 'true' || needs.unit-tests-unapproved.result == 'success') }} + if: ${{ !cancelled() && (needs.check-approval.outputs.approved == 'true' || needs.unit-tests-unapproved.result == 'success') }} uses: ./.github/workflows/revised-its.yml with: BACKWARD_COMPATIBILITY_IT_ENABLED: ${{ needs.set-env-var.outputs.BACKWARD_COMPATIBILITY_IT_ENABLED }} @@ -225,6 +225,6 @@ jobs: actions-timeline: needs: [build, unit-tests-approved, unit-tests-unapproved, revised-its, standard-its] runs-on: ubuntu-latest - if: ${{ always() }} + if: ${{ !cancelled() }} steps: - uses: Kesin11/actions-timeline@427ee2cf860166e404d0d69b4f2b24012bb7af4f