From 91fc32749b3ce4294db60b8af869eb7f3e83f928 Mon Sep 17 00:00:00 2001 From: Charles Allen Date: Mon, 4 Jan 2016 11:17:36 -0800 Subject: [PATCH] Make OnHeapIncrementalIndex clean maps on close() --- .../segment/incremental/OnheapIncrementalIndex.java | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/processing/src/main/java/io/druid/segment/incremental/OnheapIncrementalIndex.java b/processing/src/main/java/io/druid/segment/incremental/OnheapIncrementalIndex.java index 1930463ca2e7..87516bedfa7e 100644 --- a/processing/src/main/java/io/druid/segment/incremental/OnheapIncrementalIndex.java +++ b/processing/src/main/java/io/druid/segment/incremental/OnheapIncrementalIndex.java @@ -243,6 +243,18 @@ public Object getMetricObjectValue(int rowOffset, int aggOffset) return concurrentGet(rowOffset)[aggOffset].get(); } + /** + * Clear out maps to allow GC + * NOTE: This is NOT thread-safe with add... so make sure all the adding is DONE before closing + */ + @Override + public void close() + { + super.close(); + aggregators.clear(); + facts.clear(); + } + private static class OnHeapDimDim implements DimDim { private final Map falseIds;