From bf158102c41dc134a16c5c6cbcdc51923759e49c Mon Sep 17 00:00:00 2001 From: Gian Merlino Date: Tue, 7 Jan 2014 07:17:19 -0800 Subject: [PATCH] IndexTask: Print metrics even if finishJob fails --- .../druid/indexing/common/task/IndexTask.java | 27 ++++++++++--------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/indexing-service/src/main/java/io/druid/indexing/common/task/IndexTask.java b/indexing-service/src/main/java/io/druid/indexing/common/task/IndexTask.java index 6e09e46373c2..f4265ca1d1f9 100644 --- a/indexing-service/src/main/java/io/druid/indexing/common/task/IndexTask.java +++ b/indexing-service/src/main/java/io/druid/indexing/common/task/IndexTask.java @@ -368,18 +368,21 @@ public DataSegment push(File file, DataSegment segment) throws IOException } plumber.persist(firehose.commit()); - plumber.finishJob(); - - // Output metrics - log.info( - "Task[%s] took in %,d rows (%,d processed, %,d unparseable, %,d thrown away) and output %,d rows", - getId(), - metrics.processed() + metrics.unparseable() + metrics.thrownAway(), - metrics.processed(), - metrics.unparseable(), - metrics.thrownAway(), - metrics.rowOutput() - ); + + try { + plumber.finishJob(); + } + finally { + log.info( + "Task[%s] took in %,d rows (%,d processed, %,d unparseable, %,d thrown away) and output %,d rows", + getId(), + metrics.processed() + metrics.unparseable() + metrics.thrownAway(), + metrics.processed(), + metrics.unparseable(), + metrics.thrownAway(), + metrics.rowOutput() + ); + } // We expect a single segment to have been created. return Iterables.getOnlyElement(pushedSegments);