From 3a111525f851fb003bee878275dc83311f4c1d7f Mon Sep 17 00:00:00 2001 From: Gian Merlino Date: Tue, 21 Feb 2017 13:52:17 -0800 Subject: [PATCH] CachingClusteredClientTest: Use groupBy v1. GroupBy v2 doesn't cache on the broker, so it isn't actually testing what the test was supposed to be testing. Also, the test failed due to mismatched expectations. --- .../java/io/druid/client/CachingClusteredClientTest.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/server/src/test/java/io/druid/client/CachingClusteredClientTest.java b/server/src/test/java/io/druid/client/CachingClusteredClientTest.java index 61cb2e5e404e..4e8376f23d18 100644 --- a/server/src/test/java/io/druid/client/CachingClusteredClientTest.java +++ b/server/src/test/java/io/druid/client/CachingClusteredClientTest.java @@ -92,6 +92,7 @@ import io.druid.query.groupby.GroupByQuery; import io.druid.query.groupby.GroupByQueryConfig; import io.druid.query.groupby.GroupByQueryRunnerTest; +import io.druid.query.groupby.strategy.GroupByStrategySelector; import io.druid.query.ordering.StringComparators; import io.druid.query.search.SearchQueryQueryToolChest; import io.druid.query.search.SearchResultValue; @@ -158,7 +159,12 @@ @RunWith(Parameterized.class) public class CachingClusteredClientTest { - public static final ImmutableMap CONTEXT = ImmutableMap.of("finalize", false); + public static final ImmutableMap CONTEXT = ImmutableMap.of( + "finalize", false, + + // GroupBy v2 won't cache on the broker, so test with v1. + "groupByStrategy", GroupByStrategySelector.STRATEGY_V1 + ); public static final MultipleIntervalSegmentSpec SEG_SPEC = new MultipleIntervalSegmentSpec(ImmutableList.of()); public static final String DATA_SOURCE = "test"; static final DefaultObjectMapper jsonMapper = new DefaultObjectMapper(new SmileFactory());