From f301982432ec44b680f1e97b749e004ec12fabfb Mon Sep 17 00:00:00 2001 From: leventov Date: Fri, 26 May 2017 16:29:46 -0500 Subject: [PATCH 1/5] Add PMD and prohibit unnecessary fully qualified class names in code --- .idea/inspectionProfiles/Druid.xml | 6 +++++ .idea/scopes/NonGeneratedFiles.xml | 3 +++ ...figDrivenAwsCredentialsConfigProvider.java | 5 ++-- .../LazyFileSessionCredentialsProvider.java | 3 ++- .../io/druid/collections/TestIntegerSet.java | 2 +- .../io/druid/common/config/Log4jShutdown.java | 3 ++- .../druid/extendedset/intset/ConciseSet.java | 3 ++- .../intset/ImmutableConciseSet.java | 3 ++- .../cassandra/CassandraDruidModule.java | 5 ++-- .../input/orc/OrcIndexGeneratorJobTest.java | 3 ++- .../SQLServerMetadataStorageModule.java | 3 ++- .../input/AvroStreamInputRowParserTest.java | 3 ++- .../io/druid/client/cache/CaffeineCache.java | 2 +- .../lookup/KafkaLookupExtractorFactory.java | 3 ++- .../lookup/TestKafkaExtractionCluster.java | 3 ++- .../mysql/MySQLMetadataStorageModule.java | 3 ++- .../PostgreSQLMetadataStorageModule.java | 3 ++- .../storage/s3/S3StorageDruidModule.java | 3 ++- .../hadoop/DatasourceInputFormatTest.java | 12 +++++----- .../common/actions/SegmentInsertAction.java | 3 +-- .../config/ForkingTaskRunnerConfigTest.java | 7 +++--- .../druid/java/util/common/StringUtils.java | 2 +- .../util/common/CompressionUtilsTest.java | 5 ++-- .../java/util/common/StringUtilsTest.java | 7 +++--- .../common/parsers/JavaScriptParserTest.java | 3 ++- pom.xml | 23 +++++++++++++++++++ .../query/topn/NumericTopNMetricSpec.java | 3 ++- .../io/druid/guice/GuiceInjectorsTest.java | 3 ++- .../StringFormatExtractionFnTest.java | 4 +++- .../spec/SpecificSegmentQueryRunnerTest.java | 3 ++- .../main/java/io/druid/client/CacheUtil.java | 3 ++- .../druid/client/HttpServerInventoryView.java | 2 +- .../guice/LocalDataStorageDruidModule.java | 5 ++-- .../java/io/druid/guice/ServerModule.java | 3 ++- .../announcer/ListenerDiscoverer.java | 2 +- .../druid/client/cache/CacheConfigTest.java | 11 +++++---- .../selector/TierSelectorStrategyTest.java | 3 ++- .../CuratorInventoryManagerTest.java | 3 ++- .../AsyncQueryForwardingServletTest.java | 3 ++- .../io/druid/server/QueryResourceTest.java | 3 ++- .../server/log/LoggingRequestLoggerTest.java | 5 ++-- .../cache/LookupCoordinatorManagerTest.java | 3 ++- .../io/druid/sql/calcite/rel/QueryMaker.java | 5 ++-- 43 files changed, 125 insertions(+), 60 deletions(-) create mode 100644 .idea/scopes/NonGeneratedFiles.xml diff --git a/.idea/inspectionProfiles/Druid.xml b/.idea/inspectionProfiles/Druid.xml index c820649923e1..51907d624f99 100644 --- a/.idea/inspectionProfiles/Druid.xml +++ b/.idea/inspectionProfiles/Druid.xml @@ -17,6 +17,12 @@