From 1a112863bff8495ff9d2a2bc7bcbd5d0dd3ed505 Mon Sep 17 00:00:00 2001
From: leventov <leventov@ya.ru>
Date: Mon, 3 Jul 2017 21:02:40 -0500
Subject: [PATCH] Incorrect use of Long.TYPE and Float.TYPE as return type of
 ObjectColumnSelector.classOfObject()

---
 codestyle/checkstyle.xml                               |  5 +++++
 .../io/druid/segment/QueryableIndexStorageAdapter.java |  4 ++--
 .../io/druid/segment/incremental/IncrementalIndex.java |  4 ++--
 .../incremental/IncrementalIndexStorageAdapter.java    |  2 +-
 .../druid/query/aggregation/MetricSelectorUtils.java   |  2 +-
 .../incremental/OnheapIncrementalIndexBenchmark.java   | 10 +++++-----
 6 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/codestyle/checkstyle.xml b/codestyle/checkstyle.xml
index 17570da445dd..fc79f49e9084 100644
--- a/codestyle/checkstyle.xml
+++ b/codestyle/checkstyle.xml
@@ -71,5 +71,10 @@
       <property name="illegalPattern" value="true"/>
       <property name="message" value="Use Comparators.naturalNullsFirst() instead of Ordering.natural().nullsFirst()"/>
     </module>
+    <module name="Regexp">
+      <property name="format" value="(Byte|Character|Short|Integer|Long|Float|Double)\.TYPE"/>
+      <property name="illegalPattern" value="true"/>
+      <property name="message" value="Use primitive.class instead. But check twice that you don't actually need BoxedPrimitive.class instead of BoxedPrimitive.TYPE"/>
+    </module>
   </module>
 </module>
diff --git a/processing/src/main/java/io/druid/segment/QueryableIndexStorageAdapter.java b/processing/src/main/java/io/druid/segment/QueryableIndexStorageAdapter.java
index fac3004b6e0c..a71223ad7fa2 100644
--- a/processing/src/main/java/io/druid/segment/QueryableIndexStorageAdapter.java
+++ b/processing/src/main/java/io/druid/segment/QueryableIndexStorageAdapter.java
@@ -669,7 +669,7 @@ public ObjectColumnSelector makeObjectColumnSelector(String column)
                             @Override
                             public Class classOfObject()
                             {
-                              return Float.TYPE;
+                              return Float.class;
                             }
 
                             @Override
@@ -685,7 +685,7 @@ public Float get()
                             @Override
                             public Class classOfObject()
                             {
-                              return Long.TYPE;
+                              return Long.class;
                             }
 
                             @Override
diff --git a/processing/src/main/java/io/druid/segment/incremental/IncrementalIndex.java b/processing/src/main/java/io/druid/segment/incremental/IncrementalIndex.java
index c35ae9859e5e..da208a2bbf78 100644
--- a/processing/src/main/java/io/druid/segment/incremental/IncrementalIndex.java
+++ b/processing/src/main/java/io/druid/segment/incremental/IncrementalIndex.java
@@ -659,9 +659,9 @@ public Class getMetricClass(String metric)
       case COMPLEX:
         return ComplexMetrics.getSerdeForType(metricDesc.getType()).getObjectStrategy().getClazz();
       case FLOAT:
-        return Float.TYPE;
+        return Float.class;
       case LONG:
-        return Long.TYPE;
+        return Long.class;
       case STRING:
         return String.class;
     }
diff --git a/processing/src/main/java/io/druid/segment/incremental/IncrementalIndexStorageAdapter.java b/processing/src/main/java/io/druid/segment/incremental/IncrementalIndexStorageAdapter.java
index 3a19b4797bf1..8c4681806f70 100644
--- a/processing/src/main/java/io/druid/segment/incremental/IncrementalIndexStorageAdapter.java
+++ b/processing/src/main/java/io/druid/segment/incremental/IncrementalIndexStorageAdapter.java
@@ -547,7 +547,7 @@ public ObjectColumnSelector makeObjectColumnSelector(String column)
                     @Override
                     public Class classOfObject()
                     {
-                      return Long.TYPE;
+                      return Long.class;
                     }
 
                     @Override
diff --git a/processing/src/test/java/io/druid/query/aggregation/MetricSelectorUtils.java b/processing/src/test/java/io/druid/query/aggregation/MetricSelectorUtils.java
index c838b61b12a8..f08de1e7e601 100644
--- a/processing/src/test/java/io/druid/query/aggregation/MetricSelectorUtils.java
+++ b/processing/src/test/java/io/druid/query/aggregation/MetricSelectorUtils.java
@@ -31,7 +31,7 @@ public static ObjectColumnSelector<Float> wrap(final FloatColumnSelector selecto
       @Override
       public Class<Float> classOfObject()
       {
-        return Float.TYPE;
+        return Float.class;
       }
 
       @Override
diff --git a/processing/src/test/java/io/druid/segment/incremental/OnheapIncrementalIndexBenchmark.java b/processing/src/test/java/io/druid/segment/incremental/OnheapIncrementalIndexBenchmark.java
index 944b600e4061..712dfcd7fa6d 100644
--- a/processing/src/test/java/io/druid/segment/incremental/OnheapIncrementalIndexBenchmark.java
+++ b/processing/src/test/java/io/druid/segment/incremental/OnheapIncrementalIndexBenchmark.java
@@ -287,11 +287,11 @@ public void testConcurrentAddRead()
 
     final IncrementalIndex incrementalIndex = this.incrementalIndex.getConstructor(
         IncrementalIndexSchema.class,
-        Boolean.TYPE,
-        Boolean.TYPE,
-        Boolean.TYPE,
-        Boolean.TYPE,
-        Integer.TYPE
+        boolean.class,
+        boolean.class,
+        boolean.class,
+        boolean.class,
+        int.class
     ).newInstance(
         new IncrementalIndexSchema.Builder().withMetrics(factories).build(),
         true,