diff --git a/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampAggregationSelectTest.java b/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampAggregationSelectTest.java index 025bc6abd284..914835377610 100644 --- a/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampAggregationSelectTest.java +++ b/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampAggregationSelectTest.java @@ -101,7 +101,7 @@ public void setup() throws Exception temporaryFolder ); - selector = new TestObjectColumnSelector(values); + selector = new TestObjectColumnSelector<>(values); selectorFactory = EasyMock.createMock(ColumnSelectorFactory.class); EasyMock.expect(selectorFactory.makeObjectColumnSelector("test")).andReturn(selector); EasyMock.replay(selectorFactory); @@ -144,7 +144,7 @@ public void testSimpleDataIngestionAndSelectTest() throws Exception " }\n" + "]"; ZipFile zip = new ZipFile(new File(this.getClass().getClassLoader().getResource("druid.sample.tsv.zip").toURI())); - Sequence seq = helper.createIndexAndRunQueryOnSegment( + Sequence seq = helper.createIndexAndRunQueryOnSegment( zip.getInputStream(zip.getEntry("druid.sample.tsv")), recordParser, aggregator, diff --git a/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampGroupByAggregationTest.java b/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampGroupByAggregationTest.java index 2e5fa43d6909..c192c1032026 100644 --- a/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampGroupByAggregationTest.java +++ b/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampGroupByAggregationTest.java @@ -111,7 +111,7 @@ public void setup() throws Exception temporaryFolder ); - selector = new TestObjectColumnSelector(values); + selector = new TestObjectColumnSelector<>(values); selectorFactory = EasyMock.createMock(ColumnSelectorFactory.class); EasyMock.expect(selectorFactory.makeObjectColumnSelector("test")).andReturn(selector); EasyMock.replay(selectorFactory); diff --git a/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampMinMaxAggregatorTest.java b/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampMinMaxAggregatorTest.java index 56bdfba06867..b6d33cddbba5 100644 --- a/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampMinMaxAggregatorTest.java +++ b/extensions-contrib/time-min-max/src/test/java/io/druid/query/aggregation/TimestampMinMaxAggregatorTest.java @@ -123,7 +123,7 @@ public void configure(Binder binder) String json = "{\"type\":\"" + aggType + "\",\"name\":\"" + aggType + "\",\"fieldName\":\"test\"}"; aggregatorFactory = mapper.readValue(json, aggClass); - selector = new TestObjectColumnSelector(values); + selector = new TestObjectColumnSelector<>(values); selectorFactory = EasyMock.createMock(ColumnSelectorFactory.class); EasyMock.expect(selectorFactory.makeObjectColumnSelector("test")).andReturn(selector); EasyMock.replay(selectorFactory); diff --git a/extensions-core/stats/src/test/java/io/druid/query/aggregation/variance/VarianceAggregatorTest.java b/extensions-core/stats/src/test/java/io/druid/query/aggregation/variance/VarianceAggregatorTest.java index 48e220494c76..b671f1a78d6d 100644 --- a/extensions-core/stats/src/test/java/io/druid/query/aggregation/variance/VarianceAggregatorTest.java +++ b/extensions-core/stats/src/test/java/io/druid/query/aggregation/variance/VarianceAggregatorTest.java @@ -66,7 +66,8 @@ public void setup() { selector = new TestFloatColumnSelector(values); colSelectorFactory = EasyMock.createMock(ColumnSelectorFactory.class); - EasyMock.expect(colSelectorFactory.makeObjectColumnSelector("nilly")).andReturn(new TestObjectColumnSelector(0.0f)); + EasyMock.expect(colSelectorFactory.makeObjectColumnSelector("nilly")) + .andReturn(new TestObjectColumnSelector<>(new Object[] {0.0f})); EasyMock.expect(colSelectorFactory.makeFloatColumnSelector("nilly")).andReturn(selector); EasyMock.replay(colSelectorFactory); } diff --git a/processing/src/main/java/io/druid/query/scan/ScanQuery.java b/processing/src/main/java/io/druid/query/scan/ScanQuery.java index e635191153e2..463e0387894d 100644 --- a/processing/src/main/java/io/druid/query/scan/ScanQuery.java +++ b/processing/src/main/java/io/druid/query/scan/ScanQuery.java @@ -223,7 +223,7 @@ public String toString() * .build(); * * - * @see io.druid.query.scan.ScanQuery + * @see ScanQuery */ public static class ScanQueryBuilder { diff --git a/processing/src/main/java/io/druid/segment/Capabilities.java b/processing/src/main/java/io/druid/segment/Capabilities.java index 6e0cff5f323e..e2f981b74944 100644 --- a/processing/src/main/java/io/druid/segment/Capabilities.java +++ b/processing/src/main/java/io/druid/segment/Capabilities.java @@ -54,9 +54,9 @@ public CapabilitiesBuilder dimensionValuesSorted(boolean value) return this; } - public io.druid.segment.Capabilities build() + public Capabilities build() { - return new io.druid.segment.Capabilities( + return new Capabilities( dimensionValuesSorted ); } diff --git a/processing/src/test/java/io/druid/query/aggregation/JavaScriptAggregatorTest.java b/processing/src/test/java/io/druid/query/aggregation/JavaScriptAggregatorTest.java index e920ab0f7828..ea46da64a2bc 100644 --- a/processing/src/test/java/io/druid/query/aggregation/JavaScriptAggregatorTest.java +++ b/processing/src/test/java/io/druid/query/aggregation/JavaScriptAggregatorTest.java @@ -240,7 +240,9 @@ public void testAggregateMissingColumn() @Test public void testAggregateStrings() { - final TestObjectColumnSelector ocs = new TestObjectColumnSelector("what", null, new String[]{"hey", "there"}); + final TestObjectColumnSelector ocs = new TestObjectColumnSelector<>( + new Object[]{"what", null, new String[]{"hey", "there"}} + ); final JavaScriptAggregator agg = new JavaScriptAggregator( Collections.singletonList(ocs), JavaScriptAggregatorFactory.compileScript( diff --git a/processing/src/test/java/io/druid/query/aggregation/TestObjectColumnSelector.java b/processing/src/test/java/io/druid/query/aggregation/TestObjectColumnSelector.java index 7abe0da479db..d55f118bd816 100644 --- a/processing/src/test/java/io/druid/query/aggregation/TestObjectColumnSelector.java +++ b/processing/src/test/java/io/druid/query/aggregation/TestObjectColumnSelector.java @@ -23,13 +23,13 @@ /** */ -public class TestObjectColumnSelector implements ObjectColumnSelector +public class TestObjectColumnSelector implements ObjectColumnSelector { private final Object[] objects; private int index = 0; - public TestObjectColumnSelector(Object... objects) + public TestObjectColumnSelector(T[] objects) { this.objects = objects; } diff --git a/processing/src/test/java/io/druid/query/aggregation/first/DoubleFirstAggregationTest.java b/processing/src/test/java/io/druid/query/aggregation/first/DoubleFirstAggregationTest.java index 7de0b2a75ec1..53023b899823 100644 --- a/processing/src/test/java/io/druid/query/aggregation/first/DoubleFirstAggregationTest.java +++ b/processing/src/test/java/io/druid/query/aggregation/first/DoubleFirstAggregationTest.java @@ -60,7 +60,7 @@ public void setup() combiningAggFactory = (DoubleFirstAggregatorFactory) doubleFirstAggFactory.getCombiningFactory(); timeSelector = new TestLongColumnSelector(times); valueSelector = new TestDoubleColumnSelectorImpl(doubleValues); - objectSelector = new TestObjectColumnSelector(pairs); + objectSelector = new TestObjectColumnSelector<>(pairs); colSelectorFactory = EasyMock.createMock(ColumnSelectorFactory.class); EasyMock.expect(colSelectorFactory.makeLongColumnSelector(Column.TIME_COLUMN_NAME)).andReturn(timeSelector); EasyMock.expect(colSelectorFactory.makeDoubleColumnSelector("nilly")).andReturn(valueSelector); diff --git a/processing/src/test/java/io/druid/query/aggregation/first/FloatFirstAggregationTest.java b/processing/src/test/java/io/druid/query/aggregation/first/FloatFirstAggregationTest.java index d5775797dda7..75e639d57d1d 100644 --- a/processing/src/test/java/io/druid/query/aggregation/first/FloatFirstAggregationTest.java +++ b/processing/src/test/java/io/druid/query/aggregation/first/FloatFirstAggregationTest.java @@ -60,7 +60,7 @@ public void setup() combiningAggFactory = (FloatFirstAggregatorFactory) floatFirstAggregatorFactory.getCombiningFactory(); timeSelector = new TestLongColumnSelector(times); valueSelector = new TestFloatColumnSelector(floats); - objectSelector = new TestObjectColumnSelector(pairs); + objectSelector = new TestObjectColumnSelector<>(pairs); colSelectorFactory = EasyMock.createMock(ColumnSelectorFactory.class); EasyMock.expect(colSelectorFactory.makeLongColumnSelector(Column.TIME_COLUMN_NAME)).andReturn(timeSelector); EasyMock.expect(colSelectorFactory.makeFloatColumnSelector("nilly")).andReturn(valueSelector); diff --git a/processing/src/test/java/io/druid/query/aggregation/first/LongFirstAggregationTest.java b/processing/src/test/java/io/druid/query/aggregation/first/LongFirstAggregationTest.java index f9e3be856ddc..9bf9cdcc2567 100644 --- a/processing/src/test/java/io/druid/query/aggregation/first/LongFirstAggregationTest.java +++ b/processing/src/test/java/io/druid/query/aggregation/first/LongFirstAggregationTest.java @@ -59,7 +59,7 @@ public void setup() combiningAggFactory = (LongFirstAggregatorFactory) longFirstAggFactory.getCombiningFactory(); timeSelector = new TestLongColumnSelector(times); valueSelector = new TestLongColumnSelector(longValues); - objectSelector = new TestObjectColumnSelector(pairs); + objectSelector = new TestObjectColumnSelector<>(pairs); colSelectorFactory = EasyMock.createMock(ColumnSelectorFactory.class); EasyMock.expect(colSelectorFactory.makeLongColumnSelector(Column.TIME_COLUMN_NAME)).andReturn(timeSelector); EasyMock.expect(colSelectorFactory.makeLongColumnSelector("nilly")).andReturn(valueSelector); diff --git a/processing/src/test/java/io/druid/query/aggregation/last/DoubleLastAggregationTest.java b/processing/src/test/java/io/druid/query/aggregation/last/DoubleLastAggregationTest.java index 0202449eac40..6917dfa223e9 100644 --- a/processing/src/test/java/io/druid/query/aggregation/last/DoubleLastAggregationTest.java +++ b/processing/src/test/java/io/druid/query/aggregation/last/DoubleLastAggregationTest.java @@ -60,7 +60,7 @@ public void setup() combiningAggFactory = (DoubleLastAggregatorFactory) doubleLastAggFactory.getCombiningFactory(); timeSelector = new TestLongColumnSelector(times); valueSelector = new TestDoubleColumnSelectorImpl(doubles); - objectSelector = new TestObjectColumnSelector(pairs); + objectSelector = new TestObjectColumnSelector<>(pairs); colSelectorFactory = EasyMock.createMock(ColumnSelectorFactory.class); EasyMock.expect(colSelectorFactory.makeLongColumnSelector(Column.TIME_COLUMN_NAME)).andReturn(timeSelector); EasyMock.expect(colSelectorFactory.makeDoubleColumnSelector("nilly")).andReturn(valueSelector); diff --git a/processing/src/test/java/io/druid/query/aggregation/last/FloatLastAggregationTest.java b/processing/src/test/java/io/druid/query/aggregation/last/FloatLastAggregationTest.java index 480e7b583239..757e02e8e915 100644 --- a/processing/src/test/java/io/druid/query/aggregation/last/FloatLastAggregationTest.java +++ b/processing/src/test/java/io/druid/query/aggregation/last/FloatLastAggregationTest.java @@ -60,7 +60,7 @@ public void setup() combiningAggFactory = (FloatLastAggregatorFactory) floatLastAggregatorFactory.getCombiningFactory(); timeSelector = new TestLongColumnSelector(times); valueSelector = new TestFloatColumnSelector(floats); - objectSelector = new TestObjectColumnSelector(pairs); + objectSelector = new TestObjectColumnSelector<>(pairs); colSelectorFactory = EasyMock.createMock(ColumnSelectorFactory.class); EasyMock.expect(colSelectorFactory.makeLongColumnSelector(Column.TIME_COLUMN_NAME)).andReturn(timeSelector); EasyMock.expect(colSelectorFactory.makeFloatColumnSelector("nilly")).andReturn(valueSelector); diff --git a/processing/src/test/java/io/druid/query/aggregation/last/LongLastAggregationTest.java b/processing/src/test/java/io/druid/query/aggregation/last/LongLastAggregationTest.java index 8b530df3f0ff..855daa2a29f1 100644 --- a/processing/src/test/java/io/druid/query/aggregation/last/LongLastAggregationTest.java +++ b/processing/src/test/java/io/druid/query/aggregation/last/LongLastAggregationTest.java @@ -59,7 +59,7 @@ public void setup() combiningAggFactory = (LongLastAggregatorFactory) longLastAggFactory.getCombiningFactory(); timeSelector = new TestLongColumnSelector(times); valueSelector = new TestLongColumnSelector(longValues); - objectSelector = new TestObjectColumnSelector(pairs); + objectSelector = new TestObjectColumnSelector<>(pairs); colSelectorFactory = EasyMock.createMock(ColumnSelectorFactory.class); EasyMock.expect(colSelectorFactory.makeLongColumnSelector(Column.TIME_COLUMN_NAME)).andReturn(timeSelector); EasyMock.expect(colSelectorFactory.makeLongColumnSelector("nilly")).andReturn(valueSelector);