From d50dc7faf5fa2c175884eb597834dcd9eedcf15d Mon Sep 17 00:00:00 2001 From: Clint Wylie Date: Tue, 3 Jul 2018 03:44:01 -0700 Subject: [PATCH] coordinator slight optimze load rule to skip drop if numToDrop is 0 --- .../java/io/druid/server/coordinator/rules/LoadRule.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/server/src/main/java/io/druid/server/coordinator/rules/LoadRule.java b/server/src/main/java/io/druid/server/coordinator/rules/LoadRule.java index 094deddca60b..b8ea703c7a69 100644 --- a/server/src/main/java/io/druid/server/coordinator/rules/LoadRule.java +++ b/server/src/main/java/io/druid/server/coordinator/rules/LoadRule.java @@ -322,7 +322,11 @@ private void drop( } else { final int currentReplicantsInTier = entry.getIntValue(); final int numToDrop = currentReplicantsInTier - targetReplicants.getOrDefault(tier, 0); - numDropped = dropForTier(numToDrop, holders, segment, params.getBalancerStrategy()); + if (numToDrop > 0) { + numDropped = dropForTier(numToDrop, holders, segment, params.getBalancerStrategy()); + } else { + numDropped = 0; + } } stats.addToTieredStat(DROPPED_COUNT, tier, numDropped);