From 437100489f4eb380db164e0e3f311015fae04b10 Mon Sep 17 00:00:00 2001 From: Roman Leventov Date: Mon, 12 Nov 2018 19:11:01 +0100 Subject: [PATCH 1/3] Prohibit String.replace() and String.replaceAll(), fix and prohibit some toString()-related redundancies --- .idea/inspectionProfiles/Druid.xml | 4 + .../DimensionPredicateFilterBenchmark.java | 2 +- ...loatCompressionBenchmarkFileGenerator.java | 2 +- ...LongCompressionBenchmarkFileGenerator.java | 2 +- .../benchmark/BenchmarkDataGeneratorTest.java | 2 +- codestyle/checkstyle.xml | 7 ++ codestyle/druid-forbidden-apis.txt | 5 ++ .../druid/java/util/common/StringUtils.java | 84 +++++++++++++++---- .../common/granularity/PeriodGranularity.java | 6 +- .../emitter/core/ParametrizedUriEmitter.java | 3 +- .../core/ParametrizedUriExtractor.java | 2 +- .../java/org/apache/druid/math/expr/Expr.java | 4 +- .../org/apache/druid/math/expr/Function.java | 8 +- .../druid/common/utils/UUIDUtilsTest.java | 3 +- .../java/util/common/StringUtilsTest.java | 25 +++++- .../core/ParametrizedUriEmitterTest.java | 2 +- .../util/http/client/FriendlyServersTest.java | 2 +- .../util/http/client/JankyServersTest.java | 2 +- .../java/util/metrics/cgroups/TestUtils.java | 6 +- .../wikipedia/WikipediaIrcDecoder.java | 32 +++---- .../storage/azure/AzureDataSegmentPusher.java | 2 +- .../azure/AzureDataSegmentPusherTest.java | 3 +- .../storage/cloudfiles/CloudFilesUtils.java | 2 +- .../google/GoogleDataSegmentKiller.java | 2 +- .../druid/storage/google/GoogleTaskLogs.java | 4 +- .../druid/storage/google/GoogleUtils.java | 6 +- .../google/GoogleDataSegmentKillerTest.java | 2 +- .../emitter/graphite/GraphiteEmitter.java | 2 +- .../druid/data/input/influx/InfluxParser.java | 9 +- .../MaterializedViewQuery.java | 4 +- .../emitter/opentsdb/EventConverter.java | 10 +-- .../input/orc/OrcHadoopInputRowParser.java | 8 +- .../druid/emitter/statsd/StatsDEmitter.java | 17 ++-- .../input/AvroStreamInputRowParserTest.java | 19 +++-- .../hll/HllSketchAggregatorFactory.java | 16 ++-- .../theta/SketchEstimateWithErrorBounds.java | 10 +-- .../druid/query/filter/BloomKFilter.java | 2 +- .../storage/hdfs/HdfsDataSegmentFinder.java | 2 +- .../storage/hdfs/HdfsDataSegmentPusher.java | 2 +- .../storage/hdfs/tasklog/HdfsTaskLogs.java | 4 +- .../loading/HdfsDataSegmentFinderTest.java | 4 +- .../hdfs/HdfsDataSegmentPullerTest.java | 6 +- .../hdfs/HdfsDataSegmentPusherTest.java | 6 +- .../lookup/KafkaLookupExtractorFactory.java | 2 +- .../namespace/UriCacheGeneratorTest.java | 3 +- .../cache/loading/OffHeapLoadingCache.java | 2 +- .../storage/mysql/MySQLConnector.java | 2 +- .../protobuf/ProtobufInputRowParser.java | 2 +- .../firehose/s3/StaticS3FirehoseFactory.java | 4 +- .../org/apache/druid/storage/s3/S3Utils.java | 6 +- .../storage/s3/S3DataSegmentPusherTest.java | 3 +- .../indexer/HadoopDruidIndexerConfig.java | 7 +- .../org/apache/druid/indexer/JobHelper.java | 6 +- .../java/org/apache/druid/indexer/Utils.java | 6 +- .../indexer/updater/HadoopConverterJob.java | 2 +- .../org/apache/druid/indexer/UtilsTest.java | 2 +- .../autoscaling/ec2/StringEC2UserData.java | 24 +++--- .../overlord/http/OverlordResource.java | 2 +- .../common/task/MergeTaskBaseTest.java | 2 +- .../OverlordSecurityResourceFilterTest.java | 4 +- .../CoordinatorResourceTestClient.java | 3 +- .../druid/tests/hadoop/ITHadoopIndexTest.java | 3 +- .../AbstractITRealtimeIndexTaskTest.java | 24 +++--- ...penderatorDriverRealtimeIndexTaskTest.java | 3 +- .../tests/indexer/ITCompactionTaskTest.java | 4 +- .../indexer/ITKafkaIndexingServiceTest.java | 28 +++---- .../druid/tests/indexer/ITKafkaTest.java | 36 ++++---- .../indexer/ITRealtimeIndexTaskTest.java | 3 +- .../druid/tests/indexer/ITUnionQueryTest.java | 6 +- pom.xml | 2 +- .../bitmap/WrappedConciseBitmap.java | 2 +- .../bitmap/WrappedImmutableConciseBitmap.java | 2 +- .../bitmap/WrappedImmutableRoaringBitmap.java | 2 +- .../bitmap/WrappedRoaringBitmap.java | 2 +- .../query/extraction/CascadeExtractionFn.java | 3 +- .../StringRuntimeShape.java | 2 +- .../search/BySegmentSearchResultValue.java | 2 +- .../query/topn/BySegmentTopNResultValue.java | 2 +- .../collections/bitmap/BitmapBenchmark.java | 4 +- .../druid/segment/filter/BaseFilterTest.java | 8 +- .../client/coordinator/CoordinatorClient.java | 2 +- .../discovery/CuratorServiceUtils.java | 2 +- .../loading/LocalDataSegmentPusher.java | 2 +- .../EventReceiverFirehoseFactory.java | 5 +- .../realtime/plumber/RealtimePlumber.java | 11 ++- .../druid/server/coordination/ServerType.java | 4 +- .../server/http/DatasourcesResource.java | 6 +- .../druid/server/http/IntervalsResource.java | 2 +- .../druid/server/metrics/MonitorsConfig.java | 9 +- .../apache/druid/curator/CuratorTestBase.java | 2 +- .../discovery/ServiceAnnouncerTest.java | 2 +- .../druid/metadata/TestDerbyConnector.java | 2 +- .../loading/LocalDataSegmentPusherTest.java | 7 +- .../AsyncQueryForwardingServletTest.java | 7 +- .../server/http/DatasourcesResourceTest.java | 2 +- .../security/SecurityResourceFilterTest.java | 5 +- .../server/log/FileRequestLoggerTest.java | 2 +- .../druid/cli/convert/PrefixRename.java | 69 --------------- .../druid/sql/avatica/AvaticaMonitor.java | 3 +- .../druid/sql/calcite/planner/Calcites.java | 15 +++- .../sql/calcite/schema/SystemSchema.java | 2 +- .../calcite/expression/ExpressionsTest.java | 4 +- 102 files changed, 395 insertions(+), 335 deletions(-) delete mode 100644 services/src/main/java/org/apache/druid/cli/convert/PrefixRename.java diff --git a/.idea/inspectionProfiles/Druid.xml b/.idea/inspectionProfiles/Druid.xml index 4ada21411dcf..d3d187c9c772 100644 --- a/.idea/inspectionProfiles/Druid.xml +++ b/.idea/inspectionProfiles/Druid.xml @@ -113,9 +113,11 @@ + + @@ -251,6 +253,7 @@ + @@ -261,6 +264,7 @@ +